@applitools/dom-utils - npm Package Compare versions

Comparing version 4.3.4 to 4.4.0

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+# [4.4.0](https://github.com/applitools/eyes.sdk.javascript1/compare/@applitools/dom-utils@4.3.4...@applitools/dom-utils@4.4.0) (2019-01-16)
+
+
+### Features
+
+* finalize eyes-rendering pkg, continue introduction of eyes-common ([c3367b7](https://github.com/applitools/eyes.sdk.javascript1/commit/c3367b7))
+
+
+
+
+
 ## [4.3.4](https://github.com/applitools/eyes.sdk.javascript1/compare/@applitools/dom-utils@4.3.3...@applitools/dom-utils@4.3.4) (2018-12-12)
@@ -8,0 +19,0 @@

lib/DomCapture.js

@@ -6,3 +6,3 @@ 'use strict';
 
-const url = require('url');
+const { URL } = require('url');
 const axios = require('axios');
@@ -12,3 +12,3 @@ const shadyCss = require('shady-css-parser');
 
-const { Location, GeneralUtils, PerformanceUtils } = require('@applitools/eyes-sdk-core');
+const { Location, GeneralUtils, PerformanceUtils } = require('@applitools/eyes-common');
 
@@ -271,9 +271,10 @@ class DomCapture {
       // let href = cssParser.parse(value);
-      let href = value;
-      if (!GeneralUtils.isAbsoluteUrl(href)) {
-        href = url.resolve(baseUri, href);
+      let downloadUrl = value;
+      if (!GeneralUtils.isAbsoluteUrl(downloadUrl)) {
+        const { href } = new URL(downloadUrl, baseUri);
+        downloadUrl = href;
       }
 
       const timeStart = PerformanceUtils.start();
-      const response = await axios(href);
+      const response = await axios(downloadUrl);
       const css = response.data;
@@ -280,0 +281,0 @@ this._logger.verbose(`downloading CSS in length of ${css.length} chars took ${timeStart.end().summary}`);

package.json

 {
   "name": "@applitools/dom-utils",
-  "version": "4.3.4",
+  "version": "4.4.0",
   "description": "Applitools DOM Utils is a shared utility package",
@@ -27,3 +27,3 @@ "keywords": [
   "dependencies": {
-    "@applitools/eyes-sdk-core": "^4.5.4",
+    "@applitools/eyes-common": "^1.2.0",
     "axios": "^0.18.0",
@@ -39,3 +39,4 @@ "css-url-parser": "^1.1.3",
   "scripts": {
-    "test:integration": "mocha ./test/**/*.spec.js -t 900000"
+    "test": "mocha --no-timeouts \"test/**/*.spec.js\"",
+    "test:e2e": "mocha --no-timeouts \"test/e2e/**/*.spec.js\""
   },
@@ -46,3 +47,3 @@ "license": "SEE LICENSE IN LICENSE",
   },
-  "gitHead": "dcad71f309828daf9be10dcdf0c384ab833c3db9"
+  "gitHead": "a182e9e310884d337311d252f5646b34609d2d69"
 }

No alert changes

Improved metrics

Total package byte prevSize

29050

increased by1.5%

Lines of code

348

increased by0.29%

Dependency changes

• + Added@applitools/eyes-common@^1.2.0

• - Removed@applitools/eyes-sdk-core@^4.5.4

• - Removed@applitools/eyes-sdk-core@4.9.1(transitive)

• - Removedes6-promise-pool@2.5.0(transitive)