@atlaskit/drag-and-drop - npm Package Compare versions

Comparing version 0.12.0 to 0.13.0

CHANGELOG.md

 # @atlaskit/drag-and-drop
 
+## 0.13.0
+
+### Minor Changes
+
+- [`2582df26509`](https://bitbucket.org/atlassian/atlassian-frontend/commits/2582df26509) - Fixing a browser bug where after a drag finishes, a unrelated element can be entered into by the browser
+
+  - [Visual explanation of bug](https://twitter.com/alexandereardon/status/1633614212873465856)
+  - [Chrome bug](https://bugs.chromium.org/p/chromium/issues/detail?id=410328)
+
 ## 0.12.0
@@ -4,0 +13,0 @@

dist/cjs/ledger/lifecycle-manager.js

@@ -9,2 +9,3 @@ "use strict";
 var _enteringAndLeavingTheWindow = require("../util/entering-and-leaving-the-window");
+var _fixPostDragPointerBug = require("../util/fix-post-drag-pointer-bug");
 var _getInput = require("../util/get-input");
@@ -222,2 +223,8 @@ var _dispatchConsumerEvent = require("./dispatch-consumer-event");
       finish();
+
+      // Applying this fix after `dispatch.drop` so that frameworks have the opportunity
+      // to update UI in response to a "onDrop".
+      if (dragInterface.startedFrom === 'internal') {
+        (0, _fixPostDragPointerBug.fixPostDragPointerBug)(state);
+      }
     }
@@ -231,3 +238,11 @@ }, {
     type: 'dragend',
-    listener: cancel
+    listener: function listener() {
+      cancel();
+
+      // Applying this fix after `dispatch.drop` so that frameworks have the opportunity
+      // to update UI in response to a "onDrop".
+      if (dragInterface.startedFrom === 'internal') {
+        (0, _fixPostDragPointerBug.fixPostDragPointerBug)(state);
+      }
+    }
   },
@@ -234,0 +249,0 @@ // ## Detecting drag ending for removed draggables

dist/cjs/version.json

 {
 	"name": "@atlaskit/drag-and-drop",
-	"version": "0.12.0",
+	"version": "0.13.0",
 	"sideEffects": false
 }

dist/es2019/ledger/lifecycle-manager.js

 import { bindAll } from 'bind-event-listener';
 import { isLeavingWindow } from '../util/entering-and-leaving-the-window';
+import { fixPostDragPointerBug } from '../util/fix-post-drag-pointer-bug';
 import { getInput } from '../util/get-input';
@@ -218,2 +219,8 @@ import { makeDispatch } from './dispatch-consumer-event';
       finish();
+
+      // Applying this fix after `dispatch.drop` so that frameworks have the opportunity
+      // to update UI in response to a "onDrop".
+      if (dragInterface.startedFrom === 'internal') {
+        fixPostDragPointerBug(state);
+      }
     }
@@ -227,3 +234,11 @@ }, {
     type: 'dragend',
-    listener: cancel
+    listener() {
+      cancel();
+
+      // Applying this fix after `dispatch.drop` so that frameworks have the opportunity
+      // to update UI in response to a "onDrop".
+      if (dragInterface.startedFrom === 'internal') {
+        fixPostDragPointerBug(state);
+      }
+    }
   },
@@ -230,0 +245,0 @@ // ## Detecting drag ending for removed draggables

dist/es2019/version.json

 {
 	"name": "@atlaskit/drag-and-drop",
-	"version": "0.12.0",
+	"version": "0.13.0",
 	"sideEffects": false
 }

dist/esm/ledger/lifecycle-manager.js

 import { bindAll } from 'bind-event-listener';
 import { isLeavingWindow } from '../util/entering-and-leaving-the-window';
+import { fixPostDragPointerBug } from '../util/fix-post-drag-pointer-bug';
 import { getInput } from '../util/get-input';
@@ -215,2 +216,8 @@ import { makeDispatch } from './dispatch-consumer-event';
       finish();
+
+      // Applying this fix after `dispatch.drop` so that frameworks have the opportunity
+      // to update UI in response to a "onDrop".
+      if (dragInterface.startedFrom === 'internal') {
+        fixPostDragPointerBug(state);
+      }
     }
@@ -224,3 +231,11 @@ }, {
     type: 'dragend',
-    listener: cancel
+    listener: function listener() {
+      cancel();
+
+      // Applying this fix after `dispatch.drop` so that frameworks have the opportunity
+      // to update UI in response to a "onDrop".
+      if (dragInterface.startedFrom === 'internal') {
+        fixPostDragPointerBug(state);
+      }
+    }
   },
@@ -227,0 +242,0 @@ // ## Detecting drag ending for removed draggables

dist/esm/version.json

 {
 	"name": "@atlaskit/drag-and-drop",
-	"version": "0.12.0",
+	"version": "0.13.0",
 	"sideEffects": false
 }

package.json

 {
   "name": "@atlaskit/drag-and-drop",
-  "version": "0.12.0",
+  "version": "0.13.0",
   "description": "The core Atlassian drag and drop framework, optimized for performance.",
@@ -5,0 +5,0 @@ "repository": "https://bitbucket.org/atlassian/atlassian-frontend-mirror",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

240471

increased by6.9%

Number of package files

155

increased by2.65%

Lines of code

5772

increased by7.33%

Worsened metrics

Number of downloads

80

decreased by-12.09%

No dependency changes