@bikeshaving/crank
Advanced tools
Comparing version 0.3.8 to 0.3.9
# Changelog | ||
## [0.3.9] - 2020-03-05 | ||
### Fixed | ||
- Fixed style strings being incorrectly rendered by the HTMLRenderer (#191). | ||
## [0.3.8] - 2020-12-27 | ||
@@ -3,0 +6,0 @@ Various performance improvements. |
@@ -267,4 +267,4 @@ /** | ||
/** | ||
* Called when an element’s value is exposed via render, schedule, refresh, | ||
* refs, or generator yield expressions. | ||
* Called when an element’s rendered value is exposed via render, schedule, | ||
* refresh, refs, or generator yield expressions. | ||
* | ||
@@ -281,3 +281,2 @@ * @param value - The value of the element being read. Can be a node, a | ||
* strings. | ||
* | ||
*/ | ||
@@ -284,0 +283,0 @@ read(value: ElementValue<TNode>): TResult; |
@@ -360,4 +360,4 @@ 'use strict'; | ||
/** | ||
* Called when an element’s value is exposed via render, schedule, refresh, | ||
* refs, or generator yield expressions. | ||
* Called when an element’s rendered value is exposed via render, schedule, | ||
* refresh, refs, or generator yield expressions. | ||
* | ||
@@ -374,3 +374,2 @@ * @param value - The value of the element being read. Can be a node, a | ||
* strings. | ||
* | ||
*/ | ||
@@ -701,3 +700,4 @@ read(value) { | ||
} | ||
if (el._fb) { | ||
// Need to handle (_fb) fallback being the empty string. | ||
if (typeof el._fb !== "undefined") { | ||
el._fb = undefined; | ||
@@ -1050,6 +1050,6 @@ } | ||
setEventProperty(ev, "target", this); | ||
// The only possible errors in this block are errors thrown in callbacks, | ||
// and dispatchEvent is designed to only these errors rather than throwing | ||
// The only possible errors in this block are errors thrown by callbacks, | ||
// and dispatchEvent will only log these errors rather than throwing | ||
// them. Therefore, we place all code in a try block, log errors in the | ||
// catch block use unsafe return statement in the finally block. | ||
// catch block, and use an unsafe return statement in the finally block. | ||
// | ||
@@ -1056,0 +1056,0 @@ // Each early return within the try block returns true because while the |
@@ -43,3 +43,3 @@ 'use strict'; | ||
} | ||
function printStyle(style) { | ||
function printStyleObject(style) { | ||
const cssStrings = []; | ||
@@ -61,3 +61,8 @@ for (const [name, value] of Object.entries(style)) { | ||
case name === "style": | ||
attrs.push(`style="${escape(printStyle(value))}"`); | ||
if (typeof value === "string") { | ||
attrs.push(`style="${escape(value)}"`); | ||
} | ||
else { | ||
attrs.push(`style="${escape(printStyleObject(value))}"`); | ||
} | ||
break; | ||
@@ -64,0 +69,0 @@ case typeof value === "string": |
@@ -267,4 +267,4 @@ /** | ||
/** | ||
* Called when an element’s value is exposed via render, schedule, refresh, | ||
* refs, or generator yield expressions. | ||
* Called when an element’s rendered value is exposed via render, schedule, | ||
* refresh, refs, or generator yield expressions. | ||
* | ||
@@ -281,3 +281,2 @@ * @param value - The value of the element being read. Can be a node, a | ||
* strings. | ||
* | ||
*/ | ||
@@ -284,0 +283,0 @@ read(value: ElementValue<TNode>): TResult; |
14
crank.js
@@ -357,4 +357,4 @@ /// <reference types="./crank.d.ts" /> | ||
/** | ||
* Called when an element’s value is exposed via render, schedule, refresh, | ||
* refs, or generator yield expressions. | ||
* Called when an element’s rendered value is exposed via render, schedule, | ||
* refresh, refs, or generator yield expressions. | ||
* | ||
@@ -371,3 +371,2 @@ * @param value - The value of the element being read. Can be a node, a | ||
* strings. | ||
* | ||
*/ | ||
@@ -698,3 +697,4 @@ read(value) { | ||
} | ||
if (el._fb) { | ||
// Need to handle (_fb) fallback being the empty string. | ||
if (typeof el._fb !== "undefined") { | ||
el._fb = undefined; | ||
@@ -1047,6 +1047,6 @@ } | ||
setEventProperty(ev, "target", this); | ||
// The only possible errors in this block are errors thrown in callbacks, | ||
// and dispatchEvent is designed to only these errors rather than throwing | ||
// The only possible errors in this block are errors thrown by callbacks, | ||
// and dispatchEvent will only log these errors rather than throwing | ||
// them. Therefore, we place all code in a try block, log errors in the | ||
// catch block use unsafe return statement in the finally block. | ||
// catch block, and use an unsafe return statement in the finally block. | ||
// | ||
@@ -1053,0 +1053,0 @@ // Each early return within the try block returns true because while the |
@@ -40,3 +40,3 @@ /// <reference types="./html.d.ts" /> | ||
} | ||
function printStyle(style) { | ||
function printStyleObject(style) { | ||
const cssStrings = []; | ||
@@ -58,3 +58,8 @@ for (const [name, value] of Object.entries(style)) { | ||
case name === "style": | ||
attrs.push(`style="${escape(printStyle(value))}"`); | ||
if (typeof value === "string") { | ||
attrs.push(`style="${escape(value)}"`); | ||
} | ||
else { | ||
attrs.push(`style="${escape(printStyleObject(value))}"`); | ||
} | ||
break; | ||
@@ -61,0 +66,0 @@ case typeof value === "string": |
{ | ||
"name": "@bikeshaving/crank", | ||
"version": "0.3.8", | ||
"version": "0.3.9", | ||
"description": "Write JSX-driven components with functions, promises and generators.", | ||
@@ -5,0 +5,0 @@ "homepage": "https://crank.js.org", |
@@ -267,4 +267,4 @@ /** | ||
/** | ||
* Called when an element’s value is exposed via render, schedule, refresh, | ||
* refs, or generator yield expressions. | ||
* Called when an element’s rendered value is exposed via render, schedule, | ||
* refresh, refs, or generator yield expressions. | ||
* | ||
@@ -281,3 +281,2 @@ * @param value - The value of the element being read. Can be a node, a | ||
* strings. | ||
* | ||
*/ | ||
@@ -284,0 +283,0 @@ read(value: ElementValue<TNode>): TResult; |
Sorry, the diff of this file is not supported yet
Sorry, the diff of this file is not supported yet
Sorry, the diff of this file is not supported yet
Sorry, the diff of this file is not supported yet
Sorry, the diff of this file is too big to display
Sorry, the diff of this file is not supported yet
License Policy Violation
LicenseThis package is not allowed per your license policy. Review the package's license to ensure compliance.
Found 1 instance in 1 package
License Policy Violation
LicenseThis package is not allowed per your license policy. Review the package's license to ensure compliance.
Found 1 instance in 1 package
653931
7468