@devcycle/nodejs-server-sdk - npm Package Compare versions

Comparing version 1.33.1 to 1.33.2

config-manager/src/CDNConfigSource.js

@@ -39,3 +39,2 @@ "use strict";
         };
-        const projectConfig = (await res.json());
         this.logger.debug(`Downloaded config, status: ${res === null || res === void 0 ? void 0 : res.status}, etag: ${res === null || res === void 0 ? void 0 : res.headers.get('etag')}`);
@@ -46,3 +45,4 @@ if (res.status === 304) {
         }
-        else if (res.status === 200 && projectConfig) {
+        else if (res.status === 200) {
+            const projectConfig = (await res.json());
             const lastModifiedHeader = res.headers.get('last-modified');
@@ -49,0 +49,0 @@ if (this.isLastModifiedHeaderOld(lastModifiedHeader !== null && lastModifiedHeader !== void 0 ? lastModifiedHeader : null)) {

config-manager/src/index.js

@@ -155,3 +155,2 @@ "use strict";
         let retrievalMetadata;
-        let userError = null;
         const startTime = Date.now();
@@ -195,4 +194,8 @@ let responseTimeMS = 0;
             if (ex instanceof server_request_1.UserError) {
-                userError = ex;
+                this.cleanup();
+                throw ex;
             }
+            else if (this._hasConfig) {
+                this.logger.warn(`Failed to download config, using cached version. url: ${url}.`);
+            }
         }
@@ -212,10 +215,3 @@ if (projectConfig) {
         }
-        if (this._hasConfig) {
-            this.logger.warn(`Failed to download config, using cached version. url: ${url}.`);
-        }
-        else if (userError) {
-            this.cleanup();
-            throw userError;
-        }
-        else {
+        if (!this._hasConfig) {
             throw new Error('Failed to download DevCycle config.');
@@ -222,0 +218,0 @@ }

lib/shared/config-manager/src/CDNConfigSource.js

@@ -39,3 +39,2 @@ "use strict";
         };
-        const projectConfig = (await res.json());
         this.logger.debug(`Downloaded config, status: ${res === null || res === void 0 ? void 0 : res.status}, etag: ${res === null || res === void 0 ? void 0 : res.headers.get('etag')}`);
@@ -46,3 +45,4 @@ if (res.status === 304) {
         }
-        else if (res.status === 200 && projectConfig) {
+        else if (res.status === 200) {
+            const projectConfig = (await res.json());
             const lastModifiedHeader = res.headers.get('last-modified');
@@ -49,0 +49,0 @@ if (this.isLastModifiedHeaderOld(lastModifiedHeader !== null && lastModifiedHeader !== void 0 ? lastModifiedHeader : null)) {

lib/shared/config-manager/src/index.js

@@ -155,3 +155,2 @@ "use strict";
         let retrievalMetadata;
-        let userError = null;
         const startTime = Date.now();
@@ -195,4 +194,8 @@ let responseTimeMS = 0;
             if (ex instanceof server_request_1.UserError) {
-                userError = ex;
+                this.cleanup();
+                throw ex;
             }
+            else if (this._hasConfig) {
+                this.logger.warn(`Failed to download config, using cached version. url: ${url}.`);
+            }
         }
@@ -212,10 +215,3 @@ if (projectConfig) {
         }
-        if (this._hasConfig) {
-            this.logger.warn(`Failed to download config, using cached version. url: ${url}.`);
-        }
-        else if (userError) {
-            this.cleanup();
-            throw userError;
-        }
-        else {
+        if (!this._hasConfig) {
             throw new Error('Failed to download DevCycle config.');
@@ -222,0 +218,0 @@ }

package.json

 {
     "name": "@devcycle/nodejs-server-sdk",
-    "version": "1.33.1",
+    "version": "1.33.2",
     "description": "The DevCycle NodeJS Server SDK used for feature management.",
@@ -5,0 +5,0 @@ "license": "MIT",

src/index.d.ts

@@ -7,3 +7,3 @@ import { DevCycleClient } from './client';
 type DevCycleProvider = InstanceType<DevCycleProviderConstructor>;
-declare class DevCycleCloudClient<Variables extends VariableDefinitions = VariableDefinitions> extends InternalDevCycleCloudClient {
+declare class DevCycleCloudClient<Variables extends VariableDefinitions = VariableDefinitions> extends InternalDevCycleCloudClient<Variables> {
     private openFeatureProvider;
@@ -10,0 +10,0 @@ constructor(sdkKey: string, options: DevCycleServerSDKOptions, platformDetails: DevCyclePlatformDetails);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

357833

decreased by-0.13%

Lines of code

3453

decreased by-0.23%

No dependency changes