@fimbul/mimir - npm Package Compare versions

Comparing version 0.5.0-dev.20180311 to 0.5.0-dev.20180313

package.json

 {
   "name": "@fimbul/mimir",
-  "version": "0.5.0-dev.20180311",
+  "version": "0.5.0-dev.20180313",
   "description": "Core rules of the Fimbullinter project",
@@ -5,0 +5,0 @@ "main": "recommended.yaml",

README.md

@@ -38,2 +38,3 @@ # Mímir
 `no-useless-initializer` | Detects unnecessary initialization with `undefined`. | TSLint's rule `no-unnecessary-initializer` doesn't fix all parameter initializers and gives false positives for destructuring.
+`no-useless-predicate` | Detects redundant conditions that are either always true or always false. *requires type information* | Combination of TSLint's `strict-type-predicates`, `typeof-compare` and parts of `strict-boolean-expressions`.
 `prefer-dot-notation` | Prefer `obj.foo` over `obj['foo']` where possible. | Same as TSLint's `no-string-literal` rule, but more performant.
@@ -40,0 +41,0 @@ `prefer-number-isnan` | Prefer ES2015's `Number.isNaN` over the global `isNaN` mainly for performance. *requires type information* | No similar rule in TSLint.

src/rules/generator-require-yield.d.ts

@@ -9,3 +9,4 @@ import * as ts from 'typescript';
     private visitNode(wrap);
+    private shouldFail();
     private fail({asteriskToken, name});
 }

src/rules/generator-require-yield.js

@@ -22,3 +22,3 @@ "use strict";
                 wrap.children.forEach(this.visitNode, this);
-                if (!this.containsYield)
+                if (this.shouldFail())
                     this.fail(wrap.node.parent);
@@ -47,2 +47,5 @@ wrap = wrap.skip;
     }
+    shouldFail() {
+        return !this.containsYield;
+    }
     fail({ asteriskToken, name }) {
@@ -49,0 +52,0 @@ this.addFailure(asteriskToken.end - 1, asteriskToken.end, `Generator ${name === undefined ? '' : `'${name.getText(this.sourceFile).replace(/'/g, "\\'")}' `}contains no 'yield'.`);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

185100

increased by12.35%

Number of package files

84

increased by3.7%

Lines of code

2060

increased by15.28%

Number of lines in readme file

60

increased by1.69%

No dependency changes