@fluidframework/driver-utils - npm Package Compare versions

Comparing version 2.1.0-276985 to 2.1.0-281041

api-extractor.json

 {
 	"$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json",
-	"extends": "../../../common/build/build-common/api-extractor-base.esm.current.json"
+	"extends": "../../../common/build/build-common/api-extractor-model.esm.json"
 }

api-extractor/api-extractor.legacy.json

 {
 	"$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json",
-	"extends": "<projectFolder>/../../../common/build/build-common/api-extractor-base.esm.legacy.json"
+	"extends": "<projectFolder>/../../../common/build/build-common/api-extractor-report.esm.legacy.json"
 }

dist/adapters/compression/summaryblob/documentStorageServiceSummaryBlobCompressionAdapter.js

@@ -46,2 +46,4 @@ "use strict";
     static hasPrefix(blob) {
+        // TODO why are we non null asserting here?
+        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         const firstByte = client_utils_1.IsoBuffer.from(blob)[0];
@@ -58,3 +60,4 @@ // eslint-disable-next-line no-bitwise
             ? index_js_1.SummaryCompressionAlgorithm.None
-            : // eslint-disable-next-line no-bitwise
+            : // TODO why are we non null asserting here?
+                // eslint-disable-next-line no-bitwise, @typescript-eslint/no-non-null-assertion
                 client_utils_1.IsoBuffer.from(blob)[0] & 0x0f;
@@ -70,2 +73,4 @@ }
         if (algorithm === index_js_1.SummaryCompressionAlgorithm.None) {
+            // TODO why are we non null asserting here?
+            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             const firstByte = client_utils_1.IsoBuffer.from(blob)[0];
@@ -199,4 +204,3 @@ // eslint-disable-next-line no-bitwise
         (0, internal_1.assert)(typeof summary === "object", 0x6f7 /* summary must be a non-null object */);
-        for (const key of Object.keys(summary.tree)) {
-            const value = summary.tree[key];
+        for (const [key, value] of Object.entries(summary.tree)) {
             if (Boolean(value) && value.type === driver_definitions_1.SummaryType.Tree) {
@@ -203,0 +207,0 @@ const found = this.findMetadataHolderSummary(value);

dist/insecureUrlResolver.js

@@ -54,2 +54,4 @@ "use strict";
             const relativePath = tmpRelativePath ?? "";
+            // TODO why are we non null asserting here?
+            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             return this.resolveHelper(documentId, relativePath, parsedUrl.search);
@@ -59,2 +61,4 @@ }
             const fullPath = parsedUrl.pathname.substr(1);
+            // TODO why are we non null asserting here?
+            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             const documentId = fullPath.split("/")[0];
@@ -61,0 +65,0 @@ const documentRelativePath = fullPath.slice(documentId.length);

dist/legacy.d.ts

@@ -8,3 +8,3 @@ /*!
  * THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
- * Generated by "flub generate entrypoints" in @fluidframework/build-tools.
+ * Generated by "flub generate entrypoints" in @fluid-tools/build-cli.
  */
@@ -11,0 +11,0 @@

dist/packageVersion.d.ts

@@ -8,3 +8,3 @@ /*!
 export declare const pkgName = "@fluidframework/driver-utils";
-export declare const pkgVersion = "2.1.0-276985";
+export declare const pkgVersion = "2.1.0-281041";
 //# sourceMappingURL=packageVersion.d.ts.map

dist/packageVersion.js

@@ -11,3 +11,3 @@ "use strict";
 exports.pkgName = "@fluidframework/driver-utils";
-exports.pkgVersion = "2.1.0-276985";
+exports.pkgVersion = "2.1.0-281041";
 //# sourceMappingURL=packageVersion.js.map

dist/parallelRequests.js

@@ -453,9 +453,18 @@ "use strict";
         if (lastFetch === undefined) {
+            // TODO why are we non null asserting here?
+            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             (0, internal_1.assert)(deltas[0].sequenceNumber === fromTotal, 0x26d /* "wrong start" */);
         }
         else {
+            // TODO why are we non null asserting here?
+            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             (0, internal_1.assert)(deltas[0].sequenceNumber === lastFetch + 1, 0x26e /* "wrong start" */);
         }
+        // TODO why are we non null asserting here?
+        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         lastFetch = deltas[deltas.length - 1].sequenceNumber;
-        (0, internal_1.assert)(lastFetch - deltas[0].sequenceNumber + 1 === deltas.length, 0x26f /* "continuous and no duplicates" */);
+        (0, internal_1.assert)(
+        // TODO why are we non null asserting here?
+        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+        lastFetch - deltas[0].sequenceNumber + 1 === deltas.length, 0x26f /* "continuous and no duplicates" */);
         length += deltas.length;
@@ -462,0 +471,0 @@ queue.pushValue(deltas);

dist/prefetchDocumentStorageService.js

@@ -76,3 +76,3 @@ "use strict";
             if (blobKey.startsWith(".") || blobKey === "header" || blobKey.startsWith("quorum")) {
-                if (blob !== null) {
+                if (blob !== null && blob !== undefined) {
                     // We don't care if the prefetch succeeds
@@ -83,3 +83,3 @@ void this.cachedRead(blob);
             else if (!blobKey.startsWith("deltas")) {
-                if (blob !== null) {
+                if (blob !== null && blob !== undefined) {
                     secondary.push(blob);
@@ -89,4 +89,4 @@ }
         }
-        for (const subTree of Object.keys(tree.trees)) {
-            this.prefetchTreeCore(tree.trees[subTree], secondary);
+        for (const [_, snapshot] of Object.entries(tree.trees)) {
+            this.prefetchTreeCore(snapshot, secondary);
         }
@@ -93,0 +93,0 @@ }

dist/protocol/gitHelper.js

@@ -70,2 +70,4 @@ "use strict";
         // The flat output is breadth-first so we can assume we see tree nodes prior to their contents
+        // TODO why are we non null asserting here?
+        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         const node = lookup[entryPathDir];
@@ -72,0 +74,0 @@ // Add in either the blob or tree

dist/public.d.ts

@@ -8,3 +8,3 @@ /*!
  * THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
- * Generated by "flub generate entrypoints" in @fluidframework/build-tools.
+ * Generated by "flub generate entrypoints" in @fluid-tools/build-cli.
  */
@@ -11,0 +11,0 @@

internal.d.ts

@@ -8,5 +8,5 @@ /*!
  * THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
- * Generated by "flub generate entrypoints" in @fluidframework/build-tools.
+ * Generated by "flub generate entrypoints" in @fluid-tools/build-cli.
  */
 
 export * from "./lib/index.js";

legacy.d.ts

@@ -8,5 +8,5 @@ /*!
  * THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
- * Generated by "flub generate entrypoints" in @fluidframework/build-tools.
+ * Generated by "flub generate entrypoints" in @fluid-tools/build-cli.
  */
 
 export * from "./lib/legacy.js";

lib/adapters/compression/summaryblob/documentStorageServiceSummaryBlobCompressionAdapter.js

@@ -43,2 +43,4 @@ /*!
     static hasPrefix(blob) {
+        // TODO why are we non null asserting here?
+        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         const firstByte = IsoBuffer.from(blob)[0];
@@ -55,3 +57,4 @@ // eslint-disable-next-line no-bitwise
             ? SummaryCompressionAlgorithm.None
-            : // eslint-disable-next-line no-bitwise
+            : // TODO why are we non null asserting here?
+                // eslint-disable-next-line no-bitwise, @typescript-eslint/no-non-null-assertion
                 IsoBuffer.from(blob)[0] & 0x0f;
@@ -67,2 +70,4 @@ }
         if (algorithm === SummaryCompressionAlgorithm.None) {
+            // TODO why are we non null asserting here?
+            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             const firstByte = IsoBuffer.from(blob)[0];
@@ -196,4 +201,3 @@ // eslint-disable-next-line no-bitwise
         assert(typeof summary === "object", 0x6f7 /* summary must be a non-null object */);
-        for (const key of Object.keys(summary.tree)) {
-            const value = summary.tree[key];
+        for (const [key, value] of Object.entries(summary.tree)) {
             if (Boolean(value) && value.type === SummaryType.Tree) {
@@ -200,0 +204,0 @@ const found = this.findMetadataHolderSummary(value);

lib/insecureUrlResolver.js

@@ -48,2 +48,4 @@ /*!
             const relativePath = tmpRelativePath ?? "";
+            // TODO why are we non null asserting here?
+            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             return this.resolveHelper(documentId, relativePath, parsedUrl.search);
@@ -53,2 +55,4 @@ }
             const fullPath = parsedUrl.pathname.substr(1);
+            // TODO why are we non null asserting here?
+            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             const documentId = fullPath.split("/")[0];
@@ -55,0 +59,0 @@ const documentRelativePath = fullPath.slice(documentId.length);

lib/legacy.d.ts

@@ -8,3 +8,3 @@ /*!
  * THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
- * Generated by "flub generate entrypoints" in @fluidframework/build-tools.
+ * Generated by "flub generate entrypoints" in @fluid-tools/build-cli.
  */
@@ -11,0 +11,0 @@

lib/packageVersion.d.ts

@@ -8,3 +8,3 @@ /*!
 export declare const pkgName = "@fluidframework/driver-utils";
-export declare const pkgVersion = "2.1.0-276985";
+export declare const pkgVersion = "2.1.0-281041";
 //# sourceMappingURL=packageVersion.d.ts.map

lib/packageVersion.js

@@ -8,3 +8,3 @@ /*!
 export const pkgName = "@fluidframework/driver-utils";
-export const pkgVersion = "2.1.0-276985";
+export const pkgVersion = "2.1.0-281041";
 //# sourceMappingURL=packageVersion.js.map

lib/parallelRequests.js

@@ -448,9 +448,18 @@ /*!
         if (lastFetch === undefined) {
+            // TODO why are we non null asserting here?
+            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             assert(deltas[0].sequenceNumber === fromTotal, 0x26d /* "wrong start" */);
         }
         else {
+            // TODO why are we non null asserting here?
+            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             assert(deltas[0].sequenceNumber === lastFetch + 1, 0x26e /* "wrong start" */);
         }
+        // TODO why are we non null asserting here?
+        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         lastFetch = deltas[deltas.length - 1].sequenceNumber;
-        assert(lastFetch - deltas[0].sequenceNumber + 1 === deltas.length, 0x26f /* "continuous and no duplicates" */);
+        assert(
+        // TODO why are we non null asserting here?
+        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+        lastFetch - deltas[0].sequenceNumber + 1 === deltas.length, 0x26f /* "continuous and no duplicates" */);
         length += deltas.length;
@@ -457,0 +466,0 @@ queue.pushValue(deltas);

lib/prefetchDocumentStorageService.js

@@ -73,3 +73,3 @@ /*!
             if (blobKey.startsWith(".") || blobKey === "header" || blobKey.startsWith("quorum")) {
-                if (blob !== null) {
+                if (blob !== null && blob !== undefined) {
                     // We don't care if the prefetch succeeds
@@ -80,3 +80,3 @@ void this.cachedRead(blob);
             else if (!blobKey.startsWith("deltas")) {
-                if (blob !== null) {
+                if (blob !== null && blob !== undefined) {
                     secondary.push(blob);
@@ -86,4 +86,4 @@ }
         }
-        for (const subTree of Object.keys(tree.trees)) {
-            this.prefetchTreeCore(tree.trees[subTree], secondary);
+        for (const [_, snapshot] of Object.entries(tree.trees)) {
+            this.prefetchTreeCore(snapshot, secondary);
         }
@@ -90,0 +90,0 @@ }

lib/protocol/gitHelper.js

@@ -65,2 +65,4 @@ /*!
         // The flat output is breadth-first so we can assume we see tree nodes prior to their contents
+        // TODO why are we non null asserting here?
+        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         const node = lookup[entryPathDir];
@@ -67,0 +69,0 @@ // Add in either the blob or tree

lib/public.d.ts

@@ -8,3 +8,3 @@ /*!
  * THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
- * Generated by "flub generate entrypoints" in @fluidframework/build-tools.
+ * Generated by "flub generate entrypoints" in @fluid-tools/build-cli.
  */
@@ -11,0 +11,0 @@

package.json

 {
   "name": "@fluidframework/driver-utils",
-  "version": "2.1.0-276985",
+  "version": "2.1.0-281041",
   "description": "Collection of utility functions for Fluid drivers",
@@ -70,7 +70,7 @@ "homepage": "https://fluidframework.com",
   "dependencies": {
-    "@fluid-internal/client-utils": "2.1.0-276985",
-    "@fluidframework/core-interfaces": "2.1.0-276985",
-    "@fluidframework/core-utils": "2.1.0-276985",
-    "@fluidframework/driver-definitions": "2.1.0-276985",
-    "@fluidframework/telemetry-utils": "2.1.0-276985",
+    "@fluid-internal/client-utils": "2.1.0-281041",
+    "@fluidframework/core-interfaces": "2.1.0-281041",
+    "@fluidframework/core-utils": "2.1.0-281041",
+    "@fluidframework/driver-definitions": "2.1.0-281041",
+    "@fluidframework/telemetry-utils": "2.1.0-281041",
     "axios": "^1.6.2",
@@ -82,8 +82,8 @@ "lz4js": "^0.2.0",
     "@arethetypeswrong/cli": "^0.15.2",
-    "@biomejs/biome": "^1.7.3",
-    "@fluid-internal/mocha-test-setup": "2.1.0-276985",
-    "@fluid-tools/build-cli": "^0.39.0",
+    "@biomejs/biome": "~1.8.3",
+    "@fluid-internal/mocha-test-setup": "2.1.0-281041",
+    "@fluid-tools/build-cli": "^0.40.0",
     "@fluidframework/build-common": "^2.0.3",
-    "@fluidframework/build-tools": "^0.39.0",
-    "@fluidframework/driver-utils-previous": "npm:@fluidframework/driver-utils@2.0.0-rc.5.0.0",
+    "@fluidframework/build-tools": "^0.40.0",
+    "@fluidframework/driver-utils-previous": "npm:@fluidframework/driver-utils@2.0.0",
     "@fluidframework/eslint-config-fluid": "^5.3.0",
@@ -117,7 +117,8 @@ "@microsoft/api-extractor": "^7.45.1",
     "build": "fluid-build . --task build",
+    "build:api-reports": "concurrently \"npm:build:api-reports:*\"",
+    "build:api-reports:current": "api-extractor run --local --config api-extractor/api-extractor.current.json",
+    "build:api-reports:legacy": "api-extractor run --local --config api-extractor/api-extractor.legacy.json",
     "build:commonjs": "fluid-build . --task commonjs",
     "build:compile": "fluid-build . --task compile",
-    "build:docs": "concurrently \"npm:build:docs:*\"",
-    "build:docs:current": "api-extractor run --local",
-    "build:docs:legacy": "api-extractor run --local --config api-extractor/api-extractor.legacy.json",
+    "build:docs": "api-extractor run --local",
     "build:esnext": "tsc --project ./tsconfig.json",
@@ -129,3 +130,3 @@ "build:genver": "gen-version",
     "check:are-the-types-wrong": "attw --pack .",
-    "check:biome": "biome check . --formatter-enabled=true",
+    "check:biome": "biome check .",
     "check:exports": "concurrently \"npm:check:exports:*\"",
@@ -139,5 +140,6 @@ "check:exports:bundle-release-tags": "api-extractor run --config api-extractor/api-extractor-lint-bundle.json",
     "check:prettier": "prettier --check . --cache --ignore-path ../../../.prettierignore",
-    "ci:build:docs": "concurrently \"npm:ci:build:docs:*\"",
-    "ci:build:docs:current": "api-extractor run",
-    "ci:build:docs:legacy": "api-extractor run --config api-extractor/api-extractor.legacy.json",
+    "ci:build:api-reports": "concurrently \"npm:ci:build:api-reports:*\"",
+    "ci:build:api-reports:current": "api-extractor run --config api-extractor/api-extractor.current.json",
+    "ci:build:api-reports:legacy": "api-extractor run --config api-extractor/api-extractor.legacy.json",
+    "ci:build:docs": "api-extractor run",
     "clean": "rimraf --glob dist lib \"*.d.ts\" \"**/*.tsbuildinfo\" \"**/*.build.log\" _api-extractor-temp nyc",
@@ -147,3 +149,3 @@ "eslint": "eslint --format stylish src",
     "format": "npm run format:biome",
-    "format:biome": "biome check . --formatter-enabled=true --apply",
+    "format:biome": "biome check . --write",
     "format:prettier": "prettier --write . --cache --ignore-path ../../../.prettierignore",
@@ -150,0 +152,0 @@ "lint": "fluid-build . --task lint",

README.md

@@ -5,3 +5,3 @@ # @fluidframework/driver-utils
 
-<!-- AUTO-GENERATED-CONTENT:START (LIBRARY_PACKAGE_README:scripts=FALSE) -->
+<!-- AUTO-GENERATED-CONTENT:START (LIBRARY_PACKAGE_README_HEADER) -->
 
@@ -36,2 +36,11 @@ <!-- prettier-ignore-start -->
 
+<!-- prettier-ignore-end -->
+
+<!-- AUTO-GENERATED-CONTENT:END -->
+
+<!-- AUTO-GENERATED-CONTENT:START (LIBRARY_PACKAGE_README_FOOTER) -->
+
+<!-- prettier-ignore-start -->
+<!-- NOTE: This section is automatically generated using @fluid-tools/markdown-magic. Do not update these generated contents directly. -->
+
 ## API Documentation
@@ -41,2 +50,46 @@
 
+## Minimum Client Requirements
+
+These are the platform requirements for the current version of Fluid Framework Client Packages.
+These requirements err on the side of being too strict since within a major version they can be relaxed over time, but not made stricter.
+For Long Term Support (LTS) versions this can require supporting these platforms for several years.
+
+It is likely that other configurations will work, but they are not supported: if they stop working, we do not consider that a bug.
+If you would benefit from support for something not listed here, file an issue and the product team will evaluate your request.
+When making such a request please include if the configuration already works (and thus the request is just that it becomes officially supported), or if changes are required to get it working.
+
+### Supported Runtimes
+
+-   NodeJs ^20.10.0 except that we will drop support for it [when NodeJs 20 loses its upstream support on 2026-04-30](https://github.com/nodejs/release#release-schedule), and will support a newer LTS version of NodeJS (22) at least 1 year before 20 is end-of-life. This same policy applies to NodeJS 22 when it is end of life (2027-04-30).
+-   Modern browsers supporting the es2022 standard library: in response to asks we can add explicit support for using babel to polyfill to target specific standards or runtimes (meaning we can avoid/remove use of things that don't polyfill robustly, but otherwise target modern standards).
+
+### Supported Tools
+
+-   TypeScript 5.4:
+    -   All [`strict`](https://www.typescriptlang.org/tsconfig) options are supported.
+    -   [`strictNullChecks`](https://www.typescriptlang.org/tsconfig) is required.
+    -   [Configuration options deprecated in 5.0](https://github.com/microsoft/TypeScript/issues/51909) are not supported.
+    -   `exactOptionalPropertyTypes` is currently not fully supported.
+        If used, narrowing members of Fluid Framework types types using `in`, `Reflect.has`, `Object.hasOwn` or `Object.prototype.hasOwnProperty` should be avoided as they may incorrectly exclude `undefined` from the possible values in some cases.
+-   [webpack](https://webpack.js.org/) 5
+    -   We are not intending to be prescriptive about what bundler to use.
+        Other bundlers which can handle ES Modules should work, but webpack is the only one we actively test.
+
+### Module Resolution
+
+[`Node16`, `NodeNext`, or `Bundler`](https://www.typescriptlang.org/tsconfig#moduleResolution) resolution should be used with TypeScript compilerOptions to follow the [Node.js v12+ ESM Resolution and Loading algorithm](https://nodejs.github.io/nodejs.dev/en/api/v20/esm/#resolution-and-loading-algorithm).
+Node10 resolution is not supported as it does not support Fluid Framework's API structuring pattern that is used to distinguish stable APIs from those that are in development.
+
+### Module Formats
+
+-   ES Modules:
+    ES Modules are the preferred way to consume our client packages (including in NodeJs) and consuming our client packages from ES Modules is fully supported.
+-   CommonJs:
+    Consuming our client packages as CommonJs is supported only in NodeJS and only for the cases listed below.
+    This is done to accommodate some workflows without good ES Module support.
+    If you have a workflow you would like included in this list, file an issue.
+    Once this list of workflows motivating CommonJS support is empty, we may drop support for CommonJS one year after notice of the change is posted here.
+
+    -   Testing with Jest (which lacks [stable ESM support](https://jestjs.io/docs/ecmascript-modules) due to [unstable APIs in NodeJs](https://github.com/nodejs/node/issues/37648))
+
 ## Contribution Guidelines
@@ -43,0 +96,0 @@

src/adapters/compression/summaryblob/documentStorageServiceSummaryBlobCompressionAdapter.ts

@@ -64,3 +64,5 @@ /*!
 	private static hasPrefix(blob: ArrayBufferLike): boolean {
-		const firstByte = IsoBuffer.from(blob)[0];
+		// TODO why are we non null asserting here?
+		// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+		const firstByte = IsoBuffer.from(blob)[0]!;
 		// eslint-disable-next-line no-bitwise
@@ -77,4 +79,5 @@ return (firstByte & 0xf0) === 0xb0;
 			? SummaryCompressionAlgorithm.None
-			: // eslint-disable-next-line no-bitwise
-				IsoBuffer.from(blob)[0] & 0x0f;
+			: // TODO why are we non null asserting here?
+				// eslint-disable-next-line no-bitwise, @typescript-eslint/no-non-null-assertion
+				IsoBuffer.from(blob)[0]! & 0x0f;
 	}
@@ -93,3 +96,5 @@
 		if (algorithm === SummaryCompressionAlgorithm.None) {
-			const firstByte = IsoBuffer.from(blob)[0];
+			// TODO why are we non null asserting here?
+			// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+			const firstByte = IsoBuffer.from(blob)[0]!;
 			// eslint-disable-next-line no-bitwise
@@ -297,5 +302,3 @@ if ((firstByte & 0xf0) !== 0xb0) {
 		assert(typeof summary === "object", 0x6f7 /* summary must be a non-null object */);
-		for (const key of Object.keys(summary.tree)) {
-			const value = summary.tree[key];
-
+		for (const [key, value] of Object.entries(summary.tree)) {
 			if (Boolean(value) && value.type === SummaryType.Tree) {
@@ -302,0 +305,0 @@ const found = this.findMetadataHolderSummary(value);

src/insecureUrlResolver.ts

@@ -57,6 +57,10 @@ /*!
 			const relativePath = tmpRelativePath ?? "";
-			return this.resolveHelper(documentId, relativePath, parsedUrl.search);
+			// TODO why are we non null asserting here?
+			// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+			return this.resolveHelper(documentId!, relativePath, parsedUrl.search);
 		} else if (parsedUrl.host === window.location.host) {
 			const fullPath = parsedUrl.pathname.substr(1);
-			const documentId = fullPath.split("/")[0];
+			// TODO why are we non null asserting here?
+			// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+			const documentId = fullPath.split("/")[0]!;
 			const documentRelativePath = fullPath.slice(documentId.length);
@@ -63,0 +67,0 @@ return this.resolveHelper(documentId, documentRelativePath);

src/packageVersion.ts

@@ -9,2 +9,2 @@ /*!
 export const pkgName = "@fluidframework/driver-utils";
-export const pkgVersion = "2.1.0-276985";
+export const pkgVersion = "2.1.0-281041";

src/parallelRequests.ts

@@ -598,9 +598,17 @@ /*!
 			if (lastFetch === undefined) {
-				assert(deltas[0].sequenceNumber === fromTotal, 0x26d /* "wrong start" */);
+				// TODO why are we non null asserting here?
+				// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+				assert(deltas[0]!.sequenceNumber === fromTotal, 0x26d /* "wrong start" */);
 			} else {
-				assert(deltas[0].sequenceNumber === lastFetch + 1, 0x26e /* "wrong start" */);
+				// TODO why are we non null asserting here?
+				// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+				assert(deltas[0]!.sequenceNumber === lastFetch + 1, 0x26e /* "wrong start" */);
 			}
-			lastFetch = deltas[deltas.length - 1].sequenceNumber;
+			// TODO why are we non null asserting here?
+			// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+			lastFetch = deltas[deltas.length - 1]!.sequenceNumber;
 			assert(
-				lastFetch - deltas[0].sequenceNumber + 1 === deltas.length,
+				// TODO why are we non null asserting here?
+				// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+				lastFetch - deltas[0]!.sequenceNumber + 1 === deltas.length,
 				0x26f /* "continuous and no duplicates" */,
@@ -607,0 +615,0 @@ );

src/prefetchDocumentStorageService.ts

@@ -87,3 +87,3 @@ /*!
 			if (blobKey.startsWith(".") || blobKey === "header" || blobKey.startsWith("quorum")) {
-				if (blob !== null) {
+				if (blob !== null && blob !== undefined) {
 					// We don't care if the prefetch succeeds
@@ -93,3 +93,3 @@ void this.cachedRead(blob);
 			} else if (!blobKey.startsWith("deltas")) {
-				if (blob !== null) {
+				if (blob !== null && blob !== undefined) {
 					secondary.push(blob);
@@ -100,6 +100,6 @@ }
 
-		for (const subTree of Object.keys(tree.trees)) {
-			this.prefetchTreeCore(tree.trees[subTree], secondary);
+		for (const [_, snapshot] of Object.entries(tree.trees)) {
+			this.prefetchTreeCore(snapshot, secondary);
 		}
 	}
 }

src/protocol/gitHelper.ts

@@ -82,3 +82,5 @@ /*!
 		// The flat output is breadth-first so we can assume we see tree nodes prior to their contents
-		const node = lookup[entryPathDir];
+		// TODO why are we non null asserting here?
+		// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+		const node = lookup[entryPathDir]!;
 
@@ -85,0 +87,0 @@ // Add in either the blob or tree

tsconfig.json

@@ -9,4 +9,3 @@ {
 		"exactOptionalPropertyTypes": false,
-		"noUncheckedIndexedAccess": false,
 	},
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

772197

increased by1.55%

Number of package files

303

increased by0.66%

Lines of code

9269

increased by0.65%

Number of lines in readme file

129

increased by69.74%

Dependency changes

• + Added@fluid-internal/client-utils@2.1.0-281041(transitive)

• + Added@fluidframework/core-interfaces@2.1.0-281041(transitive)

• + Added@fluidframework/core-utils@2.1.0-281041(transitive)

• + Added@fluidframework/driver-definitions@2.1.0-281041(transitive)

• + Added@fluidframework/telemetry-utils@2.1.0-281041(transitive)

• - Removed@fluid-internal/client-utils@2.1.0-276985(transitive)

• - Removed@fluidframework/core-interfaces@2.1.0-276985(transitive)

• - Removed@fluidframework/core-utils@2.1.0-276985(transitive)

• - Removed@fluidframework/driver-definitions@2.1.0-276985(transitive)

• - Removed@fluidframework/telemetry-utils@2.1.0-276985(transitive)

• Updated@fluid-internal/client-utils@2.1.0-281041

• Updated@fluidframework/core-interfaces@2.1.0-281041

• Updated@fluidframework/core-utils@2.1.0-281041

• Updated@fluidframework/driver-definitions@2.1.0-281041

• Updated@fluidframework/telemetry-utils@2.1.0-281041