@guardian/anghammarad - npm Package Compare versions

Comparing version 1.0.0 to 1.0.1

package.json

 {
   "name": "@guardian/anghammarad",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "Notification service for the Guardian's dev teams",
@@ -5,0 +5,0 @@ "main": "dist/src/main.js",

test/main.test.ts

@@ -20,7 +20,7 @@ import {Anghammarad} from "../src/main";
   it("sets message as provided", () => {
-    expect(client.messageJson(defaultParams)).toContain(`"message":"message"`);
+    expect(JSON.parse(client.messageJson(defaultParams))).toMatchObject({message: "message"});
   });
 
   it("sets sender as provided", () =>{
-    expect(client.messageJson(defaultParams)).toContain(`"sender":"source"`)
+    expect(JSON.parse(client.messageJson(defaultParams))).toMatchObject({sender: "source"})
   })
@@ -30,19 +30,19 @@
     it("for 'All'", () => {
-      expect(client.messageJson(defaultParams)).toContain(`"channel":"all"`)
+      expect(JSON.parse(client.messageJson(defaultParams))).toMatchObject({channel: "all"})
     })
 
     it("for 'Email'", () => {
-      expect(client.messageJson({...defaultParams, channel: RequestedChannel.Email})).toContain(`"channel":"email"`)
+      expect(JSON.parse(client.messageJson({...defaultParams, channel: RequestedChannel.Email}))).toMatchObject({channel: "email"})
     })
 
     it("for 'Hangouts'", () => {
-      expect(client.messageJson({...defaultParams, channel: RequestedChannel.HangoutsChat})).toContain(`"channel":"hangouts"`)
+      expect(JSON.parse(client.messageJson({...defaultParams, channel: RequestedChannel.HangoutsChat}))).toMatchObject({channel:"hangouts"})
     })
 
     it("for 'Prefer Email'", () => {
-      expect(client.messageJson({...defaultParams, channel: RequestedChannel.PreferEmail})).toContain(`"channel":"prefer email"`)
+      expect(JSON.parse(client.messageJson({...defaultParams, channel: RequestedChannel.PreferEmail}))).toMatchObject({channel:"prefer email"})
     })
 
     it("for 'Prefer Hangouts'", () => {
-      expect(client.messageJson({...defaultParams, channel: RequestedChannel.PreferHangouts})).toContain(`"channel":"prefer hangouts"`)
+      expect(JSON.parse(client.messageJson({...defaultParams, channel: RequestedChannel.PreferHangouts}))).toMatchObject({channel:"prefer hangouts"})
     })
@@ -52,18 +52,18 @@ })
   it("includes target", () => {
-    const result = client.messageJson({...defaultParams, target: {Stack: "stack-name", App: "app-name"}})
-    expect(result).toContain(`"Stack":"stack-name"`)
-    expect(result).toContain(`"App":"app-name"`)
+    const result = JSON.parse(client.messageJson({...defaultParams, target: {Stack: "stack-name", App: "app-name"}}))
+    expect(result).toMatchObject({target:{Stack:"stack-name", App: "app-name"}})
   })
 
   it("includes actions", () => {
-    const result = client.messageJson({...defaultParams, actions: [{cta: "cta1", url: "url1"}, {cta: "cta2", url: "url2"}]})
-    expect(result).toContain(`"cta":"cta1"`)
-    expect(result).toContain(`"url":"url1"`)
-    expect(result).toContain(`"cta":"cta2"`)
-    expect(result).toContain(`"url":"url2"`)
+    const result = JSON.parse(client.messageJson({...defaultParams, actions: [{cta: "cta1", url: "url1"}, {cta: "cta2", url: "url2"}]}))
+    expect(result).toMatchObject({actions: [{cta: "cta1", url: "url1"}, {cta: "cta2", url: "url2"}]})
   })
 
+  it("produces valid JSON when quotes are contained in the data", () => {
+    expect(() => JSON.parse(client.messageJson({...defaultParams, message: `Message with "quotes"`}))).not.toThrow()
+  })
+
   it("properly escapes input", () => {
-    expect(client.messageJson({...defaultParams, message: `Message with "quotes"`})).toContain(`\"`)
+    expect(JSON.parse(client.messageJson({...defaultParams, message: `Message with "quotes"`}))).toMatchObject({message: `Message with "quotes"`})
   })
 })

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No README

Quality

Package does not have a README. This may indicate a failed publish or a low quality package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

14422

increased by1.9%

Number of medium quality alerts

1

decreased by-50%

Number of lines in readme file

132

increased byInfinity%

Worsened metrics

Number of package files

9

decreased by-40%

Lines of code

201

decreased by-40.88%

Number of medium supply chain risk alerts

1

increased byInfinity%

No dependency changes