@ioffice/tslint-config-ioffice - npm Package Compare versions

Comparing version 0.6.0 to 0.6.1

CHANGELOG.md

@@ -11,3 +11,7 @@ # Changelog
 
+## [0.6.1] - November 20, 2018
+*Sections*
 
+- Import Order: There should be 3 groups for imports: 3rd Party Libs, iOFFICE, and project modules.
+
 ## [0.6.0] - November 14, 2018
@@ -60,3 +64,4 @@ *Sections*
 
-[Unreleased]: https://github.com/ioffice/tslint-config-ioffice/compare/0.6.0...HEAD
+[Unreleased]: https://github.com/ioffice/tslint-config-ioffice/compare/0.6.1...HEAD
+[0.6.1]: https://github.com/ioffice/tslint-config-ioffice/compare/0.6.0...0.6.1
 [0.6.0]: https://github.com/ioffice/tslint-config-ioffice/compare/0.5.0...0.6.0
@@ -63,0 +68,0 @@ [0.5.0]: https://github.com/ioffice/tslint-config-ioffice/compare/0.4.1...0.5.0

package.json

 {
   "name": "@ioffice/tslint-config-ioffice",
-  "version": "0.6.0",
+  "version": "0.6.1",
   "description": "IOFFICE TypeScript Style Guide",
@@ -5,0 +5,0 @@ "main": "tslint-config-ioffice.json",

README.md

@@ -777,3 +777,7 @@ <!-- THIS IS AN AUTO-GENERATED FILE - DO NOT MODIFY MANUALLY -->
   <a name="modules--import-order"></a><a name="10.3"></a>
-  - [10.3](#modules--import-order) **Import Order**: Import statements should be alphabetized and grouped.
+  - [10.3](#modules--import-order) **Import Order**: Import statements should be alphabetized and sorted. Sources of different groups must be
+    sorted by 3rd party libraries, libraries provided by iOFFICE and finally local modules.
+    
+    Currently this is specified by the `io-import-style` since the `ordered-imports` rule has
+    not merged the change that will allow us to create custom groups.
 
@@ -804,3 +808,2 @@
     import { b } from '../parent/directory';
-    
     import { a } from './local/path';
@@ -820,3 +823,5 @@ ```
     import {longNameA, longNameB, longNameC, longNameD, longNameE} from 'path';
-    
+    ```
+
+    ```ts
     // good
@@ -823,0 +828,0 @@ import {

rules/index.d.ts

 import './ioExportStyleRule';
+import './ioImportStyleRule';
 declare const _default: {
@@ -3,0 +4,0 @@ rulesDirectory: string;

rules/index.js

 "use strict";
 require("./ioExportStyleRule");
+require("./ioImportStyleRule");
 module.exports = {
     rulesDirectory: "./rules",
 };

tslint-config-ioffice.json

@@ -10,9 +10,27 @@ {
     ],
-    "no-angle-bracket-type-assertion": true,
-    "ordered-imports": [
+    "io-import-style": [
       true,
       {
-        "grouped-imports": true
+        "named-imports-order": "lowercase-last",
+        "grouped-imports": true,
+        "groups": [
+          {
+            "name": "ioffice-libraries",
+            "match": "^@ioffice",
+            "order": 20
+          },
+          {
+            "name": "project-modules",
+            "match": "^[.\\^]",
+            "order": 40
+          },
+          {
+            "name": "3rd-party-libraries",
+            "match": ".*",
+            "order": 1
+          }
+        ]
       }
     ],
+    "no-angle-bracket-type-assertion": true,
     "no-multi-spaces": [
@@ -19,0 +37,0 @@ true,

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Long strings

Supply chain risk

Contains long string literals, which may be a sign of obfuscated or packed code.

Found 1 instance in 1 package

Mixed license

License

(Experimental) Package contains multiple licenses.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

67598

increased by94.78%

Number of package files

13

increased by18.18%

Lines of code

882

increased by235.36%

Number of lines in readme file

868

increased by0.58%

Worsened metrics

Number of low license alerts

1

increased byInfinity%

Number of low supply chain risk alerts

2

increased byInfinity%

Number of medium supply chain risk alerts

1

increased byInfinity%

No dependency changes