@mapbox/cloudfriend - npm Package Compare versions

Comparing version 7.3.0-6 to 7.3.0-8

.nyc_output/processinfo/index.json

@@ -1,1 +0,1 @@
-{"processes":{"541ae060-2e88-4f15-a797-36f90bbf7afd":{"parent":null,"children":["8f68394f-90ec-4f8c-8339-6c1c9278c571"]},"8f68394f-90ec-4f8c-8339-6c1c9278c571":{"parent":"541ae060-2e88-4f15-a797-36f90bbf7afd","children":[]}},"files":{"/Users/bilindhajer/cloudfriend/index.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/intrinsic.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/conditions.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/rules.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/pseudo.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/build.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/validate.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/merge.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/index.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/lambda.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/service-role.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/role.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/scheduled-lambda.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/event-lambda.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/queue-lambda.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/stream-lambda.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/cross-account-role.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/queue.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/s3-kinesis-firehose.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/kinesis-firehose-base.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/glue-database.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/glue-table.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/glue-json-table.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/glue-orc-table.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/glue-parquet-table.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/glue-presto-view.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/glue-spark-view.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/hookshot.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/log-subscription-lambda.js":["541ae060-2e88-4f15-a797-36f90bbf7afd","8f68394f-90ec-4f8c-8339-6c1c9278c571"],"/Users/bilindhajer/cloudfriend/bin/build-template.js":["8f68394f-90ec-4f8c-8339-6c1c9278c571"]},"externalIds":{}}
+{"processes":{"4a01d8fd-0d41-4652-b62f-80a9e0ee2e82":{"parent":null,"children":["ffdc1617-095c-45f0-ab0f-449e05e7b3a9"]},"ffdc1617-095c-45f0-ab0f-449e05e7b3a9":{"parent":"4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","children":[]}},"files":{"/Users/bilindhajer/cloudfriend/index.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/intrinsic.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/conditions.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/rules.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/pseudo.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/build.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/validate.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/merge.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/index.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/lambda.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/service-role.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/role.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/scheduled-lambda.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/event-lambda.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/queue-lambda.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/stream-lambda.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/cross-account-role.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/queue.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/s3-kinesis-firehose.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/kinesis-firehose-base.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/glue-database.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/glue-table.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/glue-json-table.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/glue-orc-table.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/glue-parquet-table.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/glue-presto-view.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/glue-spark-view.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/hookshot.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/lib/shortcuts/log-subscription-lambda.js":["4a01d8fd-0d41-4652-b62f-80a9e0ee2e82","ffdc1617-095c-45f0-ab0f-449e05e7b3a9"],"/Users/bilindhajer/cloudfriend/bin/build-template.js":["ffdc1617-095c-45f0-ab0f-449e05e7b3a9"]},"externalIds":{}}

changelog.md

 # Changelog
 
+## x.x.x
+
+- Updates `shortcuts.ScheduleLambda` to use EventBridge Scheduler instead of EventBridge Rules to schedule lambda invocations. When using this version your template will have the following changes per scheduled lambda instance, 
+
+```
+Add     AWS::IAM::Role
+Add     AWS::Scheduler::Schedule
+Remove  AWS::Lambda::Permission
+Remove  AWS::Events::Rule
+```
+
+Note a service role will automatically be created for the `AWS::Scheduler::Schedule` resource, if you do not specify a ScheduleRoleArn. 
+
+[Read more about the EventBridge Scheduler](https://docs.aws.amazon.com/scheduler/latest/UserGuide/managing-schedule-group.html)
+
 ## 7.1.0
@@ -4,0 +19,0 @@

lib/shortcuts/api.md

@@ -673,7 +673,8 @@ ## Classes
 
-| Param | Type | Default | Description |
-| --- | --- | --- | --- |
-| options | <code>Object</code> |  | Extends the options for [`Lambda`](#lambda) with the following additional attributes: |
-| options.ScheduleExpression | <code>String</code> |  | See [AWS documentation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-events-rule.html#cfn-events-rule-scheduleexpression). |
-| [options.State] | <code>String</code> | <code>&#x27;ENABLED&#x27;</code> | See [AWS documentation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-events-rule.html#cfn-events-rule-state). |
+| Param | Type | Description |
+| --- | --- | --- |
+| options | <code>Object</code> | Extends the options for [`Lambda`](#lambda) with the following additional attributes: |
+| options.ScheduleExpression | <code>String</code> | See [AWS documentation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-events-rule.html#cfn-events-rule-scheduleexpression). |
+| [options.ScheduleRoleArn] | <code>String</code> | If specified, the eventbride scheduler will use this role to invoke your lambda . _If this option is specified, do not use the Statement option; add the permissions you need to your Role directly._ See [AWS documentation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-scheduler-schedule-target.html#cfn-scheduler-schedule-target-rolearn) |
+| [options.ScheduleGroupName] | <code>String</code> | See [AWS documentation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-scheduler-schedule.html#cfn-scheduler-schedule-groupname). |
 
@@ -697,2 +698,32 @@ **Example**
 ```
+**Example**  
+```js
+const cf = require('@mapbox/cloudfriend');
+
+const myTemplate = { ... };
+
+const role = new cf.shortcuts.ServiceRole({
+  LogicalName: 'MyRole',
+  Service: 'scheduler.amazonaws.com',
+  Statement: [
+    {
+      Effect: 'Allow',
+      Action: 'lambda:InvokeFunction',
+      Resource: 'arn:aws:lambda:us-east-1:012345678901:function:my-role-*'
+    }
+  ]
+});
+
+const lambda = new cf.shortcuts.ScheduledLambda({
+  LogicalName: 'MyLambda',
+  Code: {
+    S3Bucket: 'my-code-bucket',
+    S3Key: 'path/to/code.zip'
+  },
+  ScheduleRoleArn: cf.ref('MyRole'),
+  ScheduleExpression: 'rate(1 hour)',
+});
+
+module.exports = cf.merge(myTemplate, role, lambda);
+```
 <a name="ServiceRole"></a>
@@ -699,0 +730,0 @@

lib/shortcuts/scheduled-lambda.js

@@ -14,3 +14,5 @@ 'use strict';
  * @param {String} options.ScheduleExpression - See [AWS documentation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-events-rule.html#cfn-events-rule-scheduleexpression).
- * @param {String} [options.State='ENABLED'] - See [AWS documentation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-events-rule.html#cfn-events-rule-state).
+ * @param {String} [options.ScheduleRoleArn=undefined] If specified, the eventbride scheduler will use this role to invoke your lambda . _If this option is specified, do not use the Statement option; add the permissions you need to your Role directly._
+ * See [AWS documentation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-scheduler-schedule-target.html#cfn-scheduler-schedule-target-rolearn)
+ * @param {String} [options.ScheduleGroupName=undefined] - See [AWS documentation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-scheduler-schedule.html#cfn-scheduler-schedule-groupname).
  *
@@ -32,2 +34,31 @@ * @example
  * module.exports = cf.merge(myTemplate, lambda);
+ *
+ * @example
+ * const cf = require('@mapbox/cloudfriend');
+ *
+ * const myTemplate = { ... };
+ *
+ * const role = new cf.shortcuts.ServiceRole({
+ *   LogicalName: 'MyRole',
+ *   Service: 'scheduler.amazonaws.com',
+ *   Statement: [
+ *     {
+ *       Effect: 'Allow',
+ *       Action: 'lambda:InvokeFunction',
+ *       Resource: 'arn:aws:lambda:us-east-1:012345678901:function:my-role-*'
+ *     }
+ *   ]
+ * });
+ *
+ * const lambda = new cf.shortcuts.ScheduledLambda({
+ *   LogicalName: 'MyLambda',
+ *   Code: {
+ *     S3Bucket: 'my-code-bucket',
+ *     S3Key: 'path/to/code.zip'
+ *   },
+ *   ScheduleRoleArn: cf.ref('MyRole'),
+ *   ScheduleExpression: 'rate(1 hour)',
+ * });
+ *
+ * module.exports = cf.merge(myTemplate, role, lambda);
  */
@@ -40,4 +71,5 @@ class ScheduledLambda extends Lambda {
     const {
+      ScheduleExpression,
       ScheduleRoleArn,
-      ScheduleExpression,
+      ScheduleGroupName,
       State = 'ENABLED'
@@ -74,2 +106,6 @@ } = options;
 
+    if (ScheduleGroupName) {
+      this.Resources[`${this.LogicalName}EventBridgeSchedule`].Properties.GroupName = ScheduleGroupName;
+    }
+
     if (ScheduleRoleArn) {
@@ -85,5 +121,5 @@ this.Resources[`${this.LogicalName}EventBridgeSchedule`].Properties.Target.RoleArn = ScheduleRoleArn;
             Effect: 'Allow',
-            Action: 'lambda:InvokeLambda',
+            Action: 'lambda:InvokeFunction',
             Resource: {
-              'Fn::GetAtt': [`${this.LogicalName}Logs`, 'Arn']
+              'Fn::GetAtt': [this.LogicalName, 'Arn']
             }
@@ -90,0 +126,0 @@ }

package.json

 {
   "name": "@mapbox/cloudfriend",
-  "version": "7.3.0-6",
+  "version": "7.3.0-8",
   "description": "Helper functions for assembling CloudFormation templates in JavaScript",
@@ -5,0 +5,0 @@ "main": "index.js",

test/fixtures/shortcuts/hookshot-github-secret-ref.json

@@ -31,3 +31,3 @@ {
         "DeploymentId": {
-          "Ref": "PassDeployment474705f9"
+          "Ref": "PassDeploymentd18750cb"
         },
@@ -51,3 +51,3 @@ "StageName": "hookshot",
     },
-    "PassDeployment474705f9": {
+    "PassDeploymentd18750cb": {
       "Type": "AWS::ApiGateway::Deployment",
@@ -54,0 +54,0 @@ "DependsOn": "PassMethod",

test/fixtures/shortcuts/hookshot-github-secret-string.json

@@ -27,3 +27,3 @@ {
         "DeploymentId": {
-          "Ref": "PassDeployment474705f9"
+          "Ref": "PassDeploymentd18750cb"
         },
@@ -47,3 +47,3 @@ "StageName": "hookshot",
     },
-    "PassDeployment474705f9": {
+    "PassDeploymentd18750cb": {
       "Type": "AWS::ApiGateway::Deployment",
@@ -50,0 +50,0 @@ "DependsOn": "PassMethod",

test/fixtures/shortcuts/hookshot-github.json

@@ -27,3 +27,3 @@ {
         "DeploymentId": {
-          "Ref": "PassDeployment474705f9"
+          "Ref": "PassDeploymentd18750cb"
         },
@@ -47,3 +47,3 @@ "StageName": "hookshot",
     },
-    "PassDeployment474705f9": {
+    "PassDeploymentd18750cb": {
       "Type": "AWS::ApiGateway::Deployment",
@@ -50,0 +50,0 @@ "DependsOn": "PassMethod",

test/fixtures/shortcuts/hookshot-passthrough-access-log-format.json

@@ -27,3 +27,3 @@ {
         "DeploymentId": {
-          "Ref": "PassDeployment474705f9"
+          "Ref": "PassDeploymentd18750cb"
         },
@@ -56,3 +56,3 @@ "StageName": "hookshot",
     },
-    "PassDeployment474705f9": {
+    "PassDeploymentd18750cb": {
       "Type": "AWS::ApiGateway::Deployment",
@@ -59,0 +59,0 @@ "DependsOn": "PassMethod",

test/fixtures/shortcuts/hookshot-passthrough-alarms.json

@@ -27,3 +27,3 @@ {
         "DeploymentId": {
-          "Ref": "PassDeployment474705f9"
+          "Ref": "PassDeploymentd18750cb"
         },
@@ -47,3 +47,3 @@ "StageName": "hookshot",
     },
-    "PassDeployment474705f9": {
+    "PassDeploymentd18750cb": {
       "Type": "AWS::ApiGateway::Deployment",
@@ -50,0 +50,0 @@ "DependsOn": "PassMethod",

test/fixtures/shortcuts/hookshot-passthrough-enhanced-logging.json

@@ -27,3 +27,3 @@ {
         "DeploymentId": {
-          "Ref": "PassDeployment474705f9"
+          "Ref": "PassDeploymentd18750cb"
         },
@@ -47,3 +47,3 @@ "StageName": "hookshot",
     },
-    "PassDeployment474705f9": {
+    "PassDeploymentd18750cb": {
       "Type": "AWS::ApiGateway::Deployment",
@@ -50,0 +50,0 @@ "DependsOn": "PassMethod",

test/fixtures/shortcuts/hookshot-passthrough-full-blown-logging.json

@@ -27,3 +27,3 @@ {
         "DeploymentId": {
-          "Ref": "PassDeployment474705f9"
+          "Ref": "PassDeploymentd18750cb"
         },
@@ -47,3 +47,3 @@ "StageName": "hookshot",
     },
-    "PassDeployment474705f9": {
+    "PassDeploymentd18750cb": {
       "Type": "AWS::ApiGateway::Deployment",
@@ -50,0 +50,0 @@ "DependsOn": "PassMethod",

test/fixtures/shortcuts/hookshot-passthrough-logging.json

@@ -27,3 +27,3 @@ {
         "DeploymentId": {
-          "Ref": "PassDeployment474705f9"
+          "Ref": "PassDeploymentd18750cb"
         },
@@ -47,3 +47,3 @@ "StageName": "hookshot",
     },
-    "PassDeployment474705f9": {
+    "PassDeploymentd18750cb": {
       "Type": "AWS::ApiGateway::Deployment",
@@ -50,0 +50,0 @@ "DependsOn": "PassMethod",

test/fixtures/shortcuts/hookshot-passthrough.json

@@ -27,3 +27,3 @@ {
         "DeploymentId": {
-          "Ref": "PassDeployment474705f9"
+          "Ref": "PassDeploymentd18750cb"
         },
@@ -47,3 +47,3 @@ "StageName": "hookshot",
     },
-    "PassDeployment474705f9": {
+    "PassDeploymentd18750cb": {
       "Type": "AWS::ApiGateway::Deployment",
@@ -50,0 +50,0 @@ "DependsOn": "PassMethod",

test/fixtures/shortcuts/scheduled-lambda-defaults.json

@@ -192,6 +192,6 @@ {
                   "Effect": "Allow",
-                  "Action": "lambda:InvokeLambda",
+                  "Action": "lambda:InvokeFunction",
                   "Resource": {
                     "Fn::GetAtt": [
-                      "MyLambdaLogs",
+                      "MyLambda",
                       "Arn"
@@ -198,0 +198,0 @@ ]

test/fixtures/shortcuts/scheduled-lambda-full.json

@@ -165,3 +165,4 @@ {
           }
-        }
+        },
+        "GroupName": "my-cool-stack"
       }
@@ -193,6 +194,6 @@ },
                   "Effect": "Allow",
-                  "Action": "lambda:InvokeLambda",
+                  "Action": "lambda:InvokeFunction",
                   "Resource": {
                     "Fn::GetAtt": [
-                      "MyLambdaLogs",
+                      "MyLambda",
                       "Arn"
@@ -199,0 +200,0 @@ ]

test/shortcuts.test.js

@@ -338,2 +338,3 @@ 'use strict';
     ScheduledRoleArn: 'arn:aws:iam::012345678901:role/MyCoolRole',
+    ScheduleGroupName: 'my-cool-stack',
     ScheduleExpression: 'rate(1 hour)',
@@ -340,0 +341,0 @@ State: 'DISABLED'

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

736523

increased by0.53%

Lines of code

14543

increased by0.26%

No dependency changes