@martin_hotell/schematics - npm Package Compare versions

Comparing version 0.2.0 to 0.2.1

CHANGELOG.md

@@ -5,2 +5,12 @@ # Change Log
 
+<a name="0.2.1"></a>
+## [0.2.1](https://github.com/Hotell/ng-cli-schematics/compare/v0.2.0...v0.2.1) (2018-03-29)
+
+
+### Bug Fixes
+
+* **application:** fix .angular-cli.json generation ([7cafe69](https://github.com/Hotell/ng-cli-schematics/commit/7cafe69))
+
+
+
 <a name="0.2.0"></a>
@@ -7,0 +17,0 @@ # [0.2.0](https://github.com/Hotell/ng-cli-schematics/compare/v0.1.1...v0.2.0) (2018-03-29)

package.json

 {
   "name": "@martin_hotell/schematics",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "Angular CLI schematics with better defaults",
@@ -5,0 +5,0 @@ "engines": {

README.md

@@ -50,5 +50,5 @@ # @martin_hotell/schematics
 > ```sh
-> mkdir -p /usr/local/lib/node_modules/@martin_hotell/schematics/
+> mkdir -p /usr/local/lib/node_modules/@angular/cli/node_modules/@martin_hotell/schematics
 >
-> cp -R /usr/local/lib/node_modules/@martin_hotell/schematics/* /usr/local/lib/node_modules/@angular/cli/node_modules/@martin_hotell/schematics/
+> cp -R /usr/local/lib/node_modules/@martin_hotell/schematics/* /usr/local/lib/node_modules/@angular/cli/node_modules/@martin_hotell/schematics
 > ```
@@ -59,3 +59,3 @@
 ```sh
-npx -p @angular/cli -p @martin_hotell/schematics -c 'ng new my-app --collection @martin_hotell/schematics'
+npx -p @angular-devkit/schematics-cli -p @angular-devkit/schematics -p @angular-devkit/core -p @angular/cli -p typescript -p @martin_hotell/schematics -c "ng new my-app --collection @martin_hotell/schematics"
 ```
@@ -62,0 +62,0 @@

src/application/files/__dot__angular-cli.json

@@ -57,4 +57,4 @@ {
       "changeDetection": "<%= changeDetection %>"<% if (minimal || inlineStyle) { %>,
-      "inlineStyle": true<% } %><% if (minimal || (inlineTemplate && inlineStyle)) { %>,<% } %><% if (minimal || inlineTemplate) { %>
-      "inlineTemplate": true<% } %><% if (minimal || (skipTests && (inlineStyle || inlineTemplate))) { %>,<% } %><% if (minimal || skipTests) { %>
+      "inlineStyle": true<% } %><% if (minimal || inlineTemplate) { %>,<% } %><% if (minimal || inlineTemplate) { %>
+      "inlineTemplate": true<% } %><% if (minimal || skipTests) { %>,<% } %><% if (minimal || skipTests) { %>
       "spec": false
@@ -61,0 +61,0 @@ <% } %>}<% if (minimal || skipTests) { %>,

src/application/index_spec.js

@@ -177,3 +177,23 @@ 'use strict';
   });
+  it(`should create valid .angular-cli.json file`, () => {
+    const options = Object.assign({}, defaultOptions, {
+      inlineTemplate: false,
+      inlineStyle: true,
+      changeDetection: 'OnPush',
+    });
+    const tree = schematicRunner.runSchematic('application', options);
+    const ngCliConfigPath = '/foo/.angular-cli.json';
+    const ngCliConfigContent = test_1.getFileContent(tree, ngCliConfigPath);
+    let thrownError = null;
+    try {
+      JSON.parse(ngCliConfigContent);
+    } catch (err) {
+      thrownError = err;
+    }
+    expect(thrownError).toBe(null);
+    expect(ngCliConfigContent).toMatch(/"changeDetection": "OnPush"/);
+    expect(ngCliConfigContent).toMatch(/"inlineStyle": true/);
+    expect(ngCliConfigContent).not.toMatch(/"inlineTemplate": false/);
+  });
 });
 //# sourceMappingURL=index_spec.js.map

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

593891

increased by0.31%

Lines of code

3842

increased by0.52%

No dependency changes