@okta/okta-sdk-nodejs - npm Package Compare versions

Comparing version 4.3.0 to 4.3.1

CHANGELOG.md

 # Okta Node SDK Changelog
 
+## 4.3.1
+
+### Bug Fixes
+
+- [#213](https://github.com/okta/okta-sdk-nodejs/pull/213) Fixes off-by-one error in Collection iterator
+
 ## 4.3.0
 
+### Features
+
 - [#210](https://github.com/okta/okta-sdk-nodejs/pull/210)
@@ -6,0 +14,0 @@ - Adds properties `RefreshToken` and `Jwks` to `OpenIdConnectApplicationSettingsClient` model

package.json

 {
   "name": "@okta/okta-sdk-nodejs",
-  "version": "4.3.0",
+  "version": "4.3.1",
   "description": "Okta API wrapper for Node.js",
@@ -66,6 +66,6 @@ "engines": {
   "okta": {
-    "commitSha": "6e452c788140e18ea96021ec34190b0f61589b39",
-    "fullVersion": "4.3.0-g6e452c7",
-    "testedSha": "31e985e991974631a2bd177e37f8471d8c8efd6c"
+    "commitSha": "e47962df9651e93ccac29c43f82041c3f175c82f",
+    "fullVersion": "4.3.1-ge47962d",
+    "testedSha": "a0c1c2d72000841b4536320b6cdddcbd0ed28250"
   }
 }

src/collection.js

@@ -41,6 +41,7 @@ /*!
       function nextItem() {
-        const item = self.currentItems.shift();
+        const done = !self.currentItems.length && !self.nextUri;
+        const item = self.currentItems.length && self.currentItems.shift();
         const result = {
           value: item ? self.factory.createInstance(item, self.client) : null,
-          done: !self.currentItems.length && !self.nextUri
+          done,
         };
@@ -54,2 +55,7 @@ resolve(result);
 
+      if (!self.nextUri) {
+        resolve({ done: true, value: null });
+        return;
+      }
+
       self.getNextPage()
@@ -56,0 +62,0 @@ .then(collection => {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

766122

increased by0.04%

Lines of code

18081

increased by0.03%

No dependency changes