@protobuf-ts/plugin-framework - npm Package Compare versions

Comparing version 2.0.0-alpha.22 to 2.0.0-alpha.23

build/commonjs/descriptor-info.js

@@ -85,9 +85,17 @@ "use strict";
     isMessageField(fieldDescriptor) {
-        let group = fieldDescriptor.type === descriptor_1.FieldDescriptorProto_Type.GROUP;
         let msg = fieldDescriptor.type === descriptor_1.FieldDescriptorProto_Type.MESSAGE;
-        if (fieldDescriptor.typeName !== undefined && (group || msg)) {
-            return !this.isMapField(fieldDescriptor);
+        if (!msg) {
+            return false;
         }
-        return false;
+        if (fieldDescriptor.name === undefined) {
+            return false;
+        }
+        if (this.isMapField(fieldDescriptor)) {
+            return false;
+        }
+        return true;
     }
+    isGroupField(fieldDescriptor) {
+        return fieldDescriptor.type === descriptor_1.FieldDescriptorProto_Type.GROUP;
+    }
     getMessageFieldMessage(fieldDescriptor) {
@@ -94,0 +102,0 @@ if (!this.isMessageField(fieldDescriptor)) {

build/commonjs/descriptor-registry.js

@@ -105,2 +105,5 @@ "use strict";
     }
+    isGroupField(fieldDescriptor) {
+        return this.descriptorInfo.isGroupField(fieldDescriptor);
+    }
     getMessageFieldMessage(fieldDescriptor) {
@@ -107,0 +110,0 @@ return this.descriptorInfo.getMessageFieldMessage(fieldDescriptor);

build/es2015/descriptor-info.js

@@ -81,9 +81,17 @@ import { DescriptorProto, EnumDescriptorProto, EnumValueDescriptorProto, FieldDescriptorProto, FieldDescriptorProto_Label, FieldDescriptorProto_Type, FileDescriptorProto, MethodDescriptorProto, OneofDescriptorProto, ServiceDescriptorProto } from "./google/protobuf/descriptor";
     isMessageField(fieldDescriptor) {
-        let group = fieldDescriptor.type === FieldDescriptorProto_Type.GROUP;
         let msg = fieldDescriptor.type === FieldDescriptorProto_Type.MESSAGE;
-        if (fieldDescriptor.typeName !== undefined && (group || msg)) {
-            return !this.isMapField(fieldDescriptor);
+        if (!msg) {
+            return false;
         }
-        return false;
+        if (fieldDescriptor.name === undefined) {
+            return false;
+        }
+        if (this.isMapField(fieldDescriptor)) {
+            return false;
+        }
+        return true;
     }
+    isGroupField(fieldDescriptor) {
+        return fieldDescriptor.type === FieldDescriptorProto_Type.GROUP;
+    }
     getMessageFieldMessage(fieldDescriptor) {
@@ -90,0 +98,0 @@ if (!this.isMessageField(fieldDescriptor)) {

build/es2015/descriptor-registry.js

@@ -102,2 +102,5 @@ import { FileDescriptorProto } from "./google/protobuf/descriptor";
     }
+    isGroupField(fieldDescriptor) {
+        return this.descriptorInfo.isGroupField(fieldDescriptor);
+    }
     getMessageFieldMessage(fieldDescriptor) {
@@ -104,0 +107,0 @@ return this.descriptorInfo.getMessageFieldMessage(fieldDescriptor);

build/types/descriptor-info.d.ts

@@ -86,6 +86,13 @@ import { DescriptorProto, EnumDescriptorProto, EnumOptions, EnumValueDescriptorProto, EnumValueOptions, FieldDescriptorProto, FieldDescriptorProto_Type, FieldOptions, FileDescriptorProto, FileOptions, MessageOptions, MethodDescriptorProto, MethodOptions, OneofDescriptorProto, OneofOptions, ServiceDescriptorProto, ServiceOptions } from "./google/protobuf/descriptor";
      * Returns false if this is a map field, even though map fields have type MESSAGE.
-     * Returns true if this is a group field (type GROUP).
+     *
+     * Before v2.0.0-alpha.23, this method returned true for group fields (type GROUP).
      */
     isMessageField(fieldDescriptor: FieldDescriptorProto): boolean;
     /**
+     * Is this a group field?
+     *
+     * Note that groups are deprecated and not supported in proto3.
+     */
+    isGroupField(fieldDescriptor: FieldDescriptorProto): boolean;
+    /**
      * Get the message descriptor for a message field.
@@ -216,2 +223,3 @@ */
     isMessageField(fieldDescriptor: FieldDescriptorProto): boolean;
+    isGroupField(fieldDescriptor: FieldDescriptorProto): boolean;
     getMessageFieldMessage(fieldDescriptor: FieldDescriptorProto): DescriptorProto;
@@ -218,0 +226,0 @@ isScalarField(fieldDescriptor: FieldDescriptorProto): boolean;

build/types/descriptor-registry.d.ts

@@ -59,2 +59,3 @@ import { DescriptorProto, EnumDescriptorProto, EnumOptions, EnumValueDescriptorProto, EnumValueOptions, FieldDescriptorProto, FieldOptions, FileDescriptorProto, FileOptions, MessageOptions, MethodDescriptorProto, MethodOptions, OneofDescriptorProto, OneofOptions, ServiceDescriptorProto, ServiceOptions } from "./google/protobuf/descriptor";
     isMessageField(fieldDescriptor: FieldDescriptorProto): boolean;
+    isGroupField(fieldDescriptor: FieldDescriptorProto): boolean;
     getMessageFieldMessage(fieldDescriptor: FieldDescriptorProto): DescriptorProto;
@@ -61,0 +62,0 @@ isScalarField(fieldDescriptor: FieldDescriptorProto): boolean;

package.json

 {
   "name": "@protobuf-ts/plugin-framework",
-  "version": "2.0.0-alpha.22",
+  "version": "2.0.0-alpha.23",
   "description": "framework to create protoc plugins",
@@ -36,6 +36,6 @@ "license": "(Apache-2.0 AND BSD-3-Clause)",
   "dependencies": {
-    "@protobuf-ts/runtime": "^2.0.0-alpha.22",
+    "@protobuf-ts/runtime": "^2.0.0-alpha.23",
     "typescript": ">=3.8.3 <4"
   },
-  "gitHead": "3745b1961d71d7619aebd2711521aafcc0e38988"
+  "gitHead": "1a7a6300765d240eaf3c52b71e00bb3bc9578c6c"
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

392153

increased by0.21%

Lines of code

9058

increased by0.34%

Dependency changes

• Updated@protobuf-ts/runtime@^2.0.0-alpha.23