@pwabuilder/pwainstall - npm Package Compare versions

Comparing version 1.2.0 to 1.2.1

package.json

 {
   "name": "@pwabuilder/pwainstall",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "",
@@ -5,0 +5,0 @@ "main": "dist/pwa-install.js",

src/pwa-install.ts

@@ -52,3 +52,2 @@ import {
       right: 0;
-      z-index: var(--modal-z-index);
      }
@@ -61,2 +60,3 @@
      #installModal {
+      position: absolute;
       background: var(--modal-background-color);
@@ -376,3 +376,3 @@ margin: 3em 12em;
       #buttonsContainer {
-        bottom: -1em;
+        height: 70px;
         background: transparent;
@@ -451,2 +451,3 @@ }
            box-shadow: none;
+           max-width: 100%;
          }
@@ -543,17 +544,7 @@
 
-    document.onkeyup = async (e) => {
-      console.log(e.key);
-      if (e.key === "Escape") {
-        this.openmodal = false;
-
-        if (this.hasAttribute('openmodal')) {
-          this.removeAttribute('openmodal');
-        }
-
-        let event = new CustomEvent('hide');
-        this.dispatchEvent(event);
-
-        await this.requestUpdate();
+    document.addEventListener('keyup', (event) => {
+      if (event.key === "Escape") {
+        this.cancel();
       }
-    }
+    });
   }
@@ -666,3 +657,3 @@
   shouldShowInstall(): boolean {
-    const eligibleUser = !this.usecustom && this.isSupportingBrowser && this.hasprompt === true || this.isIOS;
+    const eligibleUser = !this.usecustom && this.isSupportingBrowser && (this.hasprompt || this.isIOS);
     console.log('this.deferredprompt', this.deferredprompt);
@@ -738,4 +729,2 @@ console.log('this.isSupportingBrowser', this.isSupportingBrowser);
 
-      ${this.openmodal === true ? html`<div id="background" @click="${() => this.cancel()}"></div>` : null}
-
       ${
@@ -745,2 +734,3 @@ this.openmodal === true ?
           <div id="installModalWrapper">
+          ${this.openmodal ? html`<div id="background" @click="${() => this.cancel()}"></div>` : null}
           <div id="installModal">
@@ -747,0 +737,0 @@ <div id="headerContainer">

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

772478

decreased by-0.1%

Lines of code

2333

decreased by-0.3%

No dependency changes