@semcore/popper - npm Package Compare versions

Comparing version 5.38.0 to 5.38.1-prerelease.0

CHANGELOG.md

@@ -5,2 +5,8 @@ # Changelog
 
+## [5.38.1] - 2024-07-18
+
+### Fixed
+
+- Popper not opening a second time with interaction `focus`.
+
 ## [5.38.0] - 2024-07-13
@@ -7,0 +13,0 @@

lib/cjs/Popper.js

@@ -44,8 +44,8 @@ "use strict";
 /*__reshadow-styles__:"./style/popper.shadow.css"*/
-var style = ( /*__reshadow_css_start__*/_index.sstyled.insert( /*__inner_css_start__*/".___SPopper_yp4uz_gg_{outline:0;z-index:var(--intergalactic-z-index-popper, 700);color:var(--intergalactic-text-primary, #191b23)}.___SPopper_yp4uz_gg_.__keyboardFocused_yp4uz_gg_:focus:after{position:absolute;display:block;content:\"\";top:0;right:0;bottom:0;left:0;box-shadow:var(--intergalactic-keyboard-focus, 0px 0px 0px 3px rgba(0, 143, 248, 0.5));pointer-events:none;border-radius:var(--intergalactic-popper-rounded, 6px)}.___SPopper_yp4uz_gg_.__keyboardFocused_yp4uz_gg_.__hideFocus_yp4uz_gg_:focus:after{box-shadow:none}.___SFocusHint_yp4uz_gg_{display:none}.___STrigger_yp4uz_gg_:focus .___SFocusHint_yp4uz_gg_,.___STrigger_yp4uz_gg_:focus-within .___SFocusHint_yp4uz_gg_{display:inline}" /*__inner_css_end__*/, "yp4uz_gg_") /*__reshadow_css_end__*/, {
-  "__SPopper": "___SPopper_yp4uz_gg_",
-  "_keyboardFocused": "__keyboardFocused_yp4uz_gg_",
-  "_hideFocus": "__hideFocus_yp4uz_gg_",
-  "__SFocusHint": "___SFocusHint_yp4uz_gg_",
-  "__STrigger": "___STrigger_yp4uz_gg_"
+var style = ( /*__reshadow_css_start__*/_index.sstyled.insert( /*__inner_css_start__*/".___SPopper_1jjmc_gg_{outline:0;z-index:var(--intergalactic-z-index-popper, 700);color:var(--intergalactic-text-primary, #191b23)}.___SPopper_1jjmc_gg_.__keyboardFocused_1jjmc_gg_:focus:after{position:absolute;display:block;content:\"\";top:0;right:0;bottom:0;left:0;box-shadow:var(--intergalactic-keyboard-focus, 0px 0px 0px 3px rgba(0, 143, 248, 0.5));pointer-events:none;border-radius:var(--intergalactic-popper-rounded, 6px)}.___SPopper_1jjmc_gg_.__keyboardFocused_1jjmc_gg_.__hideFocus_1jjmc_gg_:focus:after{box-shadow:none}.___SFocusHint_1jjmc_gg_{display:none}.___STrigger_1jjmc_gg_:focus .___SFocusHint_1jjmc_gg_,.___STrigger_1jjmc_gg_:focus-within .___SFocusHint_1jjmc_gg_{display:inline}" /*__inner_css_end__*/, "1jjmc_gg_") /*__reshadow_css_end__*/, {
+  "__SPopper": "___SPopper_1jjmc_gg_",
+  "_keyboardFocused": "__keyboardFocused_1jjmc_gg_",
+  "_hideFocus": "__hideFocus_1jjmc_gg_",
+  "__SFocusHint": "___SFocusHint_1jjmc_gg_",
+  "__STrigger": "___STrigger_1jjmc_gg_"
 });
@@ -306,9 +306,17 @@ function isObject(obj) {
     (0, _defineProperty2["default"])((0, _assertThisInitialized2["default"])(_this), "handleTriggerBlur", function () {
-      setTimeout(function () {
-        if (!_this.asProps.visible) {
-          _this.setState({
-            ignoreTriggerFocusUntil: 0
-          });
-        }
-      }, 0);
+      var timeout = _this.asProps.timeout;
+      var timeoutConfig = typeof timeout === 'number' ? [timeout, timeout] : timeout;
+      var delay = timeoutConfig[1];
+      clearTimeout(_this.triggerBlurTimeout);
+      /** Need to call timeout with delay as for hiding */
+      _this.triggerBlurTimeout = setTimeout(function () {
+        /** Need to check visible prop in next frame because this.asProps updates only after rerender */
+        requestAnimationFrame(function () {
+          if (!_this.asProps.visible) {
+            _this.setState({
+              ignoreTriggerFocusUntil: 0
+            });
+          }
+        });
+      }, delay);
     });
@@ -427,3 +435,4 @@ (0, _defineProperty2["default"])((0, _assertThisInitialized2["default"])(_this), "handlePopperFocusOut", function (event) {
         popperRef: this.popperRef,
-        onBlur: (0, _assignProps3.callAllEventHandlers)(this.handleTriggerBlur, interactionProps.onBlur)
+        /** order of handlers is important here! */
+        onBlur: (0, _assignProps3.callAllEventHandlers)(interactionProps.onBlur, this.handleTriggerBlur)
       });
@@ -430,0 +439,0 @@ }

lib/es6/Popper.js

@@ -38,8 +38,8 @@ import _objectSpread from "@babel/runtime/helpers/objectSpread2";
 /*__reshadow-styles__:"./style/popper.shadow.css"*/
-var style = ( /*__reshadow_css_start__*/_sstyled.insert( /*__inner_css_start__*/".___SPopper_yp4uz_gg_{outline:0;z-index:var(--intergalactic-z-index-popper, 700);color:var(--intergalactic-text-primary, #191b23)}.___SPopper_yp4uz_gg_.__keyboardFocused_yp4uz_gg_:focus:after{position:absolute;display:block;content:\"\";top:0;right:0;bottom:0;left:0;box-shadow:var(--intergalactic-keyboard-focus, 0px 0px 0px 3px rgba(0, 143, 248, 0.5));pointer-events:none;border-radius:var(--intergalactic-popper-rounded, 6px)}.___SPopper_yp4uz_gg_.__keyboardFocused_yp4uz_gg_.__hideFocus_yp4uz_gg_:focus:after{box-shadow:none}.___SFocusHint_yp4uz_gg_{display:none}.___STrigger_yp4uz_gg_:focus .___SFocusHint_yp4uz_gg_,.___STrigger_yp4uz_gg_:focus-within .___SFocusHint_yp4uz_gg_{display:inline}" /*__inner_css_end__*/, "yp4uz_gg_") /*__reshadow_css_end__*/, {
-  "__SPopper": "___SPopper_yp4uz_gg_",
-  "_keyboardFocused": "__keyboardFocused_yp4uz_gg_",
-  "_hideFocus": "__hideFocus_yp4uz_gg_",
-  "__SFocusHint": "___SFocusHint_yp4uz_gg_",
-  "__STrigger": "___STrigger_yp4uz_gg_"
+var style = ( /*__reshadow_css_start__*/_sstyled.insert( /*__inner_css_start__*/".___SPopper_1jjmc_gg_{outline:0;z-index:var(--intergalactic-z-index-popper, 700);color:var(--intergalactic-text-primary, #191b23)}.___SPopper_1jjmc_gg_.__keyboardFocused_1jjmc_gg_:focus:after{position:absolute;display:block;content:\"\";top:0;right:0;bottom:0;left:0;box-shadow:var(--intergalactic-keyboard-focus, 0px 0px 0px 3px rgba(0, 143, 248, 0.5));pointer-events:none;border-radius:var(--intergalactic-popper-rounded, 6px)}.___SPopper_1jjmc_gg_.__keyboardFocused_1jjmc_gg_.__hideFocus_1jjmc_gg_:focus:after{box-shadow:none}.___SFocusHint_1jjmc_gg_{display:none}.___STrigger_1jjmc_gg_:focus .___SFocusHint_1jjmc_gg_,.___STrigger_1jjmc_gg_:focus-within .___SFocusHint_1jjmc_gg_{display:inline}" /*__inner_css_end__*/, "1jjmc_gg_") /*__reshadow_css_end__*/, {
+  "__SPopper": "___SPopper_1jjmc_gg_",
+  "_keyboardFocused": "__keyboardFocused_1jjmc_gg_",
+  "_hideFocus": "__hideFocus_1jjmc_gg_",
+  "__SFocusHint": "___SFocusHint_1jjmc_gg_",
+  "__STrigger": "___STrigger_1jjmc_gg_"
 });
@@ -299,9 +299,17 @@ function isObject(obj) {
     _defineProperty(_assertThisInitialized(_this), "handleTriggerBlur", function () {
-      setTimeout(function () {
-        if (!_this.asProps.visible) {
-          _this.setState({
-            ignoreTriggerFocusUntil: 0
-          });
-        }
-      }, 0);
+      var timeout = _this.asProps.timeout;
+      var timeoutConfig = typeof timeout === 'number' ? [timeout, timeout] : timeout;
+      var delay = timeoutConfig[1];
+      clearTimeout(_this.triggerBlurTimeout);
+      /** Need to call timeout with delay as for hiding */
+      _this.triggerBlurTimeout = setTimeout(function () {
+        /** Need to check visible prop in next frame because this.asProps updates only after rerender */
+        requestAnimationFrame(function () {
+          if (!_this.asProps.visible) {
+            _this.setState({
+              ignoreTriggerFocusUntil: 0
+            });
+          }
+        });
+      }, delay);
     });
@@ -420,3 +428,4 @@ _defineProperty(_assertThisInitialized(_this), "handlePopperFocusOut", function (event) {
         popperRef: this.popperRef,
-        onBlur: callAllEventHandlers(this.handleTriggerBlur, interactionProps.onBlur)
+        /** order of handlers is important here! */
+        onBlur: callAllEventHandlers(interactionProps.onBlur, this.handleTriggerBlur)
       });
@@ -423,0 +432,0 @@ }

package.json

 {
   "name": "@semcore/popper",
   "description": "Semrush Popper Component",
-  "version": "5.38.0",
+  "version": "5.38.1-prerelease.0",
   "main": "lib/cjs/index.js",
@@ -6,0 +6,0 @@ "module": "lib/es6/index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

273219

increased by1.06%

Lines of code

1912

increased by0.95%

Worsened metrics

Number of low quality alerts

2

increased by100%

No dependency changes