@semcore/popper - npm Package Compare versions

Comparing version 5.39.1 to 5.39.2-prerelease.0

CHANGELOG.md

@@ -5,2 +5,8 @@ # Changelog
 
+## [5.39.2] - 2024-08-02
+
+### Added
+
+- Runtime check of required label in `Popper` component with role `dialog`.
+
 ## [5.39.1] - 2024-07-30
@@ -7,0 +13,0 @@

lib/cjs/Popper.js

@@ -39,2 +39,3 @@ "use strict";
 var _hasParent = require("@semcore/utils/lib/hasParent");
+var _logger = _interopRequireDefault(require("@semcore/utils/lib/logger"));
 var _createPopper2 = _interopRequireDefault(require("./createPopper"));
@@ -46,8 +47,8 @@ var _zIndexStacking = require("@semcore/utils/lib/zIndexStacking");
 /*__reshadow-styles__:"./style/popper.shadow.css"*/
-var style = ( /*__reshadow_css_start__*/_index.sstyled.insert( /*__inner_css_start__*/".___SPopper_12gyc_gg_{outline:0;color:var(--intergalactic-text-primary, #191b23)}.___SPopper_12gyc_gg_.__keyboardFocused_12gyc_gg_:focus:after{position:absolute;display:block;content:\"\";top:0;right:0;bottom:0;left:0;box-shadow:var(--intergalactic-keyboard-focus, 0px 0px 0px 3px rgba(0, 143, 248, 0.5));pointer-events:none;border-radius:var(--intergalactic-popper-rounded, 6px)}.___SPopper_12gyc_gg_.__keyboardFocused_12gyc_gg_.__hideFocus_12gyc_gg_:focus:after{box-shadow:none}.___SFocusHint_12gyc_gg_{display:none}.___STrigger_12gyc_gg_:focus .___SFocusHint_12gyc_gg_,.___STrigger_12gyc_gg_:focus-within .___SFocusHint_12gyc_gg_{display:inline}" /*__inner_css_end__*/, "12gyc_gg_") /*__reshadow_css_end__*/, {
-  "__SPopper": "___SPopper_12gyc_gg_",
-  "_keyboardFocused": "__keyboardFocused_12gyc_gg_",
-  "_hideFocus": "__hideFocus_12gyc_gg_",
-  "__SFocusHint": "___SFocusHint_12gyc_gg_",
-  "__STrigger": "___STrigger_12gyc_gg_"
+var style = ( /*__reshadow_css_start__*/_index.sstyled.insert( /*__inner_css_start__*/".___SPopper_8352g_gg_{outline:0;color:var(--intergalactic-text-primary, #191b23)}.___SPopper_8352g_gg_.__keyboardFocused_8352g_gg_:focus:after{position:absolute;display:block;content:\"\";top:0;right:0;bottom:0;left:0;box-shadow:var(--intergalactic-keyboard-focus, 0px 0px 0px 3px rgba(0, 143, 248, 0.5));pointer-events:none;border-radius:var(--intergalactic-popper-rounded, 6px)}.___SPopper_8352g_gg_.__keyboardFocused_8352g_gg_.__hideFocus_8352g_gg_:focus:after{box-shadow:none}.___SFocusHint_8352g_gg_{display:none}.___STrigger_8352g_gg_:focus .___SFocusHint_8352g_gg_,.___STrigger_8352g_gg_:focus-within .___SFocusHint_8352g_gg_{display:inline}" /*__inner_css_end__*/, "8352g_gg_") /*__reshadow_css_end__*/, {
+  "__SPopper": "___SPopper_8352g_gg_",
+  "_keyboardFocused": "__keyboardFocused_8352g_gg_",
+  "_hideFocus": "__hideFocus_8352g_gg_",
+  "__SFocusHint": "___SFocusHint_8352g_gg_",
+  "__STrigger": "___STrigger_8352g_gg_"
 });
@@ -594,3 +595,4 @@ function isObject(obj) {
     focusMaster = _props$focusMaster === void 0 ? false : _props$focusMaster,
-    handleFocusOut = props.handleFocusOut;
+    handleFocusOut = props.handleFocusOut,
+    role = props.role;
   var ref = _react["default"].useRef(null);
@@ -635,2 +637,13 @@ var zIndex = (0, _zIndexStacking.useZIndexStacking)('z-index-popper');
   }, [animationCtx, ignorePortalsStacking]);
+  _react["default"].useEffect(function () {
+    if (role === 'dialog' && visible && process.env.NODE_ENV !== 'production') {
+      var hasTitle = function hasTitle(node) {
+        if (node.hasAttribute('aria-label')) return true;
+        if (node.hasAttribute('aria-labelledby')) return true;
+        if (node.hasAttribute('title')) return true;
+        return false;
+      };
+      _logger["default"].warn(ref.current && !hasTitle(ref.current), "'title' or 'aria-label' or 'aria-labelledby' are required props for popper with role dialog", props['data-ui-name'] || PopperPopper.displayName);
+    }
+  }, [visible, role]);
   return _ref3 = (0, _core.sstyled)(styles), /*#__PURE__*/_react["default"].createElement(_portal["default"], _ref3.cn("Portal", {
@@ -637,0 +650,0 @@ "disablePortal": disablePortal,

lib/es6/Popper.js

@@ -36,10 +36,11 @@ import _objectSpread from "@babel/runtime/helpers/objectSpread2";
 import { hasParent } from '@semcore/utils/lib/hasParent';
+import logger from '@semcore/utils/lib/logger';
 import _createPopper from './createPopper';
 /*__reshadow-styles__:"./style/popper.shadow.css"*/
-var style = ( /*__reshadow_css_start__*/_sstyled.insert( /*__inner_css_start__*/".___SPopper_12gyc_gg_{outline:0;color:var(--intergalactic-text-primary, #191b23)}.___SPopper_12gyc_gg_.__keyboardFocused_12gyc_gg_:focus:after{position:absolute;display:block;content:\"\";top:0;right:0;bottom:0;left:0;box-shadow:var(--intergalactic-keyboard-focus, 0px 0px 0px 3px rgba(0, 143, 248, 0.5));pointer-events:none;border-radius:var(--intergalactic-popper-rounded, 6px)}.___SPopper_12gyc_gg_.__keyboardFocused_12gyc_gg_.__hideFocus_12gyc_gg_:focus:after{box-shadow:none}.___SFocusHint_12gyc_gg_{display:none}.___STrigger_12gyc_gg_:focus .___SFocusHint_12gyc_gg_,.___STrigger_12gyc_gg_:focus-within .___SFocusHint_12gyc_gg_{display:inline}" /*__inner_css_end__*/, "12gyc_gg_") /*__reshadow_css_end__*/, {
-  "__SPopper": "___SPopper_12gyc_gg_",
-  "_keyboardFocused": "__keyboardFocused_12gyc_gg_",
-  "_hideFocus": "__hideFocus_12gyc_gg_",
-  "__SFocusHint": "___SFocusHint_12gyc_gg_",
-  "__STrigger": "___STrigger_12gyc_gg_"
+var style = ( /*__reshadow_css_start__*/_sstyled.insert( /*__inner_css_start__*/".___SPopper_8352g_gg_{outline:0;color:var(--intergalactic-text-primary, #191b23)}.___SPopper_8352g_gg_.__keyboardFocused_8352g_gg_:focus:after{position:absolute;display:block;content:\"\";top:0;right:0;bottom:0;left:0;box-shadow:var(--intergalactic-keyboard-focus, 0px 0px 0px 3px rgba(0, 143, 248, 0.5));pointer-events:none;border-radius:var(--intergalactic-popper-rounded, 6px)}.___SPopper_8352g_gg_.__keyboardFocused_8352g_gg_.__hideFocus_8352g_gg_:focus:after{box-shadow:none}.___SFocusHint_8352g_gg_{display:none}.___STrigger_8352g_gg_:focus .___SFocusHint_8352g_gg_,.___STrigger_8352g_gg_:focus-within .___SFocusHint_8352g_gg_{display:inline}" /*__inner_css_end__*/, "8352g_gg_") /*__reshadow_css_end__*/, {
+  "__SPopper": "___SPopper_8352g_gg_",
+  "_keyboardFocused": "__keyboardFocused_8352g_gg_",
+  "_hideFocus": "__hideFocus_8352g_gg_",
+  "__SFocusHint": "___SFocusHint_8352g_gg_",
+  "__STrigger": "___STrigger_8352g_gg_"
 });
@@ -586,3 +587,4 @@ import { useZIndexStacking, ZIndexStackingContextProvider } from '@semcore/utils/lib/zIndexStacking';
     focusMaster = _props$focusMaster === void 0 ? false : _props$focusMaster,
-    handleFocusOut = props.handleFocusOut;
+    handleFocusOut = props.handleFocusOut,
+    role = props.role;
   var ref = React.useRef(null);
@@ -627,2 +629,13 @@ var zIndex = useZIndexStacking('z-index-popper');
   }, [animationCtx, ignorePortalsStacking]);
+  React.useEffect(function () {
+    if (role === 'dialog' && visible && process.env.NODE_ENV !== 'production') {
+      var hasTitle = function hasTitle(node) {
+        if (node.hasAttribute('aria-label')) return true;
+        if (node.hasAttribute('aria-labelledby')) return true;
+        if (node.hasAttribute('title')) return true;
+        return false;
+      };
+      logger.warn(ref.current && !hasTitle(ref.current), "'title' or 'aria-label' or 'aria-labelledby' are required props for popper with role dialog", props['data-ui-name'] || PopperPopper.displayName);
+    }
+  }, [visible, role]);
   return _ref3 = sstyled(styles), /*#__PURE__*/React.createElement(Portal, _ref3.cn("Portal", {
@@ -629,0 +642,0 @@ "disablePortal": disablePortal,

package.json

 {
   "name": "@semcore/popper",
   "description": "Semrush Popper Component",
-  "version": "5.39.1",
+  "version": "5.39.2-prerelease.0",
   "main": "lib/cjs/index.js",
@@ -13,11 +13,11 @@ "module": "lib/es6/index.js",
     "@popperjs/core": "2.11.5",
-    "@semcore/animation": "2.31.1",
-    "@semcore/flex-box": "5.31.1",
-    "@semcore/neighbor-location": "4.29.1",
-    "@semcore/outside-click": "3.29.1",
-    "@semcore/portal": "3.31.1",
-    "@semcore/utils": "4.32.1"
+    "@semcore/animation": "2.31.2-prerelease.0",
+    "@semcore/flex-box": "5.31.2-prerelease.0",
+    "@semcore/neighbor-location": "4.29.2-prerelease.0",
+    "@semcore/outside-click": "3.29.2-prerelease.0",
+    "@semcore/portal": "3.31.2-prerelease.0",
+    "@semcore/utils": "4.32.2-prerelease.0"
   },
   "peerDependencies": {
-    "@semcore/core": "^2.17.5",
+    "@semcore/core": "^2.29.2-prerelease.0",
     "react": "16.8 - 18",
@@ -24,0 +24,0 @@ "react-dom": "16.8 - 18"

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

279862

increased by1.63%

Lines of code

1946

increased by1.35%

Worsened metrics

Number of low quality alerts

2

increased by100%

Number of low supply chain risk alerts

2

increased byInfinity%

Dependency changes

• + Added@semcore/animation@2.31.2-prerelease.0(transitive)

• + Added@semcore/flex-box@5.31.2-prerelease.0(transitive)

• + Added@semcore/neighbor-location@4.29.2-prerelease.0(transitive)

• + Added@semcore/outside-click@3.29.2-prerelease.0(transitive)

• + Added@semcore/portal@3.31.2-prerelease.0(transitive)

• + Added@semcore/utils@4.32.2-prerelease.0(transitive)

• - Removed@semcore/animation@2.31.1(transitive)

• - Removed@semcore/flex-box@5.31.1(transitive)

• - Removed@semcore/neighbor-location@4.29.1(transitive)

• - Removed@semcore/outside-click@3.29.1(transitive)

• - Removed@semcore/portal@3.31.1(transitive)

• - Removed@semcore/utils@4.32.1(transitive)

• Updated@semcore/animation@2.31.2-prerelease.0

• Updated@semcore/flex-box@5.31.2-prerelease.0

• Updated@semcore/neighbor-location@4.29.2-prerelease.0

• Updated@semcore/outside-click@3.29.2-prerelease.0

• Updated@semcore/portal@3.31.2-prerelease.0

• Updated@semcore/utils@4.32.2-prerelease.0