@vaadin-component-factory/vcf-nav - npm Package Compare versions

Comparing version 1.1.0 to 1.1.1

package.json

 {
   "name": "@vaadin-component-factory/vcf-nav",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "homepage": "https://github.com/vaadin/vcf-nav",
@@ -5,0 +5,0 @@ "repository": "https://github.com/vaadin/vcf-nav",

README.md

@@ -65,3 +65,3 @@ # vcf-nav
 newItems.getElement().setAttribute("slot", "suffix");
-dashboard.getElement().appendChild(newItems);
+dashboard.getElement().appendChild(newItems.getElement());
 
@@ -68,0 +68,0 @@ AppNavItem parent = new AppNavItem("Parent");

src/vcf-nav-item.ts

@@ -223,3 +223,10 @@ import { html, css, LitElement } from 'lit';
       // Absolute path or no base uri in use. No special comparison needed
-      this.active = document.location.pathname == this.path;
+      if (pathAbsolute) {
+        // Compare an absolute view path
+        this.active = document.location.pathname == this.path;
+      } else {
+        // Compare a relative view path (strip the starting slash)
+        this.active = document.location.pathname.substring(1) == this.path;
+      }
+
     }
@@ -226,0 +233,0 @@ this.toggleAttribute('child-active', document.location.pathname.startsWith(this.path));

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

26694

increased by0.94%

Lines of code

322

increased by1.9%

No dependency changes