angular-utils-pagination
Advanced tools
Comparing version 0.11.0 to 0.11.1
{ | ||
"name": "angularUtils-pagination", | ||
"version": "0.11.0", | ||
"version": "0.11.1", | ||
"homepage": "https://github.com/michaelbromley/angularUtils/tree/master/src/directives/pagination", | ||
@@ -5,0 +5,0 @@ "authors": [ |
@@ -71,5 +71,8 @@ /** | ||
var paginationId = $parse(attrs.paginationId)(scope) || attrs.paginationId || DEFAULT_ID; | ||
// (TODO: this seems sound, but I'm reverting as many bug reports followed it's introduction in 0.11.0. | ||
// Needs more investigation.) | ||
// In case rawId != paginationId we deregister using rawId for the sake of general cleanliness | ||
// before registering using paginationId | ||
paginationService.deregisterInstance(rawId); | ||
// paginationService.deregisterInstance(rawId); | ||
paginationService.registerInstance(paginationId); | ||
@@ -109,8 +112,10 @@ | ||
compiled(scope); | ||
// (TODO: Reverting this due to many bug reports in v 0.11.0. Needs investigation as the | ||
// principle is sound) | ||
// When the scope is destroyed, we make sure to remove the reference to it in paginationService | ||
// so that it can be properly garbage collected | ||
scope.$on('$destroy', function destroyDirPagination() { | ||
paginationService.deregisterInstance(paginationId); | ||
}); | ||
// scope.$on('$destroy', function destroyDirPagination() { | ||
// paginationService.deregisterInstance(paginationId); | ||
// }); | ||
}; | ||
@@ -117,0 +122,0 @@ } |
Package.describe({ | ||
name: 'angularutils:pagination', | ||
summary: 'Magical automatic pagination for anything in AngularJS', | ||
version: '0.11.0', | ||
version: '0.11.1', | ||
git: 'https://github.com/michaelbromley/angularUtils-pagination' | ||
@@ -6,0 +6,0 @@ }); |
{ | ||
"name": "angular-utils-pagination", | ||
"version": "0.11.0", | ||
"version": "0.11.1", | ||
"description": "Magical automatic pagination for anything in AngularJS", | ||
@@ -5,0 +5,0 @@ "main": "index.js", |
@@ -11,2 +11,7 @@ # angular-utils-pagination | ||
## Changelog | ||
Please see the [releases page](https://github.com/michaelbromley/angularUtils-pagination/releases) for details | ||
of each released version. | ||
## Issues | ||
@@ -13,0 +18,0 @@ |
33376
610
28