apollo-datasource-http - npm Package Compare versions

Comparing version 0.19.0 to 0.20.0

dist/src/http-data-source.d.ts

@@ -68,2 +68,3 @@ /// <reference types="node" />
     protected isResponseCacheable<TResult = unknown>(request: Request, response: Response<TResult>): boolean;
+    protected isRequestCacheable(request: Request): boolean;
     protected isRequestMemoizable(request: Request): boolean;
@@ -70,0 +71,0 @@ protected onCacheKeyCalculation(request: Request): string;

dist/src/http-data-source.js

@@ -60,4 +60,7 @@ "use strict";
     isResponseCacheable(request, response) {
-        return statusCodeCacheableByDefault.has(response.statusCode) && request.method === 'GET';
+        return statusCodeCacheableByDefault.has(response.statusCode) && this.isRequestCacheable(request);
     }
+    isRequestCacheable(request) {
+        return request.method === 'GET';
+    }
     isRequestMemoizable(request) {
@@ -206,3 +209,4 @@ return Boolean(request.memoize) && request.method === 'GET';
         const cacheKey = this.onCacheKeyCalculation(request);
-        if (request.method === 'GET') {
+        const isRequestMemoizable = this.isRequestMemoizable(request);
+        if (isRequestMemoizable) {
             if (this.memoizedResults.has(cacheKey)) {
@@ -224,3 +228,4 @@ const response = await this.memoizedResults.get(cacheKey);
         };
-        if (options.method === 'GET') {
+        const requestIsCacheable = this.isRequestCacheable(request);
+        if (requestIsCacheable) {
             if (request.requestCache) {
@@ -227,0 +232,0 @@ try {

package.json

 {
   "name": "apollo-datasource-http",
-  "version": "0.19.0",
+  "version": "0.20.0",
   "author": "Dustin Deus <[e-mail]>",
@@ -5,0 +5,0 @@ "license": "MIT",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

33927

increased by1.49%

Lines of code

342

increased by1.79%

No dependency changes