areq - npm Package Compare versions

Comparing version 0.0.3 to 0.0.4

index.js

 var EventEmitter = require('events');
 
 function Areq(emitter, areqTimeout) {
-    if (!emitter instanceof EventEmitter)
+    if (! (emitter instanceof EventEmitter))
         throw new TypeError('Input emitter should be an EventEmitter.');
@@ -12,20 +12,11 @@
 
-Areq.prototype.resolve = function (evt, value) {
-    var rec = this.getRecord(evt),
-        deferred = rec ? rec.deferred : null;
 
-    if (deferred && deferred.promise.isPending())
-        deferred.resolve(value);
-
-    this.deregister(evt);
+Areq.prototype.getRecord = function (evt) {
+    throwIfEvtNotString(evt);
+    return this._pendings[evt];
 };
 
-Areq.prototype.reject = function (evt, err) {
-    var rec = this.getRecord(evt),
-        deferred = rec ? rec.deferred : null;
-
-    if (deferred && deferred.promise.isPending())
-        deferred.reject(err);
-
-    this.deregister(evt);
+Areq.prototype.isEventPending = function (evt) {
+    throwIfEvtNotString(evt);
+    return !!this._pendings[evt];
 };
@@ -38,11 +29,11 @@
 
-    if (typeof evt !== 'string')
-        throw new TypeError('evt should be a string.');
-
     if (typeof listener !== 'function')
         throw new TypeError('listener should be a function.');
 
-    if (this.getRecord(evt)) {  // someone waiting same event
+    if (this.getRecord(evt)) {  // someone waiting same event, throw if evt is not a string
         registered = false;
     } else {
+        if (!deferred.hasOwnProperty('promise'))
+            throw new TypeError('deferred should be a deferred object of Promise.');
+
         deferred.promise.timeout(areqTimeout).fail(function(err) {
@@ -66,5 +57,2 @@ deferred.reject(err);
 Areq.prototype.deregister = function (evt) {
-    if (typeof evt !== 'string')
-        throw new TypeError('evt should be a string.');
-
     var rec = this.getRecord(evt),
@@ -87,13 +75,27 @@ emitter = this._emitter;
 
-Areq.prototype.getRecord = function (evt) {
-    return this._pendings[evt];
+Areq.prototype.resolve = function (evt, value) {
+    var rec = this.getRecord(evt),
+        deferred = rec ? rec.deferred : null;
+
+    if (deferred && deferred.promise.isPending())
+        deferred.resolve(value);
+
+    this.deregister(evt);
 };
 
-Areq.prototype.isEventPending = function (evt) {
-    return !!this._pendings[evt];
+Areq.prototype.reject = function (evt, err) {
+    var rec = this.getRecord(evt),
+        deferred = rec ? rec.deferred : null;
+
+    if (deferred && deferred.promise.isPending())
+        deferred.reject(err);
+
+    this.deregister(evt);
 };
 
-/*************************************************************************************************/
-/*** Module Exports                                                                            ***/
-/*************************************************************************************************/
+function throwIfEvtNotString (evt) {
+    if (typeof evt !== 'string')
+        throw new TypeError('evt should be a string.');
+}
+
 module.exports = Areq;

package.json

 {
   "name": "areq",
-  "version": "0.0.3",
+  "version": "0.0.4",
   "description": "An asynchronous request controller",
   "main": "index.js",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "make test-all"
   },
@@ -18,3 +18,9 @@ "repository": {
   },
-  "homepage": "https://github.com/zigbeer/areq#readme"
+  "homepage": "https://github.com/zigbeer/areq#readme",
+  "devDependencies": {
+    "chai": "^3.5.0",
+    "mocha": "^2.5.3",
+    "q": "^1.4.1"
+  },
+  "dependencies": {}
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No tests

Quality

Package does not have any tests. This is a strong signal of a poorly maintained or low quality package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

24435

increased by412.8%

Number of package files

8

increased by60%

Lines of code

359

increased by405.63%

Number of low quality alerts

1

decreased by-50%

Worsened metrics

Dev dependency count

3

increased byInfinity%

Number of medium supply chain risk alerts

1

increased byInfinity%

No dependency changes