aurumjs - npm Package Compare versions

Comparing version 0.9.37 to 0.9.38

package.json

 {
   "name": "aurumjs",
-  "version": "0.9.37",
+  "version": "0.9.38",
   "main": "prebuilt/esnext/aurumjs.js",
@@ -5,0 +5,0 @@ "type": "module",

prebuilt/esnext/aurumjs.d.ts

@@ -35,4 +35,4 @@ export * from './rendering/webcomponent.js';
 export * from './decorators/attach_notifier.js';
-export { AttributeValue, ClassType, StyleType, DataDrain, StringSource } from './utilities/common.js';
+export { AttributeValue, ClassType, StyleType, DataDrain } from './utilities/common.js';
 export { RemoteProtocol, getRemoteFunction } from './aurum_server/aurum_server_client.js';
 //# sourceMappingURL=aurumjs.d.ts.map

prebuilt/esnext/rendering/renderers/dom_adapter.js

@@ -87,5 +87,5 @@ import { handleClass, handleStyle } from '../../nodes/rendering_helpers.js';
             if (typeof child === 'function') {
-                throw new Error('Unexpected child type passed to DOM Node: function. Did you mean to use a component? To use a component use JSX syntax such as <MyComponent/> it works even with function references. <props.myReference/>');
+                throw new Error(`Unexpected child type passed to DOM Node: function. Did you mean to use a component? To use a component use JSX syntax such as <MyComponent/> it works even with function references. <props.myReference/>`);
             }
-            throw new Error(`Unexpected child type passed to DOM Node: ${children}`);
+            throw new Error(`Unexpected child type passed to DOM Node: ${children}. If this is a valid child type make sure you don't have 2 copies of Aurum loaded`);
         }
@@ -178,4 +178,4 @@ }
 function assignStringSourceToAttribute(node, data, key, cleanUp) {
-    if (typeof data === 'string') {
-        node.setAttribute(key, data);
+    if (typeof data === 'string' || typeof data === 'number') {
+        node.setAttribute(key, data.toString());
     }
@@ -188,4 +188,4 @@ else if (typeof data === 'boolean') {
     else if (data instanceof DataSource || data instanceof DuplexDataSource) {
-        if (typeof data.value === 'string') {
-            node.setAttribute(key, data.value);
+        if (typeof data.value === 'string' || typeof data.value === 'number') {
+            node.setAttribute(key, data.value.toString());
         }
@@ -192,0 +192,0 @@ else if (typeof data.value === 'boolean') {

prebuilt/esnext/utilities/common.d.ts

 import { ArrayDataSource, DataSource, MapDataSource, ReadOnlyDataSource } from '../stream/data_source.js';
 import { DuplexDataSource } from '../stream/duplex_data_source.js';
-export type AttributeValue = string | ReadOnlyDataSource<string> | ReadOnlyDataSource<boolean> | boolean;
-export type StringSource = string | ReadOnlyDataSource<string>;
+export type AttributeValue = number | string | boolean | ReadOnlyDataSource<string> | ReadOnlyDataSource<boolean> | ReadOnlyDataSource<number>;
 export type ClassType = string | ReadOnlyDataSource<string> | ReadOnlyDataSource<string[]> | Array<string | ReadOnlyDataSource<string>> | MapLike<boolean | ReadOnlyDataSource<boolean>> | MapDataSource<string, boolean> | ArrayDataSource<string>;
@@ -6,0 +5,0 @@ export type StyleType = string | ReadOnlyDataSource<string> | MapLike<string | ReadOnlyDataSource<string>> | MapDataSource<string, string>;

src/aurumjs.ts

@@ -107,3 +107,3 @@ export * from './rendering/webcomponent.js';
 
-export { AttributeValue, ClassType, StyleType, DataDrain, StringSource } from './utilities/common.js';
+export { AttributeValue, ClassType, StyleType, DataDrain } from './utilities/common.js';
 export { RemoteProtocol, getRemoteFunction } from './aurum_server/aurum_server_client.js';

src/rendering/renderers/dom_adapter.ts

@@ -7,3 +7,3 @@ import { handleClass, handleStyle } from '../../nodes/rendering_helpers.js';
 import { CancellationToken } from '../../utilities/cancellation_token.js';
-import { AttributeValue, Callback, ClassType, DataDrain, MapLike, StringSource, StyleType } from '../../utilities/common.js';
+import { AttributeValue, Callback, ClassType, DataDrain, MapLike, StyleType } from '../../utilities/common.js';
 import { AurumDecorator } from '../../utilities/aurum.js';
@@ -142,7 +142,9 @@
                 throw new Error(
-                    'Unexpected child type passed to DOM Node: function. Did you mean to use a component? To use a component use JSX syntax such as <MyComponent/> it works even with function references. <props.myReference/>'
+                    `Unexpected child type passed to DOM Node: function. Did you mean to use a component? To use a component use JSX syntax such as <MyComponent/> it works even with function references. <props.myReference/>`
                 );
             }
 
-            throw new Error(`Unexpected child type passed to DOM Node: ${children}`);
+            throw new Error(
+                `Unexpected child type passed to DOM Node: ${children}. If this is a valid child type make sure you don't have 2 copies of Aurum loaded`
+            );
         }
@@ -246,5 +248,5 @@ }
 
-function assignStringSourceToAttribute(node: HTMLElement, data: StringSource, key: string, cleanUp: CancellationToken) {
-    if (typeof data === 'string') {
-        node.setAttribute(key, data);
+function assignStringSourceToAttribute(node: HTMLElement, data: AttributeValue, key: string, cleanUp: CancellationToken) {
+    if (typeof data === 'string' || typeof data === 'number') {
+        node.setAttribute(key, data.toString());
     } else if (typeof data === 'boolean') {
@@ -255,4 +257,4 @@ if (data) {
     } else if (data instanceof DataSource || data instanceof DuplexDataSource) {
-        if (typeof data.value === 'string') {
-            node.setAttribute(key, data.value);
+        if (typeof data.value === 'string' || typeof data.value === 'number') {
+            node.setAttribute(key, data.value.toString());
         } else if (typeof data.value === 'boolean') {
@@ -259,0 +261,0 @@ if (data.value) {

src/utilities/common.ts

 import { ArrayDataSource, DataSource, MapDataSource, ReadOnlyDataSource } from '../stream/data_source.js';
 import { DuplexDataSource } from '../stream/duplex_data_source.js';
 
-export type AttributeValue = string | ReadOnlyDataSource<string> | ReadOnlyDataSource<boolean> | boolean;
-export type StringSource = string | ReadOnlyDataSource<string>;
+export type AttributeValue = number | string | boolean | ReadOnlyDataSource<string> | ReadOnlyDataSource<boolean> | ReadOnlyDataSource<number>;
 export type ClassType =
@@ -7,0 +6,0 @@ | string

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1963507

increased by0.02%

Worsened metrics

Number of downloads

4

decreased by-20%

No dependency changes