bpmnlint - npm Package Compare versions

Comparing version 10.2.2 to 10.2.3

package.json

 {
   "name": "bpmnlint",
   "description": "Validate your BPMN diagrams based on configurable lint rules",
-  "version": "10.2.2",
+  "version": "10.2.3",
   "main": "lib/index.js",
@@ -6,0 +6,0 @@ "keywords": [

rules/no-overlapping-elements.js

@@ -63,15 +63,20 @@ const {
 
-  // check child elements for overlap
   const flowElements = node.flowElements || [];
-  checkElementsArray(flowElements, elementsToReport, diObjects);
 
-  // check child elements outside parent boundary
-  // TODO: Skipped DataSoreReferences for now
-  flowElements.filter(element => !is(element, 'bpmn:DataStoreReference')).forEach(element => {
+  const flowElementsWithDi = flowElements.filter(element => diObjects.has(element));
 
-    if (!diObjects.has(element)) {
-      return;
-    }
+  // check child elements for overlap
+  checkElementsArray(flowElementsWithDi, elementsToReport, diObjects);
 
-    if (isOutsideParentBoundary(diObjects.get(element).bounds, parentDi.bounds)) {
+  // check child elements outside parent boundary
+  //
+  //   * data objects do not have a visual representation
+  //   * for historical reasons data store references may be
+  //     outside of parent boundaries
+  //
+  flowElementsWithDi.forEach(element => {
+    if (
+      !is(element, 'bpmn:DataStoreReference') &&
+      isOutsideParentBoundary(diObjects.get(element).bounds, parentDi.bounds)
+    ) {
       elementsOutsideToReport.add(element);
@@ -81,3 +86,3 @@ }
 
-  // check subprocesses
+  // recurse into subprocesses
   const subProcesses = flowElements.filter(element => is(element, 'bpmn:SubProcess'));
@@ -98,9 +103,6 @@ subProcesses.forEach(subProcess => {
     const element = elements[i];
+
     for (let j = i + 1; j < elements.length; j++) {
       const element2 = elements[j];
 
-      if (!diObjects.has(element) || !diObjects.has(element2)) {
-        continue;
-      }
-
       // ignore if Boundary events overlap their host
@@ -107,0 +109,0 @@ // but still check if they overlap other elements

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

67146

increased by0.12%

Lines of code

2095

increased by0.1%

No dependency changes