chrome-fs - npm Package Compare versions

Comparing version 7.0.0 to 8.0.0

chrome.js

@@ -1005,12 +1005,11 @@ var util = require('util')
 
-  if (this.pos === this.fd.size) {
+  if (this.pos > this.fd.size) {
     return this.push(null)
   }
-  this.pos = this.fd.size
+
   if (this.fd.size === 0) {
     return this.push(null)
   }
-
   var self = this
-  // Sketchy implementation that pushes the whole file to the the stream
+  // Sketchy implementation that pushes the whole file to the stream
   // But maybe fd has a size that we can iterate to?
@@ -1030,3 +1029,3 @@ var onread = function (err, length, data) {
   if (this.end === 0) {
-    this.end = this.fd.size
+    this.end = this._readableState.highWaterMark
   } else {
@@ -1036,3 +1035,5 @@ this.end = this.end - this.start + 1
 
-  exports.read(this.fd, new Buffer(this.fd.size), this.start, this.end, 0, onread)
+  // exports.read(this.fd, new Buffer(this.fd.size), this.start, this.end, 0, onread)
+  exports.read(this.fd, new Buffer(this.fd.size), this.start, this.end, this.pos, onread)
+  this.pos += this._readableState.highWaterMark
 // this.once('finish', this.close)
@@ -1039,0 +1040,0 @@ }

package.json

 {
   "name": "chrome-fs",
-  "version": "7.0.0",
+  "version": "8.0.0",
   "description": "Use the Node `fs` API in Chrome Apps",
@@ -5,0 +5,0 @@ "main": "main.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

42886

increased by0.31%

Lines of code

1128

increased by0.09%

No dependency changes