cqrs-eventdenormalizer - npm Package Compare versions

Comparing version 1.12.3 to 1.12.4

lib/definitions/viewBuilder.js

@@ -96,3 +96,3 @@ 'use strict';
 
-  this.defineShouldHandle(function (evt, vm) {
+  this.defineShouldHandle(function (evt) {
     return true;
@@ -316,3 +316,8 @@ });
 
-    self.shouldHandle(evt, vm, function (err, doHandle) {
+    var shouldBeHandled = function (cb) {
+      if (self.shouldHandleRequestsOnlyEvent) return cb(null, true);
+      self.shouldHandle(evt, vm, cb);
+    };
+
+    shouldBeHandled(function (err, doHandle) {
       if (err) {
@@ -509,28 +514,23 @@ return callback(err);
 
-    if (self.executeDenormFnForEach) {
-      return self.denormalizeForEach(evt, callback);
-    }
+    function denorm() {
+      if (self.executeDenormFnForEach) {
+        return self.denormalizeForEach(evt, callback);
+      }
 
-    if (self.query) {
-      return self.handleQuery(evt, self.query, callback);
-    }
+      if (self.query) {
+        return self.handleQuery(evt, self.query, callback);
+      }
 
-    if (!self.query && self.getQueryForThisViewBuilder) {
-      self.getQueryForThisViewBuilder(evt, function (err, query) {
-        if (err) {
-          debug(err);
-          return callback(err);
-        }
-        self.handleQuery(evt, query, callback);
-      });
-      return;
-    }
-
-    self.extractId(evt, function (err, id) {
-      if (err) {
-        debug(err);
-        return callback(err);
+      if (!self.query && self.getQueryForThisViewBuilder) {
+        self.getQueryForThisViewBuilder(evt, function (err, query) {
+          if (err) {
+            debug(err);
+            return callback(err);
+          }
+          self.handleQuery(evt, query, callback);
+        });
+        return;
       }
 
-      self.loadViewModel(id, function (err, vm) {
+      self.extractId(evt, function (err, id) {
         if (err) {
@@ -541,7 +541,3 @@ debug(err);
 
-        if (vm.actionOnCommit === 'create' && !self.autoCreate) {
-          return callback(null, []);
-        }
-
-        self.handleOne(vm, evt, function (err, notification) {
+        self.loadViewModel(id, function (err, vm) {
           if (err) {
@@ -552,11 +548,38 @@ debug(err);
 
-          var notis = [];
-          if (notification) {
-            notis.push(notification);
+          if (vm.actionOnCommit === 'create' && !self.autoCreate) {
+            return callback(null, []);
           }
 
-          callback(null, notis);
+          self.handleOne(vm, evt, function (err, notification) {
+            if (err) {
+              debug(err);
+              return callback(err);
+            }
+
+            var notis = [];
+            if (notification) {
+              notis.push(notification);
+            }
+
+            callback(null, notis);
+          });
         });
       });
-    });
+    }
+
+    if (this.shouldHandleRequestsOnlyEvent) {
+      this.shouldHandle(evt, null, function (err, doHandle) {
+        if (err) {
+          return callback(err);
+        }
+
+        if (!doHandle) {
+          return callback(null, []);
+        }
+
+        denorm();
+      });
+    } else {
+      denorm();
+    }
   },
@@ -664,2 +687,4 @@
 
+    this.shouldHandleRequestsOnlyEvent = fn.length === 1;
+
     if (fn.length === 3) {
@@ -666,0 +691,0 @@ this.shouldHandle = fn;

package.json

 {
   "author": "adrai",
   "name": "cqrs-eventdenormalizer",
-  "version": "1.12.3",
+  "version": "1.12.4",
   "private": false,
@@ -31,3 +31,3 @@ "main": "index.js",
     "expect.js": ">= 0.1.2",
-    "mocha": ">= 1.0.1",
+    "mocha": "3.x.x",
     "mongodb": ">= 0.0.1",
@@ -34,0 +34,0 @@ "redis": ">= 0.10.1",

releasenotes.md

@@ -0,1 +1,4 @@
+## [v1.12.4](https://github.com/adrai/node-cqrs-eventdenormalizer/compare/v1.12.3...v1.12.4)
+- [optimization] skip to load vm if viewbuilder has not requested it via shouldHandle function
+
 ## [v1.12.3](https://github.com/adrai/node-cqrs-eventdenormalizer/compare/v1.12.2...v1.12.3)
@@ -2,0 +5,0 @@ - update viewmodel

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

196726

increased by0.41%

Lines of code

4556

increased by0.44%

No dependency changes