defekt - npm Package Compare versions

Comparing version 7.1.1 to 7.1.2

build/lib/CustomError.d.ts

@@ -1,7 +0,12 @@
-interface CustomError<TErrorName extends string = string> extends Error {
+declare class CustomError<TErrorName extends string = string> extends Error {
     code: TErrorName;
-    message: string;
     cause?: unknown;
     data?: any;
+    constructor({ code, message, cause, data }: {
+        code: TErrorName;
+        message: string;
+        cause?: unknown;
+        data?: any;
+    });
 }
-export type { CustomError };
+export { CustomError };

build/lib/CustomError.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.CustomError = void 0;
+class CustomError extends Error {
+    constructor({ code, message, cause, data }) {
+        super(message);
+        this.code = code;
+        this.cause = cause;
+        this.data = data;
+    }
+}
+exports.CustomError = CustomError;

build/lib/defekt.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.defekt = void 0;
+const CustomError_1 = require("./CustomError");
 const formatErrorMessage_1 = require("./formatErrorMessage");
 const defekt = function ({ code, defaultMessage }) {
     var _a;
-    return _a = class extends Error {
+    return _a = class extends CustomError_1.CustomError {
             constructor(messageOrMetadata = {}) {
                 var _a, _b;
-                super(typeof messageOrMetadata === 'string' ?
-                    messageOrMetadata :
-                    (_b = (_a = messageOrMetadata.message) !== null && _a !== void 0 ? _a : defaultMessage) !== null && _b !== void 0 ? _b : `${formatErrorMessage_1.formatErrorMessage({ code })}`);
-                this.code = code;
-                if (typeof messageOrMetadata !== 'string') {
-                    this.cause = messageOrMetadata.cause;
-                    this.data = messageOrMetadata.data;
-                }
+                super({
+                    code,
+                    message: typeof messageOrMetadata === 'string' ?
+                        messageOrMetadata :
+                        (_b = (_a = messageOrMetadata.message) !== null && _a !== void 0 ? _a : defaultMessage) !== null && _b !== void 0 ? _b : `${formatErrorMessage_1.formatErrorMessage({ code })}`,
+                    cause: typeof messageOrMetadata === 'string' ? undefined : messageOrMetadata.cause,
+                    data: typeof messageOrMetadata === 'string' ? undefined : messageOrMetadata.data
+                });
             }
@@ -19,0 +20,0 @@ },

build/lib/index.d.ts

@@ -8,2 +8,3 @@ import { CustomError } from './CustomError';
 import { error, Result, value } from './Result';
-export { CustomError, defekt, error, ErrorConstructor, isCustomError, isError, isResult, Result, value };
+export { CustomError, defekt, error, isCustomError, isError, isResult, value };
+export type { ErrorConstructor, Result };

build/lib/index.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.value = exports.isResult = exports.isError = exports.isCustomError = exports.error = exports.defekt = void 0;
+exports.value = exports.isResult = exports.isError = exports.isCustomError = exports.error = exports.defekt = exports.CustomError = void 0;
+const CustomError_1 = require("./CustomError");
+Object.defineProperty(exports, "CustomError", { enumerable: true, get: function () { return CustomError_1.CustomError; } });
 const defekt_1 = require("./defekt");
@@ -5,0 +7,0 @@ Object.defineProperty(exports, "defekt", { enumerable: true, get: function () { return defekt_1.defekt; } });

build/lib/isCustomError.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.isCustomError = void 0;
+const CustomError_1 = require("./CustomError");
 const isError_1 = require("./isError");
 const isCustomError = function (ex, errorType) {
     return (isError_1.isError(ex) &&
+        ex instanceof CustomError_1.CustomError &&
         (errorType === undefined || (ex.code === errorType.code)));
 };
 exports.isCustomError = isCustomError;

build/lib/isError.js

@@ -5,6 +5,4 @@ "use strict";
 const isError = function (ex) {
-    return (typeof ex === 'object' && ex !== null &&
-        'message' in ex && typeof ex.message === 'string' &&
-        'name' in ex && typeof ex.name === 'string');
+    return typeof ex === 'object' && ex instanceof Error;
 };
 exports.isError = isError;

CHANGELOG.md

@@ -0,1 +1,8 @@
+## [7.1.2](https://github.com/thenativeweb/defekt/compare/7.1.1...7.1.2) (2021-05-18)
+
+
+### Bug Fixes
+
+* IsCustomError now works as intended; IsError is now simpler. ([#309](https://github.com/thenativeweb/defekt/issues/309)) ([db33b8b](https://github.com/thenativeweb/defekt/commit/db33b8bd68e93c1bf1b3af6e93f2f38ece8ce32f))
+
 ## [7.1.1](https://github.com/thenativeweb/defekt/compare/7.1.0...7.1.1) (2021-05-10)
@@ -2,0 +9,0 @@

lib/CustomError.ts

@@ -1,10 +0,24 @@
-interface CustomError<TErrorName extends string = string> extends Error {
-  code: TErrorName;
-  message: string;
-  cause?: unknown;
-  data?: any;
+class CustomError<TErrorName extends string = string> extends Error {
+  public code: TErrorName;
+
+  public cause?: unknown;
+
+  public data?: any;
+
+  public constructor ({ code, message, cause, data }: {
+    code: TErrorName;
+    message: string;
+    cause?: unknown;
+    data?: any;
+  }) {
+    super(message);
+
+    this.code = code;
+    this.cause = cause;
+    this.data = data;
+  }
 }
 
-export type {
+export {
   CustomError
 };

lib/defekt.ts

@@ -12,11 +12,5 @@ import { CustomError } from './CustomError';
 }): ErrorConstructor<TErrorCode> {
-  return class extends Error implements CustomError<TErrorCode> {
+  return class extends CustomError<TErrorCode> {
     public static code: TErrorCode = code;
 
-    public code: TErrorCode = code;
-
-    public cause?: unknown;
-
-    public data?: any;
-
     public constructor (
@@ -29,12 +23,10 @@ messageOrMetadata: string | {
     ) {
-      super(
-        typeof messageOrMetadata === 'string' ?
+      super({
+        code,
+        message: typeof messageOrMetadata === 'string' ?
           messageOrMetadata :
-          messageOrMetadata.message ?? defaultMessage ?? `${formatErrorMessage({ code })}`
-      );
-
-      if (typeof messageOrMetadata !== 'string') {
-        this.cause = messageOrMetadata.cause;
-        this.data = messageOrMetadata.data;
-      }
+          messageOrMetadata.message ?? defaultMessage ?? `${formatErrorMessage({ code })}`,
+        cause: typeof messageOrMetadata === 'string' ? undefined : messageOrMetadata.cause,
+        data: typeof messageOrMetadata === 'string' ? undefined : messageOrMetadata.data
+      });
     }
@@ -41,0 +33,0 @@ };

lib/index.ts

@@ -13,8 +13,11 @@ import { CustomError } from './CustomError';
   error,
-  ErrorConstructor,
   isCustomError,
   isError,
   isResult,
-  Result,
   value
 };
+
+export type {
+  ErrorConstructor,
+  Result
+};

lib/isCustomError.ts

@@ -11,2 +11,3 @@ import { CustomError } from './CustomError';
     isError(ex) &&
+      ex instanceof CustomError &&
       (errorType === undefined || ((ex as any).code === errorType.code))
@@ -13,0 +14,0 @@ );

lib/isError.ts

 const isError = function (ex: any): ex is Error {
-  return (
-    typeof ex === 'object' && ex !== null &&
-    'message' in ex && typeof ex.message === 'string' &&
-    'name' in ex && typeof ex.name === 'string'
-  );
+  return typeof ex === 'object' && ex instanceof Error;
 };
 
 export { isError };

package.json

 {
   "name": "defekt",
-  "version": "7.1.1",
+  "version": "7.1.2",
   "description": "defekt is custom errors made simple.",
@@ -35,4 +35,4 @@ "contributors": [
   "devDependencies": {
-    "assertthat": "6.0.0",
-    "roboter": "11.6.40",
+    "assertthat": "6.0.1",
+    "roboter": "11.6.42",
     "semantic-release-configuration": "2.0.0"
@@ -39,0 +39,0 @@ },

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

31976

increased by3.81%

Lines of code

444

increased by5.71%

No dependency changes