devtools - npm Package Compare versions

Comparing version 6.4.1 to 6.4.4

build/commands/elementClear.js

@@ -17,3 +17,3 @@ "use strict";
 }) {
-  const elementHandle = this.elementStore.get(elementId);
+  const elementHandle = await this.elementStore.get(elementId);
 
@@ -20,0 +20,0 @@ if (!elementHandle) {

build/commands/elementClick.js

@@ -24,3 +24,3 @@ "use strict";
   const page = this.getPageHandle();
-  const elementHandle = this.elementStore.get(elementId);
+  const elementHandle = await this.elementStore.get(elementId);
 
@@ -27,0 +27,0 @@ if (!elementHandle) {

build/commands/elementSendKeys.js

@@ -18,3 +18,3 @@ "use strict";
 }) {
-  const elementHandle = this.elementStore.get(elementId);
+  const elementHandle = await this.elementStore.get(elementId);
 
@@ -21,0 +21,0 @@ if (!elementHandle) {

build/commands/executeAsyncScript.js

@@ -32,4 +32,4 @@ "use strict";
 
-  const result = await page.$eval('html', _executeAsyncScript.default, script, scriptTimeout, _constants.SERIALIZE_PROPERTY, _constants.SERIALIZE_FLAG, ..._utils.transformExecuteArgs.call(this, args));
+  const result = await page.$eval('html', _executeAsyncScript.default, script, scriptTimeout, _constants.SERIALIZE_PROPERTY, _constants.SERIALIZE_FLAG, ...(await _utils.transformExecuteArgs.call(this, args)));
   return _utils.transformExecuteResult.call(this, page, result);
 }

build/commands/executeScript.js

@@ -32,3 +32,3 @@ "use strict";
 
-  const executePromise = page.$eval('html', _executeScript.default, script, _constants.SERIALIZE_PROPERTY, _constants.SERIALIZE_FLAG, ..._utils.transformExecuteArgs.call(this, args));
+  const executePromise = page.$eval('html', _executeScript.default, script, _constants.SERIALIZE_PROPERTY, _constants.SERIALIZE_FLAG, ...(await _utils.transformExecuteArgs.call(this, args)));
   let executeTimeout;
@@ -35,0 +35,0 @@ const timeoutPromise = new Promise((_, reject) => {

build/commands/findElementFromElement.js

@@ -21,3 +21,3 @@ "use strict";
 
-  const elementHandle = this.elementStore.get(elementId);
+  const elementHandle = await this.elementStore.get(elementId);
 
@@ -24,0 +24,0 @@ if (!elementHandle) {

build/commands/findElementsFromElement.js

@@ -21,3 +21,3 @@ "use strict";
 
-  const elementHandle = this.elementStore.get(elementId);
+  const elementHandle = await this.elementStore.get(elementId);
 
@@ -24,0 +24,0 @@ if (!elementHandle) {

build/commands/getElementAttribute.js

@@ -18,3 +18,3 @@ "use strict";
 }) {
-  const elementHandle = this.elementStore.get(elementId);
+  const elementHandle = await this.elementStore.get(elementId);
 
@@ -21,0 +21,0 @@ if (!elementHandle) {

build/commands/getElementCSSValue.js

@@ -18,3 +18,3 @@ "use strict";
 }) {
-  const elementHandle = this.elementStore.get(elementId);
+  const elementHandle = await this.elementStore.get(elementId);
 
@@ -21,0 +21,0 @@ if (!elementHandle) {

build/commands/getElementProperty.js

@@ -14,3 +14,3 @@ "use strict";
 }) {
-  const elementHandle = this.elementStore.get(elementId);
+  const elementHandle = await this.elementStore.get(elementId);
 
@@ -17,0 +17,0 @@ if (!elementHandle) {

build/commands/getElementRect.js

@@ -14,6 +14,6 @@ "use strict";
 
-function getElementRect({
+async function getElementRect({
   elementId
 }) {
-  const elementHandle = this.elementStore.get(elementId);
+  const elementHandle = await this.elementStore.get(elementId);
 
@@ -20,0 +20,0 @@ if (!elementHandle) {

build/commands/getElementTagName.js

@@ -17,3 +17,3 @@ "use strict";
 }) {
-  const elementHandle = this.elementStore.get(elementId);
+  const elementHandle = await this.elementStore.get(elementId);
 
@@ -20,0 +20,0 @@ if (!elementHandle) {

build/commands/getElementText.js

@@ -14,6 +14,6 @@ "use strict";
 
-function getElementText({
+async function getElementText({
   elementId
 }) {
-  const elementHandle = this.elementStore.get(elementId);
+  const elementHandle = await this.elementStore.get(elementId);
 
@@ -20,0 +20,0 @@ if (!elementHandle) {

build/commands/switchToFrame.js

@@ -29,3 +29,3 @@ "use strict";
   if (typeof id[_constants.ELEMENT_KEY] === 'string') {
-    const elementHandle = this.elementStore.get(id[_constants.ELEMENT_KEY]);
+    const elementHandle = await this.elementStore.get(id[_constants.ELEMENT_KEY]);
 
@@ -32,0 +32,0 @@ if (!elementHandle) {

build/commands/takeElementScreenshot.js

@@ -13,3 +13,3 @@ "use strict";
 }) {
-  const elementHandle = this.elementStore.get(elementId);
+  const elementHandle = await this.elementStore.get(elementId);
 
@@ -16,0 +16,0 @@ if (!elementHandle) {

build/elementstore.js

@@ -20,4 +20,13 @@ "use strict";
 
-  get(index) {
-    return this.elementMap.get(index);
+  async get(index) {
+    const elementHandle = this.elementMap.get(index);
+
+    if (!elementHandle) {
+      return elementHandle;
+    }
+
+    const isElementAttachedToDOM = await elementHandle.evaluate(el => {
+      return el.isConnected;
+    });
+    return isElementAttachedToDOM ? elementHandle : undefined;
   }
@@ -24,0 +33,0 @@

build/utils.js

@@ -154,6 +154,6 @@ "use strict";
 
-function transformExecuteArgs(args = []) {
-  return args.map(arg => {
+async function transformExecuteArgs(args = []) {
+  return Promise.all(args.map(async arg => {
     if (arg[_constants.ELEMENT_KEY]) {
-      const elementHandle = this.elementStore.get(arg[_constants.ELEMENT_KEY]);
+      const elementHandle = await this.elementStore.get(arg[_constants.ELEMENT_KEY]);
 
@@ -168,3 +168,3 @@ if (!elementHandle) {
     return arg;
-  });
+  }));
 }
@@ -171,0 +171,0 @@

devtools.d.ts

@@ -39,3 +39,3 @@ /// <reference types="node"/>
         switchToWindow(handle: string): void;
-        createWindow(type: string): object;
+        createWindow(type: 'tab' | 'window'): object;
         getWindowHandles(): string[];
@@ -42,0 +42,0 @@ switchToFrame(id: (number|object|null)): void;

package.json

 {
   "name": "devtools",
-  "version": "6.4.1",
+  "version": "6.4.4",
   "description": "A Chrome DevTools protocol binding that maps WebDriver commands into Chrome DevTools commands using Puppeteer",
@@ -45,3 +45,3 @@ "author": "Christian Bromann <[e-mail]>",
   },
-  "gitHead": "ad465d6e35571f4c2e7d9e1667468f2162ba9a67"
+  "gitHead": "5a9f3934437b81cf89d94cfe97af435d0e3291ed"
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

85785

increased by0.47%

Lines of code

2076

increased by0.34%

No dependency changes