ecsy-babylon - npm Package Compare versions

Comparing version 0.1.9 to 0.1.10

dist/index.cjs.js

@@ -279,3 +279,3 @@ 'use strict';
         this.reflectionColor.set(1, 1, 1);
-        this.emissiveColor.set(1, 1, 1);
+        this.emissiveColor.set(0, 0, 0);
         this.microSurface = 1.0;
@@ -948,6 +948,3 @@ this.useLightmapAsShadowmap = false;
         assert('Failed to add Mesh Component. No valid Mesh found.', !!(meshComponent === null || meshComponent === void 0 ? void 0 : meshComponent.value));
-        // We're using a clone here because we cannot reliably undo the internal transformations that happen when
-        // parenting/un-parenting a mesh.
         const mesh = meshComponent.value;
-        // TODO: remove cloning?
         detachFromScene(mesh);
@@ -979,2 +976,3 @@ const transformNodeComponent = entity.getComponent(TransformNode);
         assert('No removed Mesh Component found. Make sure this system is registered at the correct time.', !!(meshComponent === null || meshComponent === void 0 ? void 0 : meshComponent.value));
+        const mesh = meshComponent.value;
         if (entity.hasComponent(Material) || entity.hasRemovedComponent(Material)) {
@@ -984,9 +982,11 @@ // unset the material so it is not also disposed of here
         }
-        this.removeMesh(meshComponent.value);
+        const isUsed = this.queries.meshes.results.some((e) => e !== entity && e.getComponent(MeshComponent).value === mesh);
+        if (!isUsed) {
+            this.removeMesh(meshComponent.value);
+        }
         meshComponent.value = null;
     }
     removeMesh(mesh) {
-        var _a;
-        (_a = this.core) === null || _a === void 0 ? void 0 : _a.scene.removeMesh(mesh, false);
-        // we work with a clone so we must always dispose
+        assert('MeshSystem needs BabylonCoreComponent', this.core);
+        this.core.scene.removeMesh(mesh, false);
         mesh.dispose(true, false);
@@ -993,0 +993,0 @@ }

dist/src/components/pbr-material.js

@@ -90,3 +90,3 @@ import { Component } from 'ecsy';
         this.reflectionColor.set(1, 1, 1);
-        this.emissiveColor.set(1, 1, 1);
+        this.emissiveColor.set(0, 0, 0);
         this.microSurface = 1.0;
@@ -93,0 +93,0 @@ this.useLightmapAsShadowmap = false;

dist/src/systems/mesh.js

@@ -34,6 +34,3 @@ var __rest = (this && this.__rest) || function (s, e) {
         assert('Failed to add Mesh Component. No valid Mesh found.', !!(meshComponent === null || meshComponent === void 0 ? void 0 : meshComponent.value));
-        // We're using a clone here because we cannot reliably undo the internal transformations that happen when
-        // parenting/un-parenting a mesh.
         const mesh = meshComponent.value;
-        // TODO: remove cloning?
         detachFromScene(mesh);
@@ -65,2 +62,3 @@ const transformNodeComponent = entity.getComponent(TransformNode);
         assert('No removed Mesh Component found. Make sure this system is registered at the correct time.', !!(meshComponent === null || meshComponent === void 0 ? void 0 : meshComponent.value));
+        const mesh = meshComponent.value;
         if (entity.hasComponent(Material) || entity.hasRemovedComponent(Material)) {
@@ -70,9 +68,11 @@ // unset the material so it is not also disposed of here
         }
-        this.removeMesh(meshComponent.value);
+        const isUsed = this.queries.meshes.results.some((e) => e !== entity && e.getComponent(Mesh).value === mesh);
+        if (!isUsed) {
+            this.removeMesh(meshComponent.value);
+        }
         meshComponent.value = null;
     }
     removeMesh(mesh) {
-        var _a;
-        (_a = this.core) === null || _a === void 0 ? void 0 : _a.scene.removeMesh(mesh, false);
-        // we work with a clone so we must always dispose
+        assert('MeshSystem needs BabylonCoreComponent', this.core);
+        this.core.scene.removeMesh(mesh, false);
         mesh.dispose(true, false);
@@ -79,0 +79,0 @@ }

package.json

 {
   "name": "ecsy-babylon",
-  "version": "0.1.9",
+  "version": "0.1.10",
   "description": "",
   "keywords": [],
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/kaliber5/ecsy-babylon"
+  },
+  "license": "MIT",
+  "author": "Simon Ihmig <[e-mail]>",
+  "sideEffects": false,
   "main": "dist/index.cjs.js",
@@ -12,11 +19,2 @@ "module": "dist/src/index.js",
   ],
-  "author": "Simon Ihmig <[e-mail]>",
-  "repository": {
-    "type": "git",
-    "url": "https://github.com/kaliber5/ecsy-babylon"
-  },
-  "license": "MIT",
-  "engines": {
-    "node": ">=10"
-  },
   "scripts": {
@@ -26,16 +24,19 @@ "prebuild": "rimraf dist",
     "docs": "typedoc --out docs --target es6 --theme minimal --mode file src",
-    "start": "rollup -c rollup.config.js -w",
     "lint": "yarn lint:ts && yarn lint:eslint",
+    "lint:eslint": "eslint . --ext .js,.ts",
     "lint:ts": "tsc --noEmit",
-    "lint:eslint": "eslint . --ext .js,.ts",
+    "precommit": "lint-staged",
+    "prepublishOnly": "yarn build",
+    "postpublish": "rimraf dist",
+    "report-coverage": "cat ./coverage/lcov.info | coveralls",
+    "start": "rollup -c rollup.config.js -w",
     "test": "jest",
-    "test:watch": "jest --coverage --watch",
     "test:prod": "yarn run lint && yarn run test -- --no-cache",
-    "report-coverage": "cat ./coverage/lcov.info | coveralls",
-    "commit": "git-cz",
-    "semantic-release": "semantic-release",
-    "precommit": "lint-staged",
-    "prepublishOnly": "yarn build",
-    "postpublish": "rimraf dist"
+    "test:watch": "jest --coverage --watch"
   },
+  "husky": {
+    "hooks": {
+      "pre-commit": "lint-staged"
+    }
+  },
   "lint-staged": {
@@ -46,57 +47,37 @@ "{src,test}/**/*.ts": [
   },
-  "config": {
-    "commitizen": {
-      "path": "node_modules/cz-conventional-changelog"
-    }
-  },
   "prettier": {
+    "arrowParens": "always",
+    "printWidth": 120,
     "semi": true,
     "singleQuote": true,
-    "printWidth": 120,
-    "trailingComma": "es5",
-    "arrowParens": "always"
+    "trailingComma": "es5"
   },
-  "commitlint": {
-    "extends": [
-      "@commitlint/config-conventional"
-    ]
-  },
-  "husky": {
-    "hooks": {
-      "pre-commit": "lint-staged",
-      "commit-msg": "commitlint -E HUSKY_GIT_PARAMS"
-    }
-  },
   "dependencies": {
     "@babylonjs/core": "^4.1.0",
     "@babylonjs/materials": "^4.1.0",
-    "ecsy": "^0.2.3"
+    "ecsy": "^0.2.6"
   },
   "devDependencies": {
-    "@babel/core": "^7.9.6",
-    "@babel/preset-env": "^7.9.6",
-    "@commitlint/cli": "^8.3.5",
-    "@commitlint/config-conventional": "^8.3.4",
-    "@rollup/plugin-node-resolve": "^7.1.3",
-    "@rollup/plugin-typescript": "^4.1.1",
-    "@types/jest": "^25.2.2",
+    "@babel/core": "^7.11.1",
+    "@babel/preset-env": "^7.11.0",
+    "@rollup/plugin-node-resolve": "^9.0.0",
+    "@rollup/plugin-typescript": "^5.0.2",
+    "@types/jest": "^26.0.10",
     "@types/lodash-es": "^4.17.3",
-    "@types/node": "^13.13.4",
+    "@types/node": "^14.6.0",
     "@types/rollup-plugin-sourcemaps": "^0.4.2",
-    "@typescript-eslint/eslint-plugin": "^2.29.0",
-    "@typescript-eslint/parser": "^2.33.0",
-    "babel-jest": "^25.1.0",
+    "@typescript-eslint/eslint-plugin": "^2.34.0",
+    "@typescript-eslint/parser": "^2.34.0",
+    "babel-jest": "^26.1.0",
     "colors": "^1.3.2",
-    "commitizen": "^4.1.2",
-    "coveralls": "^3.0.11",
+    "coveralls": "^3.1.0",
     "cross-env": "^7.0.2",
-    "cz-conventional-changelog": "^3.2.0",
     "eslint": "^6.8.0",
     "eslint-config-prettier": "^6.11.0",
     "eslint-config-standard": "^14.1.1",
-    "eslint-import-resolver-typescript": "^2.0.0",
-    "eslint-plugin-import": "^2.20.2",
-    "eslint-plugin-jest": "^23.10.0",
+    "eslint-import-resolver-typescript": "^2.2.1",
+    "eslint-plugin-import": "^2.22.0",
+    "eslint-plugin-jest": "^23.20.0",
     "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-prettier": "^3.1.2",
+    "eslint-plugin-prettier": "^3.1.4",
     "eslint-plugin-promise": "^4.2.1",
@@ -106,20 +87,41 @@ "eslint-plugin-standard": "^4.0.1",
     "jest": "^24.9.0",
-    "jest-config": "^26.0.1",
+    "jest-config": "^26.4.0",
     "jest-extended": "^0.11.5",
-    "lint-staged": "^10.1.6",
+    "lint-staged": "^10.2.11",
     "prettier": "^2.0.5",
-    "rollup": "^2.10.2",
+    "release-it": "^13.6.5",
+    "release-it-lerna-changelog": "^2.3.0",
+    "rollup": "^2.26.3",
     "rollup-plugin-commonjs": "^10.1.0",
     "rollup-plugin-sourcemaps": "^0.6.2",
-    "semantic-release": "^17.0.7",
     "ts-jest": "^24.2.0",
-    "ts-node": "^8.10.1",
-    "typedoc": "^0.17.4",
-    "typescript": "^3.8.2"
+    "ts-node": "^8.10.2",
+    "typedoc": "^0.18.0",
+    "typescript": "^3.9.7"
   },
+  "engines": {
+    "node": ">=10"
+  },
+  "publishConfig": {
+    "registry": "https://registry.npmjs.org"
+  },
+  "release-it": {
+    "plugins": {
+      "release-it-lerna-changelog": {
+        "infile": "CHANGELOG.md",
+        "launchEditor": true
+      }
+    },
+    "git": {
+      "tagName": "v${version}"
+    },
+    "github": {
+      "release": true,
+      "tokenRef": "GITHUB_AUTH"
+    }
+  },
   "volta": {
-    "node": "10.18.0",
+    "node": "10.22.0",
     "yarn": "1.21.1"
-  },
-  "sideEffects": false
+  }
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

261947

increased by0.77%

Dev dependency count

39

decreased by-7.14%

Number of package files

116

increased by0.87%

Dependency changes

• Updatedecsy@^0.2.6