eslint-config-appnexus - npm Package Compare versions

Comparing version 6.0.0 to 6.1.0

base.js

@@ -25,3 +25,3 @@ module.exports = {
 		'prettier/prettier': 'error',
-		'no-use-before-define': 'error',
+		'no-use-before-define': 'off',
 		// 'arrow-parens': [2, 'always'], - Handled by Prettier
@@ -28,0 +28,0 @@ // 'arrow-spacing': [2, { before: true, after: true }], - Handled by Prettier

CHANGELOG.md

@@ -5,15 +5,32 @@ # Change Log
 
+## 6.1.0
+
+- [major] - Added `@typescript-eslint/naming-convention` with warnings
+- [patch] - Removed `@typescript-eslint/camelcase`
+- [patch] - Turned `no-use-before-define` off
+- [patch] - Turned `react/jsx-sort-props` off
+- [patch] - Turned `@typescript-eslint/no-unsafe-member-access` off
+- [patch] - Turned `@typescript-eslint/no-use-before-define` off
+- [patch] - Turned `@typescript-eslint/restrict-plus-operands` off
+- [patch] - Turned `@typescript-eslint/no-unsafe-assignment` off
+- [patch] - Replaced `interface-name-prefix` with `naming-convention`
+
 ## 6.0.0
+
 - [major] - Updated typescript to 4, the next major version
 
 ## 5.0.0
+
 - [major] - Moved temp warnings over to Errors for FE
 
 ## 4.1.0
+
 - [minor] - Adding 2 rules for FE
 
 ## 4.0.0
+
 - [patch] - Moving our warnings over to errors
 
 ## 3.1.2
+
 - [patch] - Adding new warnings prior to a major bump
@@ -20,0 +37,0 @@

frontend.js

@@ -16,3 +16,6 @@ module.exports = {
 	rules: {
-		'react/jsx-sort-props': 'error',
+		// Off
+		'react/jsx-sort-props': 'off',
+
+		// Errors
 		'react-hooks/rules-of-hooks': 'error',
@@ -54,3 +57,2 @@ 'react-hooks/exhaustive-deps': 'error',
 		// 'react/jsx-pascal-case'
-		// 'react/jsx-sort-props'
 		// 'react/jsx-space-before-closing'
@@ -57,0 +59,0 @@ // 'react/jsx-tag-spacing'

package.json

 {
   "name": "eslint-config-appnexus",
-  "version": "6.0.0",
+  "version": "6.1.0",
   "description": "AppNexus Standard Eslint Config",
@@ -38,19 +38,19 @@ "main": "index.js",
   "dependencies": {
-    "eslint-config-prettier": "^6.10.0"
+    "eslint-config-prettier": "^6.11.0"
   },
   "devDependencies": {
-    "@typescript-eslint/eslint-plugin": "^2.24.0",
-    "@typescript-eslint/parser": "^2.24.0",
+    "@typescript-eslint/eslint-plugin": "^4.1.0",
+    "@typescript-eslint/parser": "^4.1.0",
     "babel-eslint": "^10.1.0",
     "eslint": "^6.8.0",
-    "eslint-find-rules": "^3.4.0",
+    "eslint-find-rules": "^3.6.1",
     "eslint-plugin-hapi": "^4.1.0",
-    "eslint-plugin-import": "^2.20.1",
+    "eslint-plugin-import": "^2.22.0",
     "eslint-plugin-lodash": "^6.0.0",
-    "eslint-plugin-prettier": "^3.1.2",
+    "eslint-plugin-prettier": "^3.1.4",
     "eslint-plugin-promise": "^4.2.1",
-    "eslint-plugin-react": "^7.19.0",
-    "eslint-plugin-react-hooks": "^4.0.0",
-    "jest": "^25.1.0",
-    "lodash": "^4.17.15",
+    "eslint-plugin-react": "^7.20.6",
+    "eslint-plugin-react-hooks": "^4.1.0",
+    "jest": "^25.5.4",
+    "lodash": "^4.17.20",
     "pre-push": "^0.1.1",
@@ -57,0 +57,0 @@ "prettier": "^1.19.1",

typescript.js

@@ -8,3 +8,2 @@ const off = 0;
 		'./base.js', //
-		'plugin:@typescript-eslint/eslint-recommended',
 		'plugin:@typescript-eslint/recommended',
@@ -26,6 +25,27 @@ 'plugin:@typescript-eslint/recommended-requiring-type-checking',
 	rules: {
-		'no-unused-vars': off,
+		// Off
+		'react/jsx-sort-props': 'off',
+		'no-unused-vars': 'off',
 		'@typescript-eslint/explicit-function-return-type': 'off',
-		'@typescript-eslint/camelcase': 'off',
-		'@typescript-eslint/prefer-regexp-exec': off,
+		// '@typescript-eslint/camelcase': 'off',
+		'@typescript-eslint/prefer-regexp-exec': 'off',
+		'@typescript-eslint/no-explicit-any': 'off',
+		'@typescript-eslint/max-classes-per-file': 'off',
+		'@typescript-eslint/max-line-length': 'off',
+		'@typescript-eslint/no-empty-interface': 'off',
+		'@typescript-eslint/no-empty': 'off',
+		'@typescript-eslint/no-var-requires': 'off',
+		'@typescript-eslint/object-literal-sort-keys': 'off',
+		'@typescript-eslint/no-unsafe-member-access': 'off',
+		'@typescript-eslint/no-use-before-define': 'off',
+		'@typescript-eslint/restrict-plus-operands': 'off',
+		'@typescript-eslint/no-unsafe-assignment': 'off',
+		'@typescript-eslint/typedef': [
+			off,
+			{
+				default: ['property-declaration'],
+			},
+		],
+
+		// Errors
 		'@typescript-eslint/no-unused-vars': [
@@ -40,10 +60,3 @@ error,
 		],
-		'@typescript-eslint/ban-ts-ignore': error, // use eslint-disable-next-line instead
-		'@typescript-eslint/interface-name-prefix': [
-			error,
-			{
-				prefixWithI: 'always',
-			},
-		],
-		'@typescript-eslint/no-explicit-any': off,
+		'@typescript-eslint/ban-ts-comment': error, // use eslint-disable-next-line instead
 		'@typescript-eslint/array-type': [
@@ -55,31 +68,62 @@ error,
 		],
-		'@typescript-eslint/max-classes-per-file': off,
-		'@typescript-eslint/max-line-length': off,
 		'@typescript-eslint/member-ordering': error,
-		// '@typescript-eslint/no-duplicate-variable': [
-		// 	error,
-		// 	{
-		// 		default: ['check-parameters'],
-		// 	},
-		// ],
-		'@typescript-eslint/no-empty-interface': off,
-		'@typescript-eslint/no-empty': off,
-		// '@typescript-eslint/no-shadowed-variable': error,
-		// '@typescript-eslint/no-switch-case-fall-through': error,
-		'@typescript-eslint/no-var-requires': off,
-		'@typescript-eslint/object-literal-sort-keys': off,
-		// '@typescript-eslint/switch-default': error,
-		'@typescript-eslint/typedef': [
-			off,
-			{
-				default: ['property-declaration'],
+
+		//  Warnings - will become errors in next major version
+		'@typescript-eslint/no-empty-function': ['warn', { allow: ['arrowFunctions'] }],
+
+		// Off - no sure what to do with these
+		'@typescript-eslint/unbound-method': 'off',
+	},
+	overrides: [
+		{
+			files: ['*.ts', '*.tsx'],
+			rules: {
+				// Off
+				'react/prop-types': 'off',
+
+				//  Warnings - will become errors in next major version
+				'@typescript-eslint/restrict-plus-operands': 'warn',
+				'@typescript-eslint/no-unsafe-member-access': 'warn',
+				'@typescript-eslint/naming-convention': [
+					'warn',
+					{
+						selector: 'default',
+						format: ['camelCase'],
+					},
+					{
+						selector: 'variable',
+						format: ['camelCase', 'UPPER_CASE', 'PascalCase', 'snake_case'],
+						leadingUnderscore: 'allow',
+					},
+					{
+						selector: 'function',
+						format: ['camelCase', 'PascalCase'],
+						leadingUnderscore: 'allow',
+					},
+					{
+						selector: 'property',
+						format: ['camelCase', 'snake_case', 'PascalCase', 'UPPER_CASE'],
+						leadingUnderscore: 'allow',
+					},
+					{
+						selector: 'parameter',
+						format: ['camelCase', 'snake_case', 'PascalCase'],
+						leadingUnderscore: 'allow',
+					},
+					{
+						selector: 'typeLike',
+						format: ['PascalCase'],
+					},
+					{
+						selector: 'interface',
+						format: ['PascalCase'],
+						custom: {
+							regex: '^I[A-Z]',
+							match: true,
+						},
+					},
+				],
 			},
-		],
-		// '@typescript-eslint/variable-name': [
-		// 	error,
-		// 	{
-		// 		default: ['ban-keywords', 'check-format', 'allow-leading-underscore', 'allow-pascal-case'],
-		// 	},
-		// ],
-	},
+		},
+	],
 };

Fixed alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

32802

increased by5.28%

Lines of code

552

increased by8.02%

Number of medium supply chain risk alerts

0

decreased by-100%

Dependency changes

• Updatedeslint-config-prettier@^6.11.0