eslint-plugin-angular - npm Package Compare versions

Comparing version 1.6.2 to 1.6.3

package.json

 {
   "name": "eslint-plugin-angular",
-  "version": "1.6.2",
+  "version": "1.6.3",
   "description": "ESLint rules for AngularJS projects",
@@ -27,3 +27,3 @@ "main": "index.js",
     "coveralls": "^2.11.6",
-    "eslint": "^3.0.0",
+    "eslint": "^3.18.0",
     "espree": "^3.0.1",
@@ -30,0 +30,0 @@ "gulp": "^3.9.1",

rules/component-limit.js

@@ -44,14 +44,14 @@ /**
         return {
-            'angular:animation': checkLimit,
-            'angular:config': checkLimit,
-            'angular:controller': checkLimit,
-            'angular:directive': checkLimit,
-            'angular:factory': checkLimit,
-            'angular:filter': checkLimit,
-            'angular:provider': checkLimit,
-            'angular:run': checkLimit,
-            'angular:service': checkLimit,
-            'angular:component': checkLimit
+            'angular?animation': checkLimit,
+            'angular?config': checkLimit,
+            'angular?controller': checkLimit,
+            'angular?directive': checkLimit,
+            'angular?factory': checkLimit,
+            'angular?filter': checkLimit,
+            'angular?provider': checkLimit,
+            'angular?run': checkLimit,
+            'angular?service': checkLimit,
+            'angular?component': checkLimit
         };
     })
 };

rules/di-order.js

@@ -50,12 +50,12 @@ /**
         return {
-            'angular:animation': checkOrder,
-            'angular:config': checkOrder,
-            'angular:controller': checkOrder,
-            'angular:directive': checkOrder,
-            'angular:factory': checkOrder,
-            'angular:filter': checkOrder,
-            'angular:inject': checkOrder,
-            'angular:run': checkOrder,
-            'angular:service': checkOrder,
-            'angular:provider': function(callee, providerFn, $get) {
+            'angular?animation': checkOrder,
+            'angular?config': checkOrder,
+            'angular?controller': checkOrder,
+            'angular?directive': checkOrder,
+            'angular?factory': checkOrder,
+            'angular?filter': checkOrder,
+            'angular?inject': checkOrder,
+            'angular?run': checkOrder,
+            'angular?service': checkOrder,
+            'angular?provider': function(callee, providerFn, $get) {
                 checkOrder(null, providerFn);
@@ -62,0 +62,0 @@ checkOrder(null, $get);

rules/di-unused.js

@@ -57,12 +57,12 @@ /**
         return {
-            'angular:animation': reportUnusedVariables,
-            'angular:config': reportUnusedVariables,
-            'angular:controller': reportUnusedVariables,
-            'angular:directive': reportUnusedVariables,
-            'angular:factory': reportUnusedVariables,
-            'angular:filter': reportUnusedVariables,
-            'angular:inject': reportUnusedVariables,
-            'angular:run': reportUnusedVariables,
-            'angular:service': reportUnusedVariables,
-            'angular:provider': function(callee, providerFn, $get) {
+            'angular?animation': reportUnusedVariables,
+            'angular?config': reportUnusedVariables,
+            'angular?controller': reportUnusedVariables,
+            'angular?directive': reportUnusedVariables,
+            'angular?factory': reportUnusedVariables,
+            'angular?filter': reportUnusedVariables,
+            'angular?inject': reportUnusedVariables,
+            'angular?run': reportUnusedVariables,
+            'angular?service': reportUnusedVariables,
+            'angular?provider': function(callee, providerFn, $get) {
                 reportUnusedVariables(null, providerFn);
@@ -69,0 +69,0 @@ reportUnusedVariables(null, $get);

rules/di.js

@@ -120,12 +120,12 @@ /**
         return {
-            'angular:animation': checkDi,
-            'angular:config': checkDi,
-            'angular:controller': checkDi,
-            'angular:directive': checkDi,
-            'angular:factory': checkDi,
-            'angular:filter': checkDi,
-            'angular:inject': checkDi,
-            'angular:run': checkDi,
-            'angular:service': checkDi,
-            'angular:provider': function(callee, providerFn, $get) {
+            'angular?animation': checkDi,
+            'angular?config': checkDi,
+            'angular?controller': checkDi,
+            'angular?directive': checkDi,
+            'angular?factory': checkDi,
+            'angular?filter': checkDi,
+            'angular?inject': checkDi,
+            'angular?run': checkDi,
+            'angular?service': checkDi,
+            'angular?provider': function(callee, providerFn, $get) {
                 checkDi(null, providerFn);
@@ -132,0 +132,0 @@ checkDi(null, $get);

rules/dumb-inject.js

@@ -28,3 +28,3 @@ /**
         return {
-            'angular:inject': function(callExpression, fn) {
+            'angular?inject': function(callExpression, fn) {
                 if (!fn) {
@@ -31,0 +31,0 @@ return;

rules/file-name.js

@@ -128,2 +128,5 @@ /**
 
+                        if (!name) {
+                            return;
+                        }
                         expectedName = filenameUtil.createExpectedName(name, type, options);
@@ -130,0 +133,0 @@

rules/no-directive-replace.js

@@ -47,3 +47,3 @@ /**
         return {
-            'angular:directive': function(callExpressionNode, fnNode) {
+            'angular?directive': function(callExpressionNode, fnNode) {
                 if (!fnNode || !fnNode.body) {
@@ -50,0 +50,0 @@ return;

rules/no-run-logic.js

@@ -36,3 +36,3 @@ /**
         return {
-            'angular:run': function(callExpression, fn) {
+            'angular?run': function(callExpression, fn) {
                 if (!fn) {
@@ -39,0 +39,0 @@ return;

rules/prefer-component.js

@@ -34,3 +34,3 @@ /*
         return {
-            'angular:directive': function(callExpressionNode, fnNode) {
+            'angular?directive': function(callExpressionNode, fnNode) {
                 if (!fnNode || !fnNode.body) {
@@ -37,0 +37,0 @@ return;

rules/utils/angular-rule.js

@@ -32,13 +32,13 @@ 'use strict';
  *   return {
- *     'angular:animation': function(configCallee, configFn) {},
- *     'angular:component': function(componentCallee, componentObj) {},
- *     'angular:config': function(configCallee, configFn) {},
- *     'angular:controller': function(controllerCallee, controllerFn) {},
- *     'angular:directive': function(directiveCallee, directiveFn) {},
- *     'angular:factory': function(factoryCallee, factoryFn) {},
- *     'angular:filter': function(filterCallee, filterFn) {},
- *     'angular:inject': function(injectCallee, injectFn) {},  // inject() calls from angular-mocks
- *     'angular:run': function(runCallee, runFn) {},
- *     'angular:service': function(serviceCallee, serviceFn) {},
- *     'angular:provider': function(providerCallee, providerFn, provider$getFn) {}
+ *     'angular?animation': function(configCallee, configFn) {},
+ *     'angular?component': function(componentCallee, componentObj) {},
+ *     'angular?config': function(configCallee, configFn) {},
+ *     'angular?controller': function(controllerCallee, controllerFn) {},
+ *     'angular?directive': function(directiveCallee, directiveFn) {},
+ *     'angular?factory': function(factoryCallee, factoryFn) {},
+ *     'angular?filter': function(filterCallee, filterFn) {},
+ *     'angular?inject': function(injectCallee, injectFn) {},  // inject() calls from angular-mocks
+ *     'angular?run': function(runCallee, runFn) {},
+ *     'angular?service': function(serviceCallee, serviceFn) {},
+ *     'angular?provider': function(providerCallee, providerFn, provider$getFn) {}
  *   };
@@ -231,3 +231,3 @@ * })
             var name = component.callExpression.callee.property.name;
-            var fn = ruleObject['angular:' + name];
+            var fn = ruleObject['angular?' + name];
             if (!fn) {
@@ -238,3 +238,3 @@ return;
         });
-        var injectRule = ruleObject['angular:inject'];
+        var injectRule = ruleObject['angular?inject'];
         if (injectRule) {
@@ -241,0 +241,0 @@ injectCalls.forEach(function(node) {

rules/utils/false-values.js

 'use strict';
 
 module.exports = {
-    config: ['jwtOptionsProvider', 'ngTableHelperProvider', '$ocLazyLoadProvider', '$route', '$localForageProvider']
+    config: [/Provider$/, /$route/],
+    run: [/mocha/, /Service$/]
 };

rules/utils/utils.js

 'use strict';
 var falseConfigValues = require('./false-values').config;
+var falseRunValues = require('./false-values').run;
 
@@ -461,4 +462,3 @@ var scopeProperties = [
         node.callee.property.name === 'run' &&
-        (node.callee.object.type === 'Identifier' &&
-         node.callee.object.name !== 'mocha');
+        !falseRunValues.find(pattern => new RegExp(pattern).test(node.callee.object.name));
 }
@@ -492,3 +492,3 @@
      node.callee.property.name === 'config' &&
-     falseConfigValues.indexOf(node.callee.object.name) < 0;
+     !falseConfigValues.find(pattern => new RegExp(pattern).test(node.callee.object.name));
 }
@@ -495,0 +495,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

196300

increased by0.08%

Lines of code

4483

increased by0.09%

No dependency changes