feathers-knex-modeler - npm Package Compare versions

Comparing version 1.4.4 to 1.4.5

.vscode/settings.json

 {
     "standard.enable": true,
     "standard.autoFixOnSave": true,
-    "vetur.format.enable": false,
-    "javascript.validate.enable": false,
-    "eslint.autoFixOnSave": false,
-    "javascript.format.enable": false,
-    "prettier.eslintIntegration": false,
-    "eslint.enable": false,
     "editor.formatOnSave": false
   }
   

package.json

 {
   "name": "feathers-knex-modeler",
-  "version": "1.4.4",
+  "version": "1.4.5",
   "description": "This package allows you to easily extend a table while you are developing it without requiring you to drop tables.",
@@ -19,3 +19,3 @@ "main": "src/index.js",
     "lodash": "^4.17.15",
-    "p-queue": "^6.2.1",
+    "p-queue": "^6.5.0",
     "p-wait-for": "^3.1.0"
@@ -25,6 +25,7 @@ },
     "chai": "^4.2.0",
-    "knex": "^0.20.7",
-    "mocha": "^7.0.0",
-    "pg": "^7.17.0"
+    "knex": "^0.21.1",
+    "mocha": "^8.0.1",
+    "pg": "^8.2.1",
+    "standard": "^14.3.4"
   }
 }

src/index.js

@@ -147,3 +147,3 @@ /* eslint-disable no-console */
         const columnToAlter = self.tableColumnUtilityMethod(table, column)
-
+        // console.log(table)
         switch (typeOfColumn) {
@@ -163,18 +163,34 @@ case 'notNullable': {
           case 'references' : {
+            const referenceArray =  argument.split('.')
+            const referenceTable =referenceArray[0]
+            const referenceColumn =referenceArray[1]
+            const constraintName = `${self.name}_${referenceTable}_${referenceColumn}`
+  try{
+            
+            debug(`Table: ${self.name} Constraint name: ${constraintName}`)
+            const alterTableRaw = `alter table "${self.name}" add constraint "${constraintName}" foreign key ("${column.name}") references "${referenceTable}" ("${referenceColumn}")`
+            debug(`Table: ${self.name} constraint creation: ${alterTableRaw}`)
+            await db.raw(alterTableRaw)
+            await columnToAlter.references(referenceColumn).on(referenceTable)
+          }catch(err){
+            const errorMessage = _.defaultTo(_.get(err,'message'),'')
+            if(errorMessage.indexOf('already exists')!==-1){
+            debug(`Failed to create constraint because it already exists. ${err || ''}`)
+            }else{
+              throw new Error(`Failed to create constraint. ${err||''}`)
+            }
+          }
             if (hasOnDelete !== false && hasOnUpdate !== false) {
               self.debug(`Column: ${column.name}, references onUpdate and onDelete`)
-              columnToAlter.references(argument).onDelete(hasOnDelete.argument).onUpdate(hasOnUpdate.argument)
+              columnToAlter.onDelete(hasOnDelete.argument).onUpdate(hasOnUpdate.argument)
             }
             if (hasOnDelete !== false && hasOnUpdate === false) {
               self.debug(`Column: ${column.name}, references onDelete`)
-              columnToAlter.references(argument).onDelete(hasOnDelete.argument)
+              columnToAlter.onDelete(hasOnDelete.argument)
             }
             if (hasOnUpdate !== false && hasOnDelete === false) {
               self.debug(`Column: ${column.name}, references onUpdate`)
-              columnToAlter.references(argument).onUpdate(hasOnUpdate.argument)
+              columnToAlter.onUpdate(hasOnUpdate.argument)
             }
-            if (hasOnDelete === false && hasOnUpdate === false) {
-              self.debug(`Column: ${column.name}, references no onUpdate or onDelete`)
-              columnToAlter.references(argument)
-            }
+          
             break
@@ -181,0 +197,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

22067

increased by3.06%

Lines of code

552

increased by1.66%

Worsened metrics

Dev dependency count

5

increased by25%

Dependency changes

• Updatedp-queue@^6.5.0