fela-bindings - npm Package Compare versions

Comparing version 10.6.1 to 10.7.0

es/RendererProviderFactory.js

@@ -13,6 +13,11 @@ var _createClass = function () { function defineProperties(target, props) { for (var i = 0; i < props.length; i++) { var descriptor = props[i]; descriptor.enumerable = descriptor.enumerable || false; descriptor.configurable = true; if ("value" in descriptor) descriptor.writable = true; Object.defineProperty(target, descriptor.key, descriptor); } } return function (Constructor, protoProps, staticProps) { if (protoProps) defineProperties(Constructor.prototype, protoProps); if (staticProps) defineProperties(Constructor, staticProps); return Constructor; }; }();
 function hasDOM(renderer, targetDocument) {
-  if (typeof window === 'undefined') return false;
-  if (!targetDocument) targetDocument = document;
+  // ensure we're on a browser by using document since window is defined in e.g. React Native
+  // see https://github.com/robinweser/fela/issues/736
+  if (typeof document === 'undefined') {
+    return false;
+  }
 
-  return renderer && !renderer.isNativeRenderer && targetDocument && targetDocument.createElement;
+  var doc = targetDocument || document;
+
+  return renderer && !renderer.isNativeRenderer && doc && doc.createElement;
 }
@@ -19,0 +24,0 @@

lib/RendererProviderFactory.js

@@ -26,6 +26,11 @@ 'use strict';
 function hasDOM(renderer, targetDocument) {
-  if (typeof window === 'undefined') return false;
-  if (!targetDocument) targetDocument = document;
+  // ensure we're on a browser by using document since window is defined in e.g. React Native
+  // see https://github.com/robinweser/fela/issues/736
+  if (typeof document === 'undefined') {
+    return false;
+  }
 
-  return renderer && !renderer.isNativeRenderer && targetDocument && targetDocument.createElement;
+  var doc = targetDocument || document;
+
+  return renderer && !renderer.isNativeRenderer && doc && doc.createElement;
 }
@@ -32,0 +37,0 @@

package.json

 {
   "name": "fela-bindings",
-  "version": "10.6.1",
+  "version": "10.7.0",
   "description": "Abstract binding factories for Fela",
@@ -30,8 +30,8 @@ "main": "lib/index.js",
     "fast-loops": "^1.0.0",
-    "fela-dom": "^10.6.1",
-    "fela-tools": "^10.6.1",
+    "fela-dom": "^10.7.0",
+    "fela-tools": "^10.7.0",
     "react-addons-shallow-compare": "^15.6.2",
     "shallow-equal": "^1.0.0"
   },
-  "gitHead": "17ed6c0eff16effe089066ac84e1d817baacb13d"
+  "gitHead": "1e832301926eefb4c0cf955ec3cb9e7298d9d06e"
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

64203

increased by0.41%

Lines of code

1171

increased by0.69%

Dependency changes

• Updatedfela-dom@^10.7.0

• Updatedfela-tools@^10.7.0