fh-wfm-sync - npm Package Compare versions

Comparing version 0.1.3-alpha.504.4 to 0.1.3-alpha.504.5

lib/client/data-manager.js

@@ -77,3 +77,3 @@ var _ = require('lodash');
 /**
- * Sets sync status for a result object.
+ * Sets sync status for an object.
  * @param {object} event - object passed in by sync event handler, should contain data used for logItem object.
@@ -108,2 +108,13 @@ */
 /**
+ * returns metadata for the dataset managed by this manager
+ * @param {function} callback - a callback that will get metadata passed in.
+ */
+DataManager.prototype.getMetaData = function getMetaData(callback) {
+  this.$fh.sync.getMetaData(this.datasetId, function(metadata) {
+    callback(metadata);
+  });
+};
+
+
+/**
  * Creating all of the mediator subscribers for this sync data set.
@@ -110,0 +121,0 @@ */

lib/client/mediator-subscribers/create.js

@@ -27,3 +27,6 @@ var CONSTANTS = require('../../constants');
     var datasetItemToCreate = parameters.itemToCreate;
+
+    // remove _syncStatus, it can cause sync loop when updated and this data is irrelevant outside client
     delete datasetItemToCreate._syncStatus;
+
     //Creating a data item for this dataset.
@@ -30,0 +33,0 @@ datasetManager.create(datasetItemToCreate).then(function(createdDatasetItem) {

lib/client/mediator-subscribers/list-spec.js

@@ -51,7 +51,3 @@ var mediator = require("fh-wfm-mediator/lib/mediator");
       list: sinon.stub().resolves(arrayOfDataItems),
-      $fh: {
-        sync: {
-          getMetaData: sinon.stub().callsArgWith(1, mockMetaData)
-        }
-      }
+      getMetaData: sinon.stub().callsArgWith(0, mockMetaData)
     };
@@ -133,7 +129,3 @@
       list: sinon.stub().rejects(expectedTopicError),
-      $fh: {
-        sync: {
-          getMetaData: sinon.stub().callsArgOnWith(1, mockMetaData)
-        }
-      }
+      getMetaData: sinon.stub().callsArgOnWith(0, mockMetaData)
     };
@@ -178,22 +170,2 @@
 
-});
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+});

lib/client/mediator-subscribers/list.js

@@ -24,4 +24,4 @@ var CONSTANTS = require('../../constants');
 
-    //Creating the item in the sync store
-    datasetManager.$fh.sync.getMetaData(datasetManager.datasetId, function(metadata) {
+
+    datasetManager.getMetaData(function(metadata) {
       datasetManager.list().then(function(arrayOfDatasetItems) {
@@ -28,0 +28,0 @@ var listDoneTopic = syncDatasetTopics.getTopic(CONSTANTS.TOPICS.LIST, CONSTANTS.DONE_PREFIX, parameters.topicUid);

lib/client/mediator-subscribers/read-spec.js

@@ -44,7 +44,3 @@ var mediator = require("fh-wfm-mediator/lib/mediator");
       read: sinon.stub().resolves(mockDataItem),
-      $fh: {
-        sync: {
-          getMetaData: sinon.stub().callsArgWith(1, mockMetaData)
-        }
-      }
+      getMetaData: sinon.stub().callsArgWith(0, mockMetaData)
     };
@@ -111,7 +107,3 @@
       read: sinon.stub().rejects(expectedTopicError),
-      $fh: {
-        sync: {
-          getMetaData: sinon.stub().callsArgWith(1, mockMetaData)
-        }
-      }
+      getMetaData: sinon.stub().callsArgWith(0, mockMetaData)
     };
@@ -180,7 +172,3 @@
         read: sinon.stub().resolves(mockDataItem),
-        $fh: {
-          sync: {
-            getMetaData: sinon.stub().callsArgWith(1, mockMetaData)
-          }
-        }
+        getMetaData: sinon.stub().callsArgWith(0, mockMetaData)
       };
@@ -200,5 +188,5 @@ mockDatasetManager.read.reset();
         sinon.assert.calledOnce(mockDatasetManager.read);
-        sinon.assert.calledOnce(mockDatasetManager.$fh.sync.getMetaData);
+        sinon.assert.calledOnce(mockDatasetManager.getMetaData);
 
-        sinon.assert.calledWith(mockDatasetManager.$fh.sync.getMetaData, sinon.match(mockDatasetManager.datasetId));
+        sinon.assert.calledWith(mockDatasetManager.getMetaData, sinon.match.func);
         sinon.assert.calledWith(mockDatasetManager.read, sinon.match(mockDataItem.id));
@@ -225,7 +213,3 @@
         read: sinon.stub().resolves(mockDataItemNoEvents),
-        $fh: {
-          sync: {
-            getMetaData: sinon.stub().callsArgWith(1, mockMetaData)
-          }
-        }
+        getMetaData: sinon.stub().callsArgWith(0, mockMetaData)
       };
@@ -246,5 +230,5 @@
         sinon.assert.calledOnce(mockDatasetManager.read);
-        sinon.assert.calledOnce(mockDatasetManager.$fh.sync.getMetaData);
+        sinon.assert.calledOnce(mockDatasetManager.getMetaData);
 
-        sinon.assert.calledWith(mockDatasetManager.$fh.sync.getMetaData, sinon.match(mockDatasetManager.datasetId));
+        sinon.assert.calledWith(mockDatasetManager.getMetaData, sinon.match.func);
         sinon.assert.calledWith(mockDatasetManager.read, sinon.match(mockDataItemNoEvents.id));
@@ -251,0 +235,0 @@

lib/client/mediator-subscribers/read.js

@@ -26,4 +26,5 @@ var CONSTANTS = require('../../constants');
 
+
     //Creating the item in the sync store
-    datasetManager.$fh.sync.getMetaData(datasetManager.datasetId, function(metadata) {
+    datasetManager.getMetaData(function(metadata) {
       datasetManager.read(parameters.id).then(function(itemRead) {
@@ -30,0 +31,0 @@ var readDoneTopic = syncDatasetTopics.getTopic(CONSTANTS.TOPICS.READ, CONSTANTS.DONE_PREFIX, parameters.topicUid);

lib/client/mediator-subscribers/update.js

@@ -27,2 +27,4 @@ var CONSTANTS = require('../../constants');
     var datasetItemToUpdate = parameters.itemToUpdate;
+
+    // remove _syncStatus, it can cause sync loop when updated and this data is irrelevant outside client
     delete datasetItemToUpdate._syncStatus;
@@ -29,0 +31,0 @@

package.json

 {
   "name": "fh-wfm-sync",
-  "version": "0.1.3-alpha.504.4",
+  "version": "0.1.3-alpha.504.5",
   "description": "An sync module for WFM",
@@ -5,0 +5,0 @@ "main": "lib/angular/sync-ng.js",

No alert changes

Worsened metrics

Total package byte prevSize

924673

Lines of code

24829

decreased by-0.06%

No dependency changes