fnflow - npm Package Compare versions

Comparing version 0.4.0 to 0.4.1

lib/task.js

@@ -142,3 +142,3 @@ var util = require('util');
     } catch(e){
-      throw new FlowTaskError(self.name, "Error during execution of function.", e);
+      return callback(new FlowTaskError(self.name, "Error during execution of function.", e));
     }
@@ -145,0 +145,0 @@ });

package.json

@@ -6,3 +6,3 @@ {
   "author": "David Fenster <[e-mail]>",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "repository": {
@@ -9,0 +9,0 @@ "type": "git",

tests/001-flow.js

@@ -549,21 +549,31 @@ var us = require('underscore');
 module.exports["error in task function"] = function(test){
-  try {
-    new Flow({
-      getBook: new Task(Book.getById, 'bookId'),
-      getAuthor: new Task(Author.getById),
+  new Flow({
+    getBook: new Task(Book.getById, 'bookId'),
+    getAuthor: new Task(Author.getById),
   }).execute({
-      bookId: 1
-    }, function(err, results){
-      test.fail(null, null, "no error received");
-      test.done();
-    });
-  } catch(e) {
-    test.ok(e, 'got an error'); 
-    test.equals(e.name, "FlowTaskError", "got FlowTaskError");
-    test.equals(e.message, "Flow error in 'getAuthor': Error during execution of function.", "error message match")
-    test.ok(/TypeError: undefined is not a function/.test(e.stack))
+    bookId: 1
+  }, function(err, results){
+    test.ok(err, 'got an error'); 
+    test.equals(err.name, "FlowTaskError", "got FlowTaskError");
+    test.equals(err.message, "Flow error in 'getAuthor': Error during execution of function.", "error message match")
+    test.ok(/TypeError: undefined is not a function/.test(err.stack))
     test.done();
-  }
+  });
 }
 
+module.exports["error in synchronous task function"] = function(test){
+  new Flow({
+    getBook: new Task(Book.getById, 'bookId'),
+    getAuthor: new Fn(Author.getById),
+  }).execute({
+    bookId: 1
+  }, function(err, results){
+    test.ok(err, 'got an error'); 
+    test.equals(err.name, "FlowTaskError", "got FlowTaskError");
+    test.equals(err.message, "Flow error in 'getAuthor': Error during execution of function.", "error message match")
+    test.ok(/TypeError: undefined is not a function/.test(err.stack))
+    test.done();
+  });
+}
+
 module.exports["subFlow execution"] = function(test){
@@ -570,0 +580,0 @@ new Flow({

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

111185

increased by0.41%

Lines of code

1803

increased by0.5%

No dependency changes