get-scroll-info - npm Package Compare versions

Comparing version 0.4.0 to 0.4.1

build/cjs/src/index.js

@@ -7,2 +7,3 @@ "use strict";
 var _reshowConstant = require("reshow-constant");
+var _getRandomId = require("get-random-id");
 // @ts-check
@@ -22,3 +23,2 @@
 var docEl;
-var domCount = 0;
 var initDoc = function initDoc() {
@@ -32,3 +32,3 @@ oDoc = (0, _winDoc.doc)();
 /**
- * @param {HTMLElement} el
+ * @param {HTMLElement} [el]
  * @returns {HTMLElement}
@@ -49,37 +49,35 @@ */
   }
-  if (!el.id) {
-    el.id = "scroll-info-" + domCount;
-    domCount++;
+  var htmlEl = /** @type {HTMLElement}*/el;
+  if (!htmlEl.id) {
+    htmlEl.id = (0, _getRandomId.getSN)("scroll-info-");
   }
-  return el;
+  return htmlEl;
 };
 
 /**
- * @typedef {object} InfoType 
+ * @typedef {object} ScrollInfoType
  * @property {boolean} atTop
  * @property {boolean} atRight
- * @property {boolean} atBottom 
- * @property {boolean} atLeft 
- * @property {boolean} isScrollUp 
- * @property {boolean} isScrollRight 
- * @property {boolean} isScrollDown 
+ * @property {boolean} atBottom
+ * @property {boolean} atLeft
+ * @property {boolean} isScrollUp
+ * @property {boolean} isScrollRight
+ * @property {boolean} isScrollDown
  * @property {boolean} isScrollLeft
- * @property {number} scrollWidth 
- * @property {number} scrollHeight 
- * @property {number} scrollNodeWidth 
- * @property {number} scrollNodeHeight 
+ * @property {number} scrollWidth
+ * @property {number} scrollHeight
+ * @property {number} scrollNodeWidth
+ * @property {number} scrollNodeHeight
  * @property {number} top
- * @property {number} right 
- * @property {number} bottom 
- * @property {number} left 
+ * @property {number} right
+ * @property {number} bottom
+ * @property {number} left
  */
 
 /**
- * @returns {InfoType}
+ * @param {HTMLElement} [el]
+ * @returns {ScrollInfoType}
  */
 exports.getScrollNode = getScrollNode;
 var getScrollInfo = function getScrollInfo(el, margin) {
-  if (el === void 0) {
-    el = null;
-  }
   if (margin === void 0) {
@@ -86,0 +84,0 @@ margin = 50;

package.json

 {
-  "version": "0.4.0",
+  "version": "0.4.1",
   "name": "get-scroll-info",
@@ -15,2 +15,3 @@ "repository": {
   "dependencies": {
+    "get-random-id": "*",
     "reshow-constant": "*",
@@ -17,0 +18,0 @@ "reshow-runtime": "*",

types/index.d.ts

 export default getScrollInfo;
 export type ThisDocument = object & Document;
-export type InfoType = {
+export type ScrollInfoType = {
     atTop: boolean;
@@ -22,3 +22,3 @@ atRight: boolean;
 /**
- * @typedef {object} InfoType
+ * @typedef {object} ScrollInfoType
  * @property {boolean} atTop
@@ -42,9 +42,10 @@ * @property {boolean} atRight
 /**
- * @returns {InfoType}
+ * @param {HTMLElement} [el]
+ * @returns {ScrollInfoType}
  */
-declare function getScrollInfo(el?: any, margin?: number): InfoType;
+declare function getScrollInfo(el?: HTMLElement, margin?: number): ScrollInfoType;
 /**
- * @param {HTMLElement} el
+ * @param {HTMLElement} [el]
  * @returns {HTMLElement}
  */
-export function getScrollNode(el: HTMLElement): HTMLElement;
+export function getScrollNode(el?: HTMLElement): HTMLElement;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Wildcard dependency

Quality

Package has a dependency with a floating version range. This can cause issues if the dependency publishes a new major version.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

10677

increased by1.95%

Worsened metrics

Dependency count

4

increased by33.33%

Lines of code

324

decreased by-0.92%

Number of medium quality alerts

5

increased by25%

Dependency changes

• + Addedget-random-id@*

• + Addedcall-func@0.4.0(transitive)

• + Addedget-random-id@0.4.1(transitive)