grpc-server-js - npm Package Compare versions

Comparing version 0.3.0 to 0.3.1

lib/handler.js

@@ -80,8 +80,8 @@ 'use strict';
       }
+
+      callback();
     } catch (err) {
       err.code = Status.INTERNAL;
-      this.emit('error', err);
+      callback(err);
     }
-
-    callback();
   }
@@ -200,2 +200,9 @@
   stream.call.once('end', () => {
+    // If the HTTP2 stream was destroyed, an error happened so this stream
+    // should not emit an 'end' event.
+    if (stream.call.destroyed) {
+      stream.destroy();
+      return;
+    }
+
     stream[kReadablePushOrBufferMessage](null);
@@ -262,3 +269,3 @@ });
     stream[kCall].sendError(err);
-    stream.end();
+    stream.destroy();
   });
@@ -265,0 +272,0 @@ }

lib/index.d.ts

@@ -117,2 +117,3 @@ /// <reference types="node" />
   cancelled: boolean;
+  readonly metadata: Metadata;
   getPeer(): string;
@@ -119,0 +120,0 @@ sendMetadata(responseMetadata: Metadata): void;

lib/server-resolver.js

@@ -29,4 +29,10 @@ 'use strict';
   const defaultPort = secure === true ? 443 : 80;
-  const port = String(+url.port) === url.port ? +url.port : defaultPort;
+  let port = String(+url.port) === url.port ? +url.port : defaultPort;
 
+  // Handle an edge case. WHATWG URLs don't set their port to 80, so a manual
+  // check is required here.
+  if (secure && url.port === '' && target.includes(`${url.hostname}:80`)) {
+    port = 80;
+  }
+
   return { host: url.hostname, port };
@@ -33,0 +39,0 @@ }

package.json

 {
   "name": "grpc-server-js",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "Pure JavaScript gRPC Server",
@@ -26,3 +26,3 @@ "author": "Colin J. Ihrig <[e-mail]> (http://www.cjihrig.com/)",
   "devDependencies": {
-    "@grpc/grpc-js": "^0.7.1",
+    "@grpc/grpc-js": "1.x.x",
     "@grpc/proto-loader": "0.5.x",
@@ -29,0 +29,0 @@ "belly-button": "6.x.x",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

58405

increased by0.72%

Lines of code

1630

increased by0.74%

No dependency changes