grunt-protractor-webdriver - npm Package Compare versions

Comparing version 0.1.9 to 0.2.0

bower_components/angular/.bower.json

 {
   "name": "angular",
-  "version": "1.2.25",
+  "version": "1.3.5",
   "main": "./angular.js",
+  "ignore": [],
   "dependencies": {},
   "homepage": "https://github.com/angular/bower-angular",
-  "_release": "1.2.25",
+  "_release": "1.3.5",
   "_resolution": {
     "type": "version",
-    "tag": "v1.2.25",
-    "commit": "0d956316b0472031ac895e57c14b8b2100eea9fb"
+    "tag": "v1.3.5",
+    "commit": "9acb014af4fd7b0ab001c64fa7bcac454ab4050b"
   },
   "_source": "git://github.com/angular/bower-angular.git",
-  "_target": "~1.2.25",
+  "_target": "~1.3.5",
   "_originalSource": "angular"
 }

bower_components/angular/bower.json

 {
   "name": "angular",
-  "version": "1.2.25",
+  "version": "1.3.5",
   "main": "./angular.js",
+  "ignore": [],
   "dependencies": {
   }
 }

bower_components/angular/README.md

@@ -1,4 +0,4 @@
-# bower-angular
+# packaged angular
 
-This repo is for distribution on `bower`. The source for this module is in the
+This repo is for distribution on `npm` and `bower`. The source for this module is in the
 [main AngularJS repo](https://github.com/angular/angular.js).
@@ -9,9 +9,28 @@ Please file issues and pull requests against that repo.
 
-Install with `bower`:
+You can install this package either with `npm` or with `bower`.
 
+### npm
+
 ```shell
+npm install angular
+```
+
+Then add a `<script>` to your `index.html`:
+
+```html
+<script src="/node_modules/angular/angular.js"></script>
+```
+
+Note that this package is not in CommonJS format, so doing `require('angular')` will return `undefined`.
+If you're using [Browserify](https://github.com/substack/node-browserify), you can use
+[exposify](https://github.com/thlorenz/exposify) to have `require('angular')` return the `angular`
+global.
+
+### bower
+
+```shell
 bower install angular
 ```
 
-Add a `<script>` to your `index.html`:
+Then add a `<script>` to your `index.html`:
 
@@ -18,0 +37,0 @@ ```html

bower.json

 {
   "name": "grunt-protractor-webdriver",
   "description": "grunt plugin for starting Protractor's bundled Selenium Webdriver",
-  "version": "0.1.9",
+  "version": "0.2.0",
   "private": true,
   "homepage": "https://github.com/seckardt/grunt-protractor-webdriver",
   "devDependencies": {
-    "angular": "~1.2.25"
+    "angular": "~1.3.5"
   },
@@ -10,0 +10,0 @@ "keywords": [

Gruntfile.js

@@ -17,5 +17,3 @@ /*
 
-	var path = require('path'),
-		isWindows = process.platform === 'win32',
-		ptorDir = 'node_modules' + (isWindows ? '/.' : '/protractor/') + 'bin/';
+	var path = require('path');
 
@@ -47,11 +45,6 @@ // Project configuration.
 				options: {
-					path: ptorDir,
 					keepAlive: true
 				}
 			},
-			dead: {
-				options: {
-					path: ptorDir
-				}
-			}
+			dead: {}
 		},
@@ -73,3 +66,3 @@
 				},
-				command: path.resolve(ptorDir + 'webdriver-manager') + ' update --standalone --chrome'
+				command: path.resolve('node_modules/protractor/bin/webdriver-manager') + ' update --standalone --chrome'
 			}
@@ -76,0 +69,0 @@ }

package.json

 {
   "name": "grunt-protractor-webdriver",
   "description": "grunt plugin for starting Protractor's bundled Selenium Webdriver",
-  "version": "0.1.9",
+  "version": "0.2.0",
   "homepage": "https://github.com/seckardt/grunt-protractor-webdriver",
@@ -31,3 +31,3 @@ "author": {
     "grunt-shell": "~1.1.1",
-    "protractor": "~1.2.0",
+    "protractor": "~1.4.0",
     "express": "~3.5.0",
@@ -34,0 +34,0 @@ "grunt": "~0.4.5"

README.md

@@ -94,2 +94,4 @@ # grunt-protractor-webdriver [![devDependency Status](https://david-dm.org/seckardt/grunt-protractor-webdriver/dev-status.png)](https://david-dm.org/seckardt/grunt-protractor-webdriver#info=devDependencies) [![NPM version](https://badge.fury.io/js/grunt-protractor-webdriver.png)](http://badge.fury.io/js/grunt-protractor-webdriver) [![Built with Grunt](https://cdn.gruntjs.com/builtwith.png)](http://gruntjs.com/)
 
+* v0.2.0 - **Possible breaking change for some, depending on the `path` configuration.** Fix for issue [#3](https://github.com/seckardt/grunt-protractor-webdriver/issues/3). Always use `node` now to execute the `webdriver_manager` commands.
+* v0.1.9 - Use configuration option `keepAlive` also in case of exception being thrown by the Selenium process. Alternative implementation for original PR [#5](https://github.com/seckardt/grunt-protractor-webdriver/pull/5).
 * v0.1.8 - Add support for new configuration option `keepAlive`.
@@ -96,0 +98,0 @@ * v0.1.7 - Fix for issue [#1](https://github.com/seckardt/grunt-protractor-webdriver/issues/1). Print out a warning if Selenium server is not present. Additionally stop Selenium server gracefully on clean Grunt process shutdown.

tasks/protractor_webdriver.js

@@ -33,2 +33,3 @@ /**
 		REGEXP_SHUTDOWN_OK = /OKOK/i,
+		DEFAULT_PATH = 'node_modules/protractor/bin/',
 		DEFAULT_CMD = 'webdriver-manager start',
@@ -82,3 +83,3 @@ DEFAULT_INSTANCE = 'http://localhost:4444';
 
-			selenium = exec(options.path + options.command);
+			selenium = exec('node ' + options.path + options.command);
 			selenium.on('error', exit)
@@ -257,3 +258,3 @@ .on('uncaughtException', exit)
 		new Webdriver(this, this.options({
-			path: '',
+			path: DEFAULT_PATH,
 			command: DEFAULT_CMD,
@@ -260,0 +261,0 @@ keepAlive: false

New alerts

Uses eval

Supply chain risk

Package uses dynamic code execution (e.g., eval()), which is a dangerous practice. This can prevent the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Found 1 instance in 1 package

Dynamic require

Supply chain risk

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Found 1 instance in 1 package

AI-detected potential code anomaly

Supply chain risk

AI has identified unusual behaviors that may pose a security risk.

Found 1 instance in 1 package

Minified code

Quality

This package contains minified code. This may be harmless in some cases where minified code is included in packaged libraries, however packages on npm should not minify code.

Found 1 instance in 1 package

URL strings

Supply chain risk

Package contains fragments of external URLs or IP addresses, which the package may be accessing at runtime.

Found 1 instance in 1 package

Fixed alerts

Uses eval

Supply chain risk

Package uses dynamic code execution (e.g., eval()), which is a dangerous practice. This can prevent the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Found 1 instance in 1 package

URL strings

Supply chain risk

Package contains fragments of external URLs or IP addresses, which the package may be accessing at runtime.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1490257

19.35%

Number of package files

24

4.35%

Lines of code

24526

17.19%

Number of lines in readme file

108

1.89%

Worsened metrics

Number of low quality alerts

2

100%

Number of low supply chain risk alerts

6

200%

Number of medium supply chain risk alerts

6

50%

No dependency changes