haraka-net-utils - npm Package Compare versions

Comparing version 1.3.0 to 1.3.1

Changes.md

 
-### 1.2.4 - 2021-01-14
+#### 1.N.N - YYYY-MM-DD
 
+
+#### 1.3.1 - 2021-10-13
+
+- get_mx: wrap dns.resolveMx in a try haraka/Haraka#2985
+- add .release scripts
+- add GH workflow, publish release to NPM upon merge to master
+
+
+#### 1.3.0 - 2021-01-23
+
+- Support passing an array to ip_in_list #60
+
+
+#### 1.2.4 - 2021-01-14
+
 - add "any" IP to is_local_ip
 - add TEST-NET-[1-3] to is_private_ip
 
-### 1.2.3 - 2020-12-19
 
+#### 1.2.3 - 2020-12-19
+
 - fix: restore the tests wrapping the resolveMX iterable
 
-### 1.2.2 - 2020-12-15
 
+#### 1.2.2 - 2020-12-15
+
 - get_mx: do not include implicit MX
 
-### 1.2.1 - 2020-11-17
 
+#### 1.2.1 - 2020-11-17
+
 - bump ipaddr.js to 2.0.0 #56
 
-### 1.2.0 - 2020-06-23
 
+#### 1.2.0 - 2020-06-23
+
 - added get_mx
@@ -25,33 +44,41 @@ - remove deprecated load_tls_ini
 
-### 1.1.5 - 2020-04-11
 
+#### 1.1.5 - 2020-04-11
+
 - ipv6_bogus: handle parsing broken ipv6 addresses #49
 - update async to version 3.0.1 #43
 
-### 1.1.4 - 2019-04-04
 
+#### 1.1.4 - 2019-04-04
+
 - stop is_private_ip from checking if the IP is bound to a local network interface
 
-### 1.1.3 - 2019-03-01
 
+#### 1.1.3 - 2019-03-01
+
 - is_local_ip checks local network interfaces too
 
-### 1.1.2 - 2018-11-03
 
+#### 1.1.2 - 2018-11-03
+
 - add is_local_ip
 
-### 1.1.1 - 2018-07-19
 
+#### 1.1.1 - 2018-07-19
+
 - ip_in_list doesn't throw on empty list
 
-### 1.1.0 - 2018-04-11
 
+#### 1.1.0 - 2018-04-11
+
 - add get_primary_host_name haraka/Haraka#2380
 
-### 1.0.14 - 2018-01-25
 
+#### 1.0.14 - 2018-01-25
+
 - restore tls_ini_section_with_defaults function (deprecated since Haraka 2.0.17)
 
-### 1.0.13 - 2018-01-19
 
+#### 1.0.13 - 2018-01-19
+
 - get_public_ip: assign timer before calling connect #29
@@ -64,12 +91,15 @@ - avoid race where timeout isn't cleared because stun connect errors immediately
 
-### 1.0.10 - 2017-07-27
 
+#### 1.0.10 - 2017-07-27
+
 - added vs-stun as optional dep (from Haraka) #21
 
-### 1.0.9 - 2017-06-16
 
+#### 1.0.9 - 2017-06-16
+
 - lint fixes for compat with eslint 4  #18
 
-### 1.0.8 - 2017-03-08
 
+#### 1.0.8 - 2017-03-08
+
 - skip loading expired x509 (TLS) certs
@@ -80,8 +110,10 @@ - make TLS cert dir configurable
 
-### 1.0.7 - 2017-03-08
 
+#### 1.0.7 - 2017-03-08
+
 - handle undefined tls.ini section
 
-### 1.0.6 - 2017-03-04
 
+#### 1.0.6 - 2017-03-04
+
 - add tls_ini_section_with_defaults()
@@ -91,12 +123,15 @@ - add load_tls_dir()
 
-### 1.0.5 - 2016-11-20
 
+#### 1.0.5 - 2016-11-20
+
 * add enableSNI TLS option
 
-### 1.0.4 - 2016-10-25
 
+#### 1.0.4 - 2016-10-25
+
 * initialize TLS opts in (section != main) as booleans
 
-### 1.0.3 - 2016-10-25
 
+#### 1.0.3 - 2016-10-25
+
 * added tls.ini loading

index.js

@@ -447,12 +447,17 @@ 'use strict';
 
-  dns.resolveMx(domain, (err, addresses) => {
+  try {
+    dns.resolveMx(domain, (err, addresses) => {
 
-    if (addresses && addresses.length) {
-      for (const addr of addresses) {
-        mxs.push(wrap_mx(addr));
+      if (addresses && addresses.length) {
+        for (const addr of addresses) {
+          mxs.push(wrap_mx(addr));
+        }
       }
-    }
 
-    cb(err, mxs);
-  })
+      cb(err, mxs);
+    })
+  }
+  catch (e) {
+    cb(e, mxs)
+  }
 }

package.json

 {
   "name": "haraka-net-utils",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "description": "haraka network utilities",
@@ -33,3 +33,3 @@ "main": "index.js",
   "devDependencies": {
-    "eslint": "*",
+    "eslint": ">=7.32.0",
     "mocha": "*",
@@ -39,6 +39,6 @@ "eslint-plugin-haraka": "*"
   "dependencies": {
-    "async": "^3.2",
+    "async": "^3.2.1",
     "haraka-config": ">=1.0.11",
     "haraka-tld": "*",
-    "ipaddr.js": "^2.0.0",
+    "ipaddr.js": "^2.0.1",
     "punycode": "^2.1.1",
@@ -45,0 +45,0 @@ "openssl-wrapper": "^0.3.4",

test/net_utils.js

@@ -1119,2 +1119,9 @@
   })
+
+  it('does not crash on invalid IDN name', function (done) {
+    this.net_utils.get_mx('gmail.xn--com-0da', (err, mxlist) => {
+      assert.strictEqual(err.message, 'Cannot convert name to ASCII')
+      done()
+    })
+  })
 })

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

1408

increased by0.79%

Worsened metrics

Total package byte prevSize

79390

decreased by-1.15%

Number of package files

18

decreased by-14.29%

Dependency changes

• Updatedasync@^3.2.1

• Updatedipaddr.js@^2.0.1