homebridge-tcc - npm Package Compare versions

Comparing version 0.2.24 to 0.2.25

index.js

@@ -94,3 +94,3 @@ /*jslint node: true */
       .on('set', setHeatingThresholdTemperature.bind(accessory));
-    // } else {
+
     accessory
@@ -141,3 +141,3 @@ .getService(Service.Thermostat)
             .updateValue(new Error("Status missing for thermostat"));
-          }
+        }
       }
@@ -159,3 +159,3 @@ }.bind(this));
           .updateValue(new Error("Status missing for thermostat"));
-        }
+      }
     });
@@ -226,6 +226,8 @@ });
       .updateValue(device.TargetHeatingCoolingState);
-    service.getCharacteristic(Characteristic.CoolingThresholdTemperature)
-      .updateValue(device.CoolingThresholdTemperature);
-    service.getCharacteristic(Characteristic.HeatingThresholdTemperature)
-      .updateValue(device.HeatingThresholdTemperature);
+    if (device.device.UI.CanSetSwitchAuto) {
+      service.getCharacteristic(Characteristic.CoolingThresholdTemperature)
+        .updateValue(device.CoolingThresholdTemperature);
+      service.getCharacteristic(Characteristic.HeatingThresholdTemperature)
+        .updateValue(device.HeatingThresholdTemperature);
+    }
 
@@ -255,3 +257,3 @@ // Fakegato Support
   this.refresh = that.refresh;
-  debug("TccAccessory()", device);
+  // debug("TccAccessory()", device);
 
@@ -278,3 +280,3 @@ var uuid = UUIDGen.generate(this.name + " - TCC");
   if (!getAccessoryByName(this.name)) {
-    this.log("Adding TCC Device (deviceID="+this.ThermostatID+")", this.name);
+    this.log("Adding TCC Device (deviceID=" + this.ThermostatID + ")", this.name);
     this.accessory = new Accessory(this.name, uuid, 10);
@@ -295,5 +297,5 @@ this.accessory.log = that.log;
     // check if user wants separate temperature and humidity sensors by zone/thermostat
-    debug ("createInsideSensors: ",createInsideSensors);
+    debug("createInsideSensors: ", createInsideSensors);
     if (createInsideSensors) {
-      debug("TccAccessory() " + this.name + " InsideTemperature = true, existing sensor");
+      // debug("TccAccessory() " + this.name + " InsideTemperature = true, existing sensor");
       this.InsideTemperatureService = this.accessory.addService(Service.TemperatureSensor, this.name + " Temperature", "Inside");
@@ -339,22 +341,23 @@ this.InsideTemperatureService
 
-    // if (this.device.UI.CanSetSwitchAuto) {
-    // Only available on models with an Auto Mode
-    this.accessory
-      .getService(Service.Thermostat)
-      .getCharacteristic(Characteristic.CoolingThresholdTemperature)
-      .setProps({
-        minValue: parseFloat(device.TargetTemperatureCoolMinValue),
-        maxValue: parseFloat(device.TargetTemperatureCoolMaxValue)
-      })
-      .on('set', setCoolingThresholdTemperature.bind(this.accessory));
+    if (device.device.UI.CanSetSwitchAuto) {
+      // Only available on models with an Auto Mode
+      this.accessory
+        .getService(Service.Thermostat)
+        .getCharacteristic(Characteristic.CoolingThresholdTemperature)
+        .setProps({
+          minValue: parseFloat(device.TargetTemperatureCoolMinValue),
+          maxValue: parseFloat(device.TargetTemperatureCoolMaxValue)
+        })
+        .on('set', setCoolingThresholdTemperature.bind(this.accessory));
 
-    // this.addOptionalCharacteristic(Characteristic.HeatingThresholdTemperature);
-    this.accessory
-      .getService(Service.Thermostat)
-      .getCharacteristic(Characteristic.HeatingThresholdTemperature)
-      .setProps({
-        minValue: parseFloat(device.TargetTemperatureHeatMinValue),
-        maxValue: parseFloat(device.TargetTemperatureHeatMaxValue)
-      })
-      .on('set', setHeatingThresholdTemperature.bind(this.accessory));
+      // this.addOptionalCharacteristic(Characteristic.HeatingThresholdTemperature);
+      this.accessory
+        .getService(Service.Thermostat)
+        .getCharacteristic(Characteristic.HeatingThresholdTemperature)
+        .setProps({
+          minValue: parseFloat(device.TargetTemperatureHeatMinValue),
+          maxValue: parseFloat(device.TargetTemperatureHeatMaxValue)
+        })
+        .on('set', setHeatingThresholdTemperature.bind(this.accessory));
+    }
 
@@ -379,3 +382,3 @@ this.accessory
   } else {
-    this.log("Existing TCC accessory (deviceID="+this.ThermostatID+")", this.name);
+    this.log("Existing TCC accessory (deviceID=" + this.ThermostatID + ")", this.name);
     // need to check if accessory/zone/thermostat already exists, but user added temp/humidity sensors then must declare
@@ -420,3 +423,3 @@ this.accessory = getAccessoryByName(this.name);
   if (!getAccessoryByName(this.name)) {
-    this.log("Adding TCC Outside Sensors (deviceID="+this.ThermostatID+")", this.name);
+    this.log("Adding TCC Outside Sensors (deviceID=" + this.ThermostatID + ")", this.name);
     this.accessory = new Accessory(this.name, uuid, 10);
@@ -459,3 +462,3 @@ this.accessory.log = that.log;
   } else {
-    this.log("Existing TCC outside sensors accessory (deviceID="+this.ThermostatID+")", this.name);
+    this.log("Existing TCC outside sensors accessory (deviceID=" + this.ThermostatID + ")", this.name);
 
@@ -462,0 +465,0 @@ // need to check if accessory/zone/thermostat already exists, but user added temp/humidity sensors then must declare

package.json

 {
   "name": "homebridge-tcc",
-  "version": "0.2.24",
+  "version": "0.2.25",
   "description": "Honeywell Total Connect Comfort support for Homebridge: https://github.com/nfarina/homebridge",
@@ -5,0 +5,0 @@ "license": "ISC",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

58255

increased by0.18%

Lines of code

1381

increased by0.15%

No dependency changes