http2 - npm Package Compare versions

Comparing version 2.5.0 to 2.5.1

HISTORY.md

 Version history
 ===============
 
+### 2.5.1 (2014-05-25) ###
+
+* Support for node 0.11.x
+* New cipher suite priority list with comformant ciphers on the top (only available in node >=0.11.x)
+
 ### 2.5.0 (2014-04-24) ###
@@ -5,0 +10,0 @@

lib/http.js

@@ -160,2 +160,43 @@ // Public API
 
+// Ciphersuite list based on the recommendations of http://wiki.mozilla.org/Security/Server_Side_TLS
+// The only modification is that kEDH+AESGCM were placed after DHE and ECDHE suites
+var cipherSuites = [
+  'ECDHE-RSA-AES128-GCM-SHA256',
+  'ECDHE-ECDSA-AES128-GCM-SHA256',
+  'ECDHE-RSA-AES256-GCM-SHA384',
+  'ECDHE-ECDSA-AES256-GCM-SHA384',
+  'DHE-RSA-AES128-GCM-SHA256',
+  'DHE-DSS-AES128-GCM-SHA256',
+  'ECDHE-RSA-AES128-SHA256',
+  'ECDHE-ECDSA-AES128-SHA256',
+  'ECDHE-RSA-AES128-SHA',
+  'ECDHE-ECDSA-AES128-SHA',
+  'ECDHE-RSA-AES256-SHA384',
+  'ECDHE-ECDSA-AES256-SHA384',
+  'ECDHE-RSA-AES256-SHA',
+  'ECDHE-ECDSA-AES256-SHA',
+  'DHE-RSA-AES128-SHA256',
+  'DHE-RSA-AES128-SHA',
+  'DHE-DSS-AES128-SHA256',
+  'DHE-RSA-AES256-SHA256',
+  'DHE-DSS-AES256-SHA',
+  'DHE-RSA-AES256-SHA',
+  'kEDH+AESGCM',
+  'AES128-GCM-SHA256',
+  'AES256-GCM-SHA384',
+  'ECDHE-RSA-RC4-SHA',
+  'ECDHE-ECDSA-RC4-SHA',
+  'AES128',
+  'AES256',
+  'RC4-SHA',
+  'HIGH',
+  '!aNULL',
+  '!eNULL',
+  '!EXPORT',
+  '!DES',
+  '!3DES',
+  '!MD5',
+  '!PSK'
+].join(':');
+
 // Logging
@@ -372,2 +413,4 @@ // -------
     options.NPNProtocols = supportedProtocols;
+    options.ciphers = options.ciphers || cipherSuites;
+    options.honorCipherOrder = (options.honorCipherOrder != false);
     this._server = https.createServer(options);
@@ -744,2 +787,3 @@ this._originalSocketListeners = this._server.listeners('secureConnection');
     options.agent = this._httpsAgent;
+    options.ciphers = options.ciphers || cipherSuites;
     var httpsRequest = https.request(options);
@@ -749,4 +793,4 @@
       var negotiatedProtocol = socket.alpnProtocol || socket.npnProtocol;
-      if (negotiatedProtocol !== undefined) {
-        negotiated();
+      if (negotiatedProtocol) {
+        negotiated()
       } else {
@@ -753,0 +797,0 @@ socket.on('secureConnect', negotiated);

package.json

 {
   "name": "http2",
-  "version": "2.5.0",
+  "version": "2.5.1",
   "description": "An HTTP/2 client and server implementation",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

README.md

@@ -119,6 +119,6 @@ node-http2
 ```
-Statements   : 93.19% ( 397/426 )
-Branches     : 79.88% ( 131/164 )
+Statements   : 93.26% ( 401/430 )
+Branches     : 80.36% ( 135/168 )
 Functions    : 93.75% ( 60/64 )
-Lines        : 93.19% ( 397/426 )
+Lines        : 93.26% ( 401/430 )
 ```
@@ -125,0 +125,0 @@

test/http.js

@@ -127,4 +127,4 @@ var expect = require('chai').expect;
           http2.get('https://localhost:1234' + path, function(response) {
-            response.on('readable', function() {
-              expect(response.read().toString()).to.equal(message);
+            response.on('data', function(data) {
+              expect(data.toString()).to.equal(message);
               server.close();
@@ -144,4 +144,4 @@ done();
           expect(request.url).to.equal(path);
-          request.once('readable', function() {
-            expect(request.read().toString()).to.equal(message);
+          request.once('data', function(data) {
+            expect(data.toString()).to.equal(message);
             response.end();
@@ -214,4 +214,4 @@ });
             expect(response.headers['date']).to.equal(undefined);
-            response.on('readable', function() {
-              expect(response.read().toString()).to.equal(message);
+            response.on('data', function(data) {
+              expect(data.toString()).to.equal(message);
               server.close();
@@ -244,4 +244,4 @@ done();
           }, function(response) {
-            response.on('readable', function() {
-              expect(response.read().toString()).to.equal(message);
+            response.on('data', function(data) {
+              expect(data.toString()).to.equal(message);
               server.close();
@@ -267,4 +267,4 @@ done();
           http2.get('https://localhost:5678' + path, function(response) {
-            response.on('readable', function() {
-              expect(response.read().toString()).to.equal(message);
+            response.on('data', function(data) {
+              expect(data.toString()).to.equal(message);
               done();
@@ -288,4 +288,4 @@ });
           https.get('https://localhost:1236' + path, function(response) {
-            response.on('readable', function() {
-              expect(response.read().toString()).to.equal(message);
+            response.on('data', function(data) {
+              expect(data.toString()).to.equal(message);
               done();
@@ -311,4 +311,4 @@ });
           http2.get('https://localhost:1237' + path, function(response) {
-            response.on('readable', function() {
-              expect(response.read().toString()).to.equal(message);
+            response.on('data', function(data) {
+              expect(data.toString()).to.equal(message);
               done();
@@ -319,4 +319,4 @@ });
           http2.get('https://localhost:1237' + path, function(response) {
-            response.on('readable', function() {
-              expect(response.read().toString()).to.equal(message);
+            response.on('data', function(data) {
+              expect(data.toString()).to.equal(message);
               done();
@@ -341,9 +341,9 @@ });
           http2.get('https://localhost:1238' + path, function(response) {
-            response.on('readable', function() {
-              expect(response.read().toString()).to.equal(message);
+            response.on('data', function(data) {
+              expect(data.toString()).to.equal(message);
 
               // 2. request
               http2.get('https://localhost:1238' + path, function(response) {
-                response.on('readable', function() {
-                  expect(response.read().toString()).to.equal(message);
+                response.on('data', function(data) {
+                  expect(data.toString()).to.equal(message);
                   done();
@@ -410,4 +410,4 @@ });
           request.on('response', function(response) {
-            response.on('readable', function() {
-              expect(response.read().toString()).to.equal(message);
+            response.on('data', function(data) {
+              expect(data.toString()).to.equal(message);
               done();
@@ -421,4 +421,4 @@ });
             promise.on('response', function(pushStream) {
-              pushStream.on('readable', function() {
-                expect(pushStream.read().toString()).to.equal(pushedMessage);
+              pushStream.on('data', function(data) {
+                expect(data.toString()).to.equal(pushedMessage);
                 done();
@@ -425,0 +425,0 @@ });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

75592

increased by1.64%

Lines of code

1473

increased by3.01%

No dependency changes