image-resolver - npm Package Compare versions

Comparing version 0.5.3 to 0.5.4

package.json

 {
   "name": "image-resolver",
-  "version": "0.5.3",
+  "version": "0.5.4",
   "description": "Extract main image for a given URL",
@@ -5,0 +5,0 @@ "main": "src/ImageResolver.js",

src/plugins/Flickr.js

@@ -5,3 +5,3 @@ /**
 
-var API_URL = 'http://api.flickr.com/services/rest/?method=flickr.photos.getSizes&api_key={{APIKEY}}&photo_id={{ID}}&format=json&nojsoncallback=1';
+var API_URL = 'https://api.flickr.com/services/rest/?method=flickr.photos.getSizes&api_key={{APIKEY}}&photo_id={{ID}}&format=json&nojsoncallback=1';
 
@@ -45,2 +45,2 @@ function Flickr(apikey) {
 
-module.exports = Flickr;
+module.exports = Flickr;

src/plugins/Webpage.js

@@ -96,2 +96,6 @@ /**
 
+                if ( !img[i].attribs['src'] ) {
+                    continue;
+                }
+
                 //Compute surface
@@ -143,2 +147,2 @@ var w = img[i].attribs['width'] || 1;
 
-module.exports = Webpage;
+module.exports = Webpage;

tests/node/spec/FlickrSpec.js

@@ -18,3 +18,3 @@ var ImageResolver = require('../../../src/ImageResolver');
         runs(function(){
-            expect(result.image).toBe("http://farm9.staticflickr.com/8431/7543031692_494bed13d4_b.jpg");
+            expect(result.image).toBe("https://farm9.staticflickr.com/8431/7543031692_494bed13d4_b.jpg");
         });
@@ -37,5 +37,5 @@ });
         runs(function(){
-            expect(result.image).toBe("http://farm3.staticflickr.com/2906/14248906772_8cc69441ee_b.jpg");
+            expect(result.image).toBe("https://farm3.staticflickr.com/2906/14248906772_8cc69441ee_b.jpg");
         });
     });
 });

tests/node/spec/WebpageSpec.js

@@ -22,1 +22,19 @@ var ImageResolver = require('../../../src/ImageResolver');
 });
+
+describe("Webpage : no image", function(){
+    it("should return the image URL", function(){
+        var result;
+        imageresolver.resolve(
+            "http://perdu.com/",
+            function(res){
+                result = ( res === null ) ? true : false;
+            }
+        );
+        waitsFor(function(){
+            return result;
+        }, 10000);
+        runs(function(){
+            expect(result).toBe(true);
+        });
+    });
+});

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

794779

increased by88.18%

Number of package files

35

increased by2.94%

Lines of code

22042

increased by90.03%

Worsened metrics

Number of low supply chain risk alerts

10

increased by100%

Number of medium supply chain risk alerts

10

increased by66.67%

No dependency changes