ldapts - npm Package Compare versions

Comparing version 2.6.1 to 2.7.0

CHANGELOG.md

@@ -0,1 +1,5 @@
+### 2.7.0
+  * Support NewSuperior with modifyDN. PR #84 Thanks @IsraelFrid!
+  * Update npms
+
 ### 2.6.1
@@ -2,0 +6,0 @@ * Added documentation for `explicitBufferAttributes` attribute

Client.d.ts

@@ -95,4 +95,4 @@ /// <reference types="node" />
     private connected;
-    private socket;
-    private connectTimer;
+    private socket?;
+    private connectTimer?;
     private readonly messageParser;
@@ -99,0 +99,0 @@ private readonly messageDetailsByMessageId;

Client.js

@@ -17,3 +17,3 @@ "use strict";
     var result = {};
-    if (mod != null) for (var k in mod) if (k !== "default" && Object.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
+    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
     __setModuleDefault(result, mod);
@@ -99,5 +99,7 @@ return result;
         const originalSocket = this.socket;
-        originalSocket.removeListener('data', this.socketDataHandler);
-        // Reuse existing socket
-        options.socket = originalSocket;
+        if (originalSocket) {
+            originalSocket.removeListener('data', this.socketDataHandler);
+            // Reuse existing socket
+            options.socket = originalSocket;
+        }
         this.socket = await new Promise((resolve, reject) => {
@@ -109,3 +111,5 @@ const secureSocket = tls.connect(options);
                 secureSocket.on('error', () => {
-                    originalSocket.destroy();
+                    if (originalSocket) {
+                        originalSocket.destroy();
+                    }
                 });
@@ -119,4 +123,6 @@ resolve(secureSocket);
         });
-        // Allows pending messages and unbind responses to be handled and cleaned up
-        this.socket.id = originalSocket.id;
+        if (originalSocket) {
+            // Allows pending messages and unbind responses to be handled and cleaned up
+            this.socket.id = originalSocket.id;
+        }
     }
@@ -312,3 +318,8 @@ /**
         }
-        // TODO: parse newDN to determine if newSuperior should be specified
+        let newSuperior;
+        if (typeof newDN === 'string' && newDN.includes(',')) {
+            const parseIndex = newDN.indexOf(',');
+            newSuperior = newDN.slice(parseIndex + 1);
+            newDN = newDN.slice(0, parseIndex);
+        }
         const req = new messages_1.ModifyDNRequest({
@@ -319,2 +330,3 @@ messageId: this._nextMessageId(),
             newRdn: typeof newDN === 'string' ? newDN : newDN.toString(),
+            newSuperior,
             controls,
@@ -518,7 +530,11 @@ });
     _onConnect(next) {
-        clearTimeout(this.connectTimer);
+        if (this.connectTimer) {
+            clearTimeout(this.connectTimer);
+        }
         // Clear out event listeners from _connect()
-        this.socket.removeAllListeners('error');
-        this.socket.removeAllListeners('connect');
-        this.socket.removeAllListeners('secureConnect');
+        if (this.socket) {
+            this.socket.removeAllListeners('error');
+            this.socket.removeAllListeners('connect');
+            this.socket.removeAllListeners('secureConnect');
+        }
         this.connected = true;
@@ -538,3 +554,5 @@ // region Socket events handlers
             }
-            this.socket.destroy();
+            if (this.socket) {
+                this.socket.destroy();
+            }
         };
@@ -583,7 +601,9 @@ function socketEnd() {
         // Hook up event listeners
-        this.socket.on('error', socketError);
-        this.socket.on('close', socketClose);
-        this.socket.on('data', this.socketDataHandler);
-        this.socket.on('end', socketEnd);
-        this.socket.on('timeout', socketTimeout);
+        if (this.socket) {
+            this.socket.on('error', socketError);
+            this.socket.on('close', socketClose);
+            this.socket.on('data', this.socketDataHandler);
+            this.socket.on('end', socketEnd);
+            this.socket.on('timeout', socketTimeout);
+        }
         return next();
@@ -649,3 +669,5 @@ }
                 logDebug('Unbind success. Ending socket');
-                this._endSocket(this.socket);
+                if (this.socket) {
+                    this._endSocket(this.socket);
+                }
             }
@@ -652,0 +674,0 @@ else {

dn/index.js

@@ -10,3 +10,3 @@ "use strict";
 var __exportStar = (this && this.__exportStar) || function(m, exports) {
-    for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
+    for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
@@ -13,0 +13,0 @@ Object.defineProperty(exports, "__esModule", { value: true });

errors/index.js

@@ -10,3 +10,3 @@ "use strict";
 var __exportStar = (this && this.__exportStar) || function(m, exports) {
-    for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
+    for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
@@ -13,0 +13,0 @@ Object.defineProperty(exports, "__esModule", { value: true });

errors/resultCodeErrors/index.js

@@ -10,3 +10,3 @@ "use strict";
 var __exportStar = (this && this.__exportStar) || function(m, exports) {
-    for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
+    for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
@@ -13,0 +13,0 @@ Object.defineProperty(exports, "__esModule", { value: true });

filters/index.js

@@ -10,3 +10,3 @@ "use strict";
 var __exportStar = (this && this.__exportStar) || function(m, exports) {
-    for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
+    for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
@@ -13,0 +13,0 @@ Object.defineProperty(exports, "__esModule", { value: true });

index.js

@@ -10,3 +10,3 @@ "use strict";
 var __exportStar = (this && this.__exportStar) || function(m, exports) {
-    for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
+    for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
@@ -13,0 +13,0 @@ Object.defineProperty(exports, "__esModule", { value: true });

MessageParser.d.ts

@@ -5,3 +5,2 @@ /// <reference types="node" />
 import { MessageResponse } from './messages/MessageResponse';
-declare type MessageParserEmitter = StrictEventEmitter<EventEmitter, MessageParserEvents>;
 interface MessageParserEvents {
@@ -11,2 +10,3 @@ message: (message: MessageResponse) => void;
 }
+declare type MessageParserEmitter = StrictEventEmitter<EventEmitter, MessageParserEvents>;
 declare const MessageParser_base: new () => MessageParserEmitter;
@@ -13,0 +13,0 @@ export declare class MessageParser extends MessageParser_base {

MessageParser.js

@@ -17,3 +17,3 @@ "use strict";
     var result = {};
-    if (mod != null) for (var k in mod) if (k !== "default" && Object.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
+    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
     __setModuleDefault(result, mod);
@@ -20,0 +20,0 @@ return result;

messages/AbandonRequest.js

@@ -17,3 +17,3 @@ "use strict";
     var result = {};
-    if (mod != null) for (var k in mod) if (k !== "default" && Object.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
+    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
     __setModuleDefault(result, mod);
@@ -20,0 +20,0 @@ return result;

messages/index.js

@@ -10,3 +10,3 @@ "use strict";
 var __exportStar = (this && this.__exportStar) || function(m, exports) {
-    for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
+    for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
@@ -13,0 +13,0 @@ Object.defineProperty(exports, "__esModule", { value: true });

package.json

 {
   "name": "ldapts",
-  "version": "2.6.1",
+  "version": "2.7.0",
   "description": "LDAP client",
@@ -47,32 +47,32 @@ "main": "index.js",
     "@types/asn1": "~0.2.0",
-    "@types/node": "~14.0.23",
-    "@types/uuid": "~8.0.0",
+    "@types/node": "~14.6.4",
+    "@types/uuid": "~8.3.0",
     "asn1": "~0.2.4",
     "debug": "~4.1.1",
     "strict-event-emitter-types": "~2.0.0",
-    "uuid": "~8.2.0"
+    "uuid": "~8.3.0"
   },
   "devDependencies": {
-    "@types/chai": "~4.2.11",
+    "@types/chai": "~4.2.12",
     "@types/chai-as-promised": "~7.1.3",
     "@types/debug": "~4.1.5",
-    "@types/mocha": "~8.0.0",
-    "@typescript-eslint/eslint-plugin": "~3.6.1",
-    "@typescript-eslint/parser": "~3.6.1",
+    "@types/mocha": "~8.0.3",
+    "@typescript-eslint/eslint-plugin": "~4.0.1",
+    "@typescript-eslint/parser": "~4.0.1",
     "chai": "~4.2.0",
     "chai-as-promised": "~7.1.1",
-    "eslint": "~7.4.0",
+    "eslint": "~7.8.1",
     "eslint-config-airbnb-base": "~14.2.0",
     "eslint-plugin-import": "~2.22.0",
-    "eslint-plugin-jsdoc": "~29.2.0",
-    "eslint-plugin-mocha": "~7.0.1",
+    "eslint-plugin-jsdoc": "~30.3.2",
+    "eslint-plugin-mocha": "~8.0.0",
     "eslint-plugin-promise": "~4.2.1",
     "eslint-plugin-security": "~1.4.0",
     "husky": "~3.1.0",
-    "lint-staged": "~10.2.11",
-    "mocha": "~8.0.1",
+    "lint-staged": "~10.3.0",
+    "mocha": "~8.1.3",
     "ts-mockito": "~2.6.1",
-    "ts-node": "~8.10.2",
-    "typescript": "~3.9.6"
+    "ts-node": "~9.0.0",
+    "typescript": "~4.0.2"
   }
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

331765

increased by0.43%

Lines of code

5054

increased by0.44%

Dependency changes

• + Added@types/node@14.6.4(transitive)

• + Added@types/uuid@8.3.4(transitive)

• + Addeduuid@8.3.2(transitive)

• - Removed@types/node@14.0.27(transitive)

• - Removed@types/uuid@8.0.1(transitive)

• - Removeduuid@8.2.0(transitive)

• Updated@types/node@~14.6.4

• Updated@types/uuid@~8.3.0

• Updateduuid@~8.3.0