lunr - npm Package Compare versions

Comparing version 2.1.1 to 2.1.2

lib/match_data.js

@@ -7,9 +7,25 @@ /**
  * @constructor
- * @property {object} metadata - A collection of metadata associated with this document.
+ * @param {string} term - The term this match data is associated with
+ * @param {string} field - The field in which the term was found
+ * @param {object} metadata - The metadata recorded about this term in this field
+ * @property {object} metadata - A cloned collection of metadata associated with this document.
  * @see {@link lunr.Index~Result}
  */
 lunr.MatchData = function (term, field, metadata) {
-  this.metadata = {}
-  this.metadata[term] = {}
-  this.metadata[term][field] = metadata
+  var clonedMetadata = Object.create(null),
+      metadataKeys = Object.keys(metadata)
+
+  // Cloning the metadata to prevent the original
+  // being mutated during match data combination.
+  // Metadata is kept in an array within the inverted
+  // index so cloning the data can be done with
+  // Array#slice
+  for (var i = 0; i < metadataKeys.length; i++) {
+    var key = metadataKeys[i]
+    clonedMetadata[key] = metadata[key].slice()
+  }
+
+  this.metadata = Object.create(null)
+  this.metadata[term] = Object.create(null)
+  this.metadata[term][field] = clonedMetadata
 }
@@ -34,3 +50,3 @@
     if (this.metadata[term] == undefined) {
-      this.metadata[term] = {}
+      this.metadata[term] = Object.create(null)
     }
@@ -43,3 +59,3 @@
       if (this.metadata[term][field] == undefined) {
-        this.metadata[term][field] = {}
+        this.metadata[term][field] = Object.create(null)
       }
@@ -46,0 +62,0 @@

package.json

 {
   "name": "lunr",
   "description": "Simple full-text search in your browser.",
-  "version": "2.1.1",
+  "version": "2.1.2",
   "author": "Oliver Nightingale",
@@ -6,0 +6,0 @@ "keywords": [

test/match_data_test.js

@@ -30,3 +30,13 @@ suite('lunr.MatchData', function () {
     })
+
+    test('does not mutate source data', function () {
+      var metadata = { foo: [1] },
+          matchData1 = new lunr.MatchData('foo', 'title', metadata),
+          matchData2 = new lunr.MatchData('foo', 'title', metadata)
+
+      matchData1.combine(matchData2)
+
+      assert.deepEqual(metadata.foo, [1])
+    })
   })
 })

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

18627

increased by0.16%

Worsened metrics

Total package byte prevSize

596063

decreased by-3.68%

Number of package files

78

decreased by-1.27%

No dependency changes