lynda-copy-course - npm Package Compare versions

Comparing version 1.0.3 to 1.0.4

bin/lynda-copy-course.js

@@ -5,3 +5,7 @@ #!/usr/bin/env node
 var index_1 = require("../src/index");
-index_1["default"].main();
+var minimist = require("minimist");
+var args = minimist(process.argv.slice(2));
+var sourceDir = args._[0];
+var destDir = args._[1];
+index_1["default"].copy(sourceDir, destDir);
 //# sourceMappingURL=lynda-copy-course.js.map

bin/lynda-copy-course.ts

 #!/usr/bin/env node
 
 import CourseCopier from '../src/index'
+import * as minimist from 'minimist'
 
-CourseCopier.main();
+let args = minimist(process.argv.slice(2));
+let sourceDir: string = args._[0];
+let destDir: string = args._[1];
+
+CourseCopier.copy(sourceDir, destDir);

package.json

 {
   "name": "lynda-copy-course",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "A command-line utility for copying downloaded Lynda.com courses from one machine to another",
@@ -19,2 +19,3 @@ "bin": {
   "dependencies": {
+    "minimist": "^1.2.0",
     "ncp": "^2.0.0",
@@ -21,0 +22,0 @@ "sqlite3": "^3.1.8"

src/index.js

@@ -7,9 +7,18 @@ "use strict";
 var ncp_1 = require("ncp");
+var sqliteDB = function (databasePath, access) {
+    return new sqlite3.Database(databasePath, access, function (err) {
+        if (err)
+            console.log(err.message);
+    });
+};
+var databasePath = function (directoryPath) {
+    return path.join(directoryPath, 'db.sqlite');
+};
 var LyndaCourseCopier = (function () {
     function LyndaCourseCopier() {
     }
-    LyndaCourseCopier.main = function () {
+    LyndaCourseCopier.copy = function (sourceDir, destDir) {
         try {
-            LyndaCourseCopier.directoryIsALyndaFolder(process.argv[2]);
-            LyndaCourseCopier.directoryIsALyndaFolder(process.argv[3]);
+            LyndaCourseCopier.directoryIsALyndaFolder(sourceDir);
+            LyndaCourseCopier.directoryIsALyndaFolder(destDir);
         }
@@ -20,12 +29,4 @@ catch (err) {
         }
-        var sourceDir = process.argv[2];
-        var destDir = process.argv[3];
-        var sourceDB = new sqlite3.Database(path.join(sourceDir, 'db.sqlite'), sqlite3.OPEN_READONLY, function (err) {
-            if (err)
-                console.log(err.message);
-        });
-        var destDB = new sqlite3.Database(path.join(destDir, 'db.sqlite'), sqlite3.OPEN_READWRITE, function (err) {
-            if (err)
-                console.log(err.message);
-        });
+        var sourceDB = sqliteDB(databasePath(sourceDir), sqlite3.OPEN_READONLY);
+        var destDB = sqliteDB(databasePath(destDir), sqlite3.OPEN_READWRITE);
         var tables = [
@@ -32,0 +33,0 @@ "Author", "Chapter", "Course", "Video"

src/index.ts

@@ -6,8 +6,28 @@ import * as fs from 'fs'
 
+let sqliteDB = (databasePath: string, access: number): sqlite3.Database => {
+    return new sqlite3.Database(
+        databasePath,
+        access,
+        (err: Error) => {
+            if (err) console.log(err.message);
+        }
+    );
+}
+
+let databasePath = (directoryPath: string): string => {
+    return path.join(directoryPath, 'db.sqlite');
+}
+
 export default class LyndaCourseCopier {
-    public static main(): number {
+    /**
+     * Copies all courses from the source directory into the destination directory.
+     * 
+     * @param sourceDir Directory containing courses to be copied
+     * @param destDir Directory to copy courses to
+     */
+    public static copy(sourceDir: string, destDir: string): number {
         // validate input
         try {
-            LyndaCourseCopier.directoryIsALyndaFolder(process.argv[2])
-            LyndaCourseCopier.directoryIsALyndaFolder(process.argv[3])
+            LyndaCourseCopier.directoryIsALyndaFolder(sourceDir)
+            LyndaCourseCopier.directoryIsALyndaFolder(destDir)
         } catch (err) {
@@ -18,17 +38,11 @@ console.log(err);
 
-        let sourceDir = process.argv[2];
-        let destDir = process.argv[3];
+        let sourceDB = sqliteDB(
+            databasePath(sourceDir),
+            sqlite3.OPEN_READONLY
+        );
 
-        let sourceDB = new sqlite3.Database(
-            path.join(sourceDir, 'db.sqlite'),
-            sqlite3.OPEN_READONLY,
-            (err: Error) => {
-                if (err) console.log(err.message);
-            });
-        let destDB = new sqlite3.Database(
-            path.join(destDir, 'db.sqlite'),
-            sqlite3.OPEN_READWRITE,
-            (err: Error) => {
-                if (err) console.log(err.message)
-            })
+        let destDB = sqliteDB(
+            databasePath(destDir),
+            sqlite3.OPEN_READWRITE
+        );
 
@@ -35,0 +49,0 @@ let tables: Array<string> = [

No alert changes

Improved metrics

Lines of code

255

increased by9.44%

Worsened metrics

Total package byte prevSize

181250

decreased by-29.55%

Dependency count

3

increased by50%

Number of package files

19

decreased by-5%

Dependency changes

• + Addedminimist@^1.2.0

• + Addedminimist@1.2.8(transitive)