node-fetch - npm Package Compare versions

Comparing version 1.2.0 to 1.2.1

CHANGELOG.md

@@ -8,4 +8,8 @@
 
-## v1.2.0 (master)
+## v1.2.1 (master)
 
+- Enhance: `Headers` now normalized `Number` value to `String`, prevent common mistakes
+
+## v1.2.0
+
 - Enhance: now fetch.Headers and fetch.Response are exposed, making testing easier
@@ -12,0 +16,0 @@

lib/headers.js

@@ -34,5 +34,9 @@
 			this.set(prop, headers[prop]);
+
+		} else if (typeof headers[prop] === 'number' && !isNaN(headers[prop])) {
+			this.set(prop, headers[prop].toString());
+
 		} else if (headers[prop] instanceof Array) {
 			headers[prop].forEach(function(item) {
-				self.append(prop, item);
+				self.append(prop, item.toString());
 			});
@@ -39,0 +43,0 @@ }

package.json

 {
   "name": "node-fetch",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "A light-weight module that brings window.fetch to node.js and io.js",
@@ -5,0 +5,0 @@ "main": "index.js",

test/test.js

@@ -630,5 +630,7 @@
 		var FakeHeader = function() {};
-		FakeHeader.prototype.z = 'string';
+		// prototypes are ignored
+		FakeHeader.prototype.z = 'fake';
 
 		var res = new FakeHeader;
+		// valid
 		res.a = 'string';
@@ -638,26 +640,33 @@ res.b = ['1','2'];
 		res.d = [];
-		res.e = { a:1 };
-		res.f = 1;
-		res.g = undefined;
-		res.h = null;
-		res.i = NaN;
-		res.j = true;
-		res.k = false;
+		// common mistakes, normalized
+		res.e = 1;
+		res.f = [1, 2];
+		// invalid, ignored
+		res.g = { a:1 };
+		res.h = undefined;
+		res.i = null;
+		res.j = NaN;
+		res.k = true;
+		res.l = false;
 
-		var headers = new Headers(res);
+		var h1 = new Headers(res);
 
-		expect(headers._headers['a']).to.include('string');
-		expect(headers._headers['b']).to.include('1');
-		expect(headers._headers['b']).to.include('2');
-		expect(headers._headers['c']).to.include('');
+		expect(h1._headers['a']).to.include('string');
+		expect(h1._headers['b']).to.include('1');
+		expect(h1._headers['b']).to.include('2');
+		expect(h1._headers['c']).to.include('');
+		expect(h1._headers['d']).to.be.undefined;
 
-		expect(headers._headers['d']).to.be.undefined;
-		expect(headers._headers['e']).to.be.undefined;
-		expect(headers._headers['f']).to.be.undefined;
-		expect(headers._headers['g']).to.be.undefined;
-		expect(headers._headers['h']).to.be.undefined;
-		expect(headers._headers['i']).to.be.undefined;
-		expect(headers._headers['j']).to.be.undefined;
-		expect(headers._headers['k']).to.be.undefined;
-		expect(headers._headers['z']).to.be.undefined;
+		expect(h1._headers['e']).to.include('1');
+		expect(h1._headers['f']).to.include('1');
+		expect(h1._headers['f']).to.include('2');
+
+		expect(h1._headers['g']).to.be.undefined;
+		expect(h1._headers['h']).to.be.undefined;
+		expect(h1._headers['i']).to.be.undefined;
+		expect(h1._headers['j']).to.be.undefined;
+		expect(h1._headers['k']).to.be.undefined;
+		expect(h1._headers['l']).to.be.undefined;
+
+		expect(h1._headers['z']).to.be.undefined;
 	});
@@ -664,0 +673,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

45458

increased by0.8%

Lines of code

1236

increased by0.73%

No dependency changes