node-fetch - npm Package Compare versions

Comparing version 1.7.2 to 1.7.3

CHANGELOG.md

@@ -10,2 +10,6 @@
 
+## v1.7.3
+
+- Enhance: `FetchError` now gives a correct trace stack (backport from v2.x relese).
+
 ## v1.7.2
@@ -12,0 +16,0 @@

lib/fetch-error.js

@@ -20,5 +20,2 @@
 
-	// hide custom error implementation details from end-users
-	Error.captureStackTrace(this, this.constructor);
-
 	this.name = this.constructor.name;
@@ -33,4 +30,6 @@ this.message = message;
 
+	// hide custom error implementation details from end-users
+	Error.captureStackTrace(this, this.constructor);
 }
 
 require('util').inherits(FetchError, Error);

package.json

 {
   "name": "node-fetch",
-  "version": "1.7.2",
+  "version": "1.7.3",
   "description": "A light-weight module that brings window.fetch to node.js and io.js",
@@ -5,0 +5,0 @@ "main": "index.js",

test/test.js

@@ -1461,3 +1461,3 @@
 
-	it('should create custom FetchError', function() {
+	it('should create custom FetchError', function funcName() {
 		var systemError = new Error('system');
@@ -1474,2 +1474,4 @@ systemError.code = 'ESOMEERROR';
 		expect(err.errno).to.equal('ESOMEERROR');
+		expect(err.stack).to.include('funcName');
+		expect(err.stack.split('\n')[0]).to.equal(err.name + ': ' + err.message);
 	});
@@ -1476,0 +1478,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

122035

increased by0.18%

Lines of code

3533

increased by0.06%

No dependency changes