node-gyp - npm Package Compare versions

Comparing version 3.6.0 to 3.6.1

CHANGELOG.md

@@ -0,1 +1,20 @@
+v3.6.1 2017-04-30
+=================
+
+* [[`49801716c2`](https://github.com/nodejs/node-gyp/commit/49801716c2)] - **test**: fix test-find-python on v0.10.x buildbot. (Ben Noordhuis) [#1172](https://github.com/nodejs/node-gyp/pull/1172)
+* [[`a83a3801fc`](https://github.com/nodejs/node-gyp/commit/a83a3801fc)] - **test**: fix test/test-configure-python on AIX (Richard Lau) [#1131](https://github.com/nodejs/node-gyp/pull/1131)
+* [[`8a767145c9`](https://github.com/nodejs/node-gyp/commit/8a767145c9)] - **gyp**: Revert quote_cmd workaround (Kunal Pathak) [#1153](https://github.com/nodejs/node-gyp/pull/1153)
+* [[`c09cf7671e`](https://github.com/nodejs/node-gyp/commit/c09cf7671e)] - **doc**: add a note for using `configure` on Windows (Vse Mozhet Byt) [#1152](https://github.com/nodejs/node-gyp/pull/1152)
+* [[`da9cb5f411`](https://github.com/nodejs/node-gyp/commit/da9cb5f411)] - Delete superfluous .patch files. (Ben Noordhuis) [#1122](https://github.com/nodejs/node-gyp/pull/1122)
+
+v3.6.0 2017-03-16
+=================
+
+* [[`ae141e1906`](https://github.com/nodejs/node-gyp/commit/ae141e1906)] - **win**: find and setup for VS2017 (Refael Ackermann) [#1130](https://github.com/nodejs/node-gyp/pull/1130)
+* [[`ec5fc36a80`](https://github.com/nodejs/node-gyp/commit/ec5fc36a80)] - Add support to build node.js with chakracore for ARM. (Kunal Pathak) [#873](https://github.com/nodejs/node-gyp/pull/873)
+* [[`a04ea3051a`](https://github.com/nodejs/node-gyp/commit/a04ea3051a)] - Add support to build node.js with chakracore. (Kunal Pathak) [#873](https://github.com/nodejs/node-gyp/pull/873)
+* [[`93d7fa83c8`](https://github.com/nodejs/node-gyp/commit/93d7fa83c8)] - Upgrade semver dependency. (Ben Noordhuis) [#1107](https://github.com/nodejs/node-gyp/pull/1107)
+* [[`ff9a6fadfd`](https://github.com/nodejs/node-gyp/commit/ff9a6fadfd)] - Update link of gyp as Google code is shutting down (Peter Dave Hello) [#1061](https://github.com/nodejs/node-gyp/pull/1061)
+
+
 v3.5.0 2017-01-10
@@ -2,0 +21,0 @@ =================

lib/configure.js

@@ -378,2 +378,3 @@ module.exports = exports = configure
   log: log,
+  resolve: path.win32 && path.win32.resolve || path.resolve,
   stat: fs.stat,
@@ -503,4 +504,3 @@ which: which,
     }
-    var resolve = path.win32 && path.win32.resolve || path.resolve
-    var pythonPath = resolve(rootDir, 'Python27', 'python.exe')
+    var pythonPath = this.resolve(rootDir, 'Python27', 'python.exe')
     this.log.verbose('ensuring that file exists:', pythonPath)
@@ -507,0 +507,0 @@ this.stat(pythonPath, function (err, stat) {

package.json

@@ -14,3 +14,3 @@ {
   ],
-  "version": "3.6.0",
+  "version": "3.6.1",
   "installVersion": 9,
@@ -17,0 +17,0 @@ "author": "Nathan Rajlich <[e-mail]> (http://tootallnate.net)",

README.md

@@ -94,2 +94,8 @@ node-gyp
 
+Auto-detection fails for Visual C++ Build Tools 2015, so `--msvs_version=2015`
+needs to be added (not needed when run by npm as configured above):
+``` bash
+$ node-gyp configure --msvs_version=2015
+```
+
 __Note__: The `configure` step looks for the `binding.gyp` file in the current
@@ -96,0 +102,0 @@ directory to process. See below for instructions on creating the `binding.gyp` file.

test/test-configure-python.js

@@ -9,2 +9,4 @@ 'use strict'
   'graceful-fs': {
+    'openSync': function (file, mode) { return 0; },
+    'closeSync': function (fd) { },
     'writeFile': function (file, data, cb) { cb() },
@@ -30,3 +32,3 @@ 'stat': function (file, cb) { cb(null, {}) }
   }
-  configure(prog, [])
+  configure(prog, [], t.fail)
 })
@@ -51,3 +53,3 @@
   }
-  configure(prog, [])
+  configure(prog, [], t.fail)
 })
@@ -74,3 +76,3 @@
   }
-  configure(prog, [])
+  configure(prog, [], t.fail)
 })

test/test-find-python.js

 'use strict'
 
 var test = require('tape')
+var path = require('path')
 var configure = require('../lib/configure')
@@ -37,2 +38,10 @@ var execFile = require('child_process').execFile
 
+// Work around a v0.10.x CI issue where path.resolve() on UNIX systems prefixes
+// Windows paths with the current working directory.  v0.12 and up are free of
+// this issue because they use path.win32.resolve() which does the right thing.
+var resolve = path.win32 && path.win32.resolve || function() {
+  function rstrip(s) { return s.replace(/\\+$/, '') }
+  return [].slice.call(arguments).map(rstrip).join('\\')
+}
+
 function TestPythonFinder() { PythonFinder.apply(this, arguments) }
@@ -42,2 +51,3 @@ TestPythonFinder.prototype = Object.create(PythonFinder.prototype)
 poison(TestPythonFinder.prototype, 'execFile')
+poison(TestPythonFinder.prototype, 'resolve')
 poison(TestPythonFinder.prototype, 'stat')
@@ -292,2 +302,3 @@ poison(TestPythonFinder.prototype, 'which')
   }
+  f.resolve = resolve
   f.stat = function(path, cb) {
@@ -319,2 +330,3 @@ t.ok(re.test(path))
   }
+  f.resolve = resolve
   f.stat = function(path, cb) {
@@ -321,0 +333,0 @@ t.ok(/Z:[\\\/]Python27[\\\/]python.exe/.test(path))

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

2965

increased by0.44%

Number of lines in readme file

226

increased by2.73%

Worsened metrics

Total package byte prevSize

1662077

decreased by-0.11%

Number of package files

110

decreased by-2.65%

No dependency changes