node-hot-loader - npm Package Compare versions

Comparing version 1.7.1 to 1.8.0

CHANGELOG.md

@@ -0,1 +1,8 @@
+<a name="1.8.0"></a>
+## 1.8.0 (2018-04-27)
+
+* Improve error logging ([d78c1c1](https://github.com/vlazh/node-hot-loader/commit/d78c1c1))
+
+
+
 <a name="1.7.1"></a>
@@ -2,0 +9,0 @@ ## <small>1.7.1 (2018-04-09)</small>

lib/HmrClient.js

@@ -25,3 +25,3 @@ 'use strict';
     this.logApplyResult = (updatedModules, renewedModules) => {
-      const unacceptedModules = updatedModules.filter(moduleId => renewedModules && renewedModules.indexOf(moduleId) < 0);
+      const unacceptedModules = !renewedModules || !renewedModules.length ? updatedModules : updatedModules.filter(moduleId => renewedModules.indexOf(moduleId) < 0);
 
@@ -35,14 +35,19 @@ if (unacceptedModules.length > 0) {
 
-      if (!renewedModules || renewedModules.length === 0) {
+      if (!renewedModules || !renewedModules.length) {
         this.logger.info('Nothing hot updated.');
-      } else {
-        this.logger.info('Updated modules:');
-        renewedModules.forEach(moduleId => {
-          this.logger.info(` - ${moduleId}`);
-        });
-        const numberIds = renewedModules.every(moduleId => typeof moduleId === 'number');
-        if (numberIds) {
-          this.logger.info('Consider using the NamedModulesPlugin for module names.');
-        }
+        return;
       }
+
+      this.logger.info('Updated modules:');
+      renewedModules.forEach(moduleId => {
+        this.logger.info(` - ${moduleId}`);
+      });
+      const numberIds = renewedModules.every(moduleId => typeof moduleId === 'number');
+      if (numberIds) {
+        this.logger.info('Consider using the NamedModulesPlugin for module names.');
+      }
+
+      if (this.upToDate()) {
+        this.logger.info('App is up to date.');
+      }
     };
@@ -75,3 +80,2 @@
           this.logger.warn('Cannot find update. Need to do restart server!');
-          // this.logger.warn( '(Probably because of restarting the server)');
           return null;
@@ -84,10 +88,11 @@ }
           ignoreErrored: true,
-          onUnaccepted: data => {
-            this.logger.warn(`Ignored an update to unaccepted module ${data.chain.join(' -> ')}`);
+          onUnaccepted: info => {
+            this.logger.warn(`Ignored an update to unaccepted module ${info.chain.join(' -> ')}`);
           },
-          onDeclined: data => {
-            this.logger.warn(`Ignored an update to declined module ${data.chain.join(' -> ')}`);
+          onDeclined: info => {
+            this.logger.warn(`Ignored an update to declined module ${info.chain.join(' -> ')}`);
           },
-          onErrored: data => {
-            this.logger.warn(`Ignored an error while updating module ${data.moduleId} (${data.type})`);
+          onErrored: info => {
+            this.logger.error(`Ignored an error while updating module ${info.moduleId} (${info.type})`);
+            throw info.error; // for log error in catch and not invoke then.
           }
@@ -100,6 +105,2 @@ }).then(renewedModules => {
           this.logApplyResult(updatedModules, renewedModules);
-
-          if (this.upToDate()) {
-            this.logger.info('App is up to date.');
-          }
         });
@@ -112,3 +113,3 @@ }).catch(err => {
         } else {
-          this.logger.warn(`Update check failed: ${err.stack}` || err.message);
+          this.logger.error(`Update check failed: ${err.stack}` || err.message);
         }
@@ -115,0 +116,0 @@ });

package.json

 {
   "name": "node-hot-loader",
-  "version": "1.7.1",
+  "version": "1.8.0",
   "description": "Hot module replacement for Node.js applications",
@@ -65,2 +65,3 @@ "main": "./lib/node-hot.js",
   "devDependencies": {
+    "@types/webpack-env": "^1.13.6",
     "@vzh/configs": "^0.66.0",
@@ -67,0 +68,0 @@ "babel-cli": "^6.26.0",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

40610

increased by0.47%

Worsened metrics

Dev dependency count

16

increased by6.67%

No dependency changes