pagexray - npm Package Compare versions

Comparing version 0.8.0 to 0.9.0

CHANGELOG.md

 # CHANGELOG - PageXray
 
+version 0.9.0 - 2016-05-20
+------------------------
+### Changed
+* Always report default content types (html, css, javascript etc) + add others. Before we only added the types that was in the HAR.
+
+* Make sure content size is > -1 (sometimes Firefox HAR have assets that are -1 in size).
+
 version 0.8.0 - 2016-05-15
@@ -11,4 +18,3 @@ ------------------------
 ### Changed
-New structure for domains to be able to support 1st vs 3rd party assets. Supply a regex for 1st party domains 
-and you will get stats for 1st vs 3rd.
+New structure for domains to be able to support 1st vs 3rd party assets. Supply a regex for 1st party domains and you will get stats for 1st vs 3rd.
 
@@ -18,3 +24,3 @@ version 0.6.0 - 2016-04-18
 ### Fixed
-* Fix content type matching for json.
+* Fix content type matching for JSON.
 
@@ -21,0 +27,0 @@ ### Changed

lib/collect.js

 'use strict';
 
 let util = require('./util'),
-  headers= require('./headers');
+  headers = require('./headers');
 
@@ -89,10 +89,11 @@ /*
         // header vs content size?
-        myPage.contentTypes[asset.type].transferSize += asset.transferSize;
-        myPage.contentTypes[asset.type].contentSize += asset.contentSize;
-        myPage.contentTypes[asset.type].headerSize += asset.headerSize;
+        // Firefox sometimes has asset size -1 in HAR files
+        myPage.contentTypes[asset.type].transferSize += asset.transferSize > 0 ? asset.transferSize : 0;
+        myPage.contentTypes[asset.type].contentSize += asset.contentSize > 0 ? asset.contentSize : 0;
+        myPage.contentTypes[asset.type].headerSize += asset.headerSize > 0 ? asset.headerSize : 0;
       } else {
         myPage.contentTypes[asset.type] = {
-          transferSize: asset.transferSize,
-          contentSize: asset.contentSize,
-          headerSize: asset.headerSize,
+          transferSize: asset.transferSize > 0 ? asset.transferSize : 0,
+          contentSize: asset.contentSize > 0 ? asset.contentSize : 0,
+          headerSize: asset.headerSize > 0 ? asset.headerSize : 0,
           requests: 1
@@ -99,0 +100,0 @@ };

lib/index.js

@@ -44,3 +44,36 @@ 'use strict';
           httpVersion: util.getHTTPVersion(har.log.entries[0].response.httpVersion),
-          contentTypes: {},
+          // we have a couple of default content tyypes that we always reports
+          // if we find others, just add them
+          contentTypes: {
+            html: {
+              transferSize: 0,
+              contentSize: 0,
+              headerSize: 0,
+              requests: 0
+            },
+            css: {
+              transferSize: 0,
+              contentSize: 0,
+              headerSize: 0,
+              requests: 0
+            },
+            javascript: {
+              transferSize: 0,
+              contentSize: 0,
+              headerSize: 0,
+              requests: 0
+            },
+            image: {
+              transferSize: 0,
+              contentSize: 0,
+              headerSize: 0,
+              requests: 0
+            },
+            font: {
+              transferSize: 0,
+              contentSize: 0,
+              headerSize: 0,
+              requests: 0
+            }
+          },
           assets: [],
@@ -47,0 +80,0 @@ responseCodes: {},

package.json

 {
   "name": "pagexray",
-  "version": "0.8.0",
+  "version": "0.9.0",
   "description": "Xray your HAR file and know all about the page",
@@ -5,0 +5,0 @@ "keywords": [

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

21599

increased by6.99%

Lines of code

434

increased by8.5%

No dependency changes