protractor - npm Package Compare versions

Comparing version 2.2.0 to 2.3.0

config.json

 {
   "webdriverVersions": {
-    "selenium": "2.45.0",
-    "chromedriver": "2.15",
-    "iedriver": "2.45.0"
+    "selenium": "2.47.1",
+    "chromedriver": "2.19",
+    "iedriver": "2.47.0"
   }
 }

CONTRIBUTING.md

@@ -9,11 +9,11 @@ Contributing
 
-Please ask questions on [StackOverflow](http://stackoverflow.com/questions/tagged/protractor) or [Google Group discussion list](https://groups.google.com/forum/?fromgroups#!forum/angular).
+Please ask questions on [StackOverflow](http://stackoverflow.com/questions/tagged/protractor), [Google Group discussion list](https://groups.google.com/forum/?fromgroups#!forum/angular), or [Gitter](https://gitter.im/angular/protractor).
 
 Any questions posted to Protractor's Github Issues will be closed with this note:
 
-`
-Please read the [contributing guidelines](https://github.com/angular/protractor/blob/master/CONTRIBUTING.md#questions); these types of questions are ill-suited for GitHub. Thanks!
-`
+Please direct general support questions like this one to an appropriate support channel, see https://github.com/angular/protractor/blob/master/CONTRIBUTING.md#questions
 
+Thank you!
 
+
 Issues
@@ -27,3 +27,3 @@ ------
 When submitting an issue, please include context from your test and
-your application. If there's an error, please include the error text. Try running with troubleshooting messages (`protractor --troubleshoot`) against your configuration to make sure that there is not an error with your setup.
+your application. Include a reproducible case that we can actually run, if possible. If there's an error, please include the error text. Try running with troubleshooting messages (`protractor --troubleshoot`) against your configuration to make sure that there is not an error with your setup.
 
@@ -30,0 +30,0 @@ Please format code and markup in your issue using [github markdown](https://help.github.com/articles/github-flavored-markdown).

docs/faq.md

@@ -194,1 +194,6 @@ FAQ
 is complete before continuing.
+
+I still have a question
+-----------------------
+
+Please see our [Contributing Guidelines](https://github.com/angular/protractor/blob/master/CONTRIBUTING.md#questions) for questions and issues.

lib/configParser.js

@@ -99,3 +99,8 @@ var path = require('path'),
     for (var i = 0; i < patterns.length; ++i) {
-      var matches = glob.sync(patterns[i], {cwd: cwd});
+      // Cucumber allows running a spec given a line number. See
+      // https://github.com/angular/protractor/issues/2413
+      var fileName = patterns[i].split(':')[0],
+          lineNumber = patterns[i].split(':')[1],
+          matches = glob.sync(fileName, {cwd: cwd});
+
       if (!matches.length && !opt_omitWarnings) {
@@ -105,3 +110,7 @@ log.warn('pattern ' + patterns[i] + ' did not match any files.');
       for (var j = 0; j < matches.length; ++j) {
-        resolvedFiles.push(path.resolve(cwd, matches[j]));
+        var resolvedPath = path.resolve(cwd, matches[j]);
+        if(lineNumber) {
+          resolvedPath += ':' + lineNumber;
+        }
+        resolvedFiles.push(resolvedPath);
       }
@@ -108,0 +117,0 @@ }

lib/debugger/debuggerCommons.js

@@ -23,2 +23,3 @@ var baseDebugger = require('_debugger');
     }, function() {
+      process.send('ready');
       client.reqContinue(function() {
@@ -25,0 +26,0 @@ // Intentionally blank.

lib/debugger/modes/debuggerRepl.js

@@ -103,22 +103,22 @@ var util = require('util');
         frame: 0,
-        maxStringLength: 4000,
-        expression: 'protractor.promise.controlFlow().getControlFlowText()'
+        maxStringLength: 1000,
+        expression: 'command.getName()'
       }
-    }, function(err, controlFlowResponse) {
-      if (!err) {
-        self.client.req({
-          command: 'evaluate',
-          arguments: {
-            frame: 0,
-            maxStringLength: 1000,
-            expression: 'command.getName()'
-          }
-        }, function(err, res) {
-          if (res.value) {
-            console.log('-- Next command: ' + res.value);
-          }
+    }, function(err, res) {
+      if (res.value) {
+        console.log('-- Next command: ' + res.value);
+      }
+      self.client.req({
+        command: 'evaluate',
+        arguments: {
+          frame: 0,
+          maxStringLength: 4000,
+          expression: 'protractor.promise.controlFlow().getControlFlowText()'
+        }
+      }, function(err, controlFlowResponse) {
+        if (controlFlowResponse.value) {
           console.log(controlFlowResponse.value);
-          callback();
-        });
-      }
+        }
+        callback();
+      });
     });
@@ -125,0 +125,0 @@ };

lib/protractor.js

@@ -10,2 +10,3 @@ var util = require('util');
 var build$$ = require('./element').build$$;
+var Plugins = require('./plugins');
 
@@ -193,2 +194,9 @@ var clientSideScripts = require('./clientsidescripts.js');
 
+  /*
+   * Set by the runner.
+   *
+   * @type {Plugins} Object containing plugin funtions from config.
+   */
+  this.plugins_ = new Plugins({});
+
   /**
@@ -826,3 +834,4 @@ * The reset URL to use between page loads.
   var browserUnderDebug = this;
-  flow.execute(function() {    
+  var debuggerReadyPromise = webdriver.promise.defer();
+  flow.execute(function() {   
     log.puts('Starting WebDriver debugger in a child process. Pause is ' +
@@ -839,12 +848,18 @@ 'still beta, please report issues at github.com/angular/protractor\n');
         nodedebug.kill('SIGTERM');
-      }); 
+      });
+      nodedebug.on('message', function(m) {
+        if (m === 'ready') {
+          debuggerReadyPromise.fulfill();
+        }
+      });
     });
   });
-  
-  var pausePromise = flow.timeout(1000, 'waiting for debugger to attach')
-      .then(function() {
-        // Necessary for backward compatibility with node < 0.12.0
-        browserUnderDebug.executeScript_('', 'empty debugger hook');
-      });
 
+  var pausePromise = flow.execute(function() {
+    return debuggerReadyPromise.then(function() {
+      // Necessary for backward compatibility with node < 0.12.0
+      return browserUnderDebug.executeScript_('', 'empty debugger hook');
+    });
+  });
+
   // Helper used only by debuggers at './debugger/modes/*.js' to insert code
@@ -851,0 +866,0 @@ // into the control flow.

package.json

@@ -20,4 +20,4 @@ {
     "jasminewd2": "0.0.5",
-    "jasmine": "2.3.1",
-    "saucelabs": "~0.1.0",
+    "jasmine": "2.3.2",
+    "saucelabs": "~1.0.1",
     "glob": "~3.2",
@@ -34,9 +34,8 @@ "adm-zip": "0.4.4",
     "expect.js": "~0.2.0",
-    "chai": "~1.8.1",
-    "chai-as-promised": "~4.1.0",
+    "chai": "~3.3.0",
+    "chai-as-promised": "~5.1.0",
     "jshint": "2.5.0",
-    "mocha": "1.21.4",
-    "cucumber": "~0.4.9",
+    "mocha": "2.3.3",
+    "cucumber": "~0.6.0",
     "express": "~3.3.4",
-    "lodash": "~2.4.1",
     "rimraf": "~2.2.6"
@@ -59,3 +58,3 @@ },
   "license": "MIT",
-  "version": "2.2.0"
+  "version": "2.3.0"
 }

plugins/accessibility/index.js

@@ -45,3 +45,3 @@ var q = require('q'),
 
-var AUDIT_FILE = path.join(__dirname, '../../node_modules/accessibility-developer-tools/dist/js/axs_testing.js');
+var AUDIT_FILE = require.resolve('accessibility-developer-tools/dist/js/axs_testing.js');
 var TENON_URL = 'http://www.tenon.io/api/';
@@ -48,0 +48,0 @@

README.md

 Protractor [![Build Status](https://travis-ci.org/angular/protractor.png?branch=master)](https://travis-ci.org/angular/protractor)
 ==========
 
-[Protractor](http://angular.github.io/protractor) is an end-to-end test framework for [AngularJS](http://angularjs.org/) applications. Protractor is a [Node.js](http://nodejs.org/) program built on top of [WebDriverJS](https://code.google.com/p/selenium/wiki/WebDriverJs). Protractor runs tests against your application running in a real browser, interacting with it as a user would. 
+[Protractor](http://angular.github.io/protractor) is an end-to-end test framework for [AngularJS](http://angularjs.org/) applications. Protractor is a [Node.js](http://nodejs.org/) program built on top of [WebDriverJS](https://github.com/SeleniumHQ/selenium/wiki/WebDriverJs). Protractor runs tests against your application running in a real browser, interacting with it as a user would. 
 
@@ -45,2 +45,5 @@
     npm install
+    cd website
+    npm install
+    cd ..
 
@@ -47,0 +50,0 @@ Start up a selenium server. By default, the tests expect the selenium server to be running at `http://localhost:4444/wd/hub`.

scripts/unit_test.json

 {
   "spec_dir": "",
   "spec_files": [
-    "spec/unit/*.js"
+    "spec/unit/*.js",
+    "website/docgen/spec/*.js"
   ]
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1859545

increased by0.26%

Dev dependency count

8

decreased by-11.11%

Number of package files

163

increased by0.62%

Lines of code

11909

increased by0.2%

Number of lines in readme file

58

increased by5.45%

Dependency changes

• + Addedagent-base@2.1.1(transitive)

• + Addeddebug@2.6.9(transitive)

• + Addedextend@3.0.2(transitive)

• + Addedhttps-proxy-agent@1.0.0(transitive)

• + Addedjasmine@2.3.2(transitive)

• + Addedms@2.0.0(transitive)

• + Addedsaucelabs@1.0.1(transitive)

• + Addedsemver@5.0.3(transitive)

• - Removedjasmine@2.3.1(transitive)

• - Removedsaucelabs@0.1.1(transitive)

• Updatedjasmine@2.3.2

• Updatedsaucelabs@~1.0.1