qunit - npm Package Compare versions

Comparing version 2.14.0 to 2.14.1

bin/qunit.js

@@ -41,18 +41,19 @@ #!/usr/bin/env node
 
-if ( program.reporter === true ) {
+const opts = program.opts();
+
+if ( opts.reporter === true ) {
 	displayAvailableReporters();
 }
 
-const args = program.args;
 const options = {
-	filter: program.filter,
-	reporter: findReporter( program.reporter ),
-	requires: program.require,
-	seed: program.seed
+	filter: opts.filter,
+	reporter: findReporter( opts.reporter ),
+	requires: opts.require,
+	seed: opts.seed
 };
 
-if ( program.watch ) {
-	run.watch( args, options );
+if ( opts.watch ) {
+	run.watch( program.args, options );
 } else {
-	run( args, options );
+	run( program.args, options );
 }

History.md

 
+2.14.1 / 2021-03-14
+==================
+
+### Changed
+
+* CLI: Upgrade `commander` to 7.1.0. (Timo Tijhof) [#1564](https://github.com/qunitjs/qunit/issues/1564)
+
+### Fixed
+
+* Core: Restore strict mode compatibility (Edward Faulkner) [#1558](https://github.com/qunitjs/qunit/pull/1558)
+* HTML Reporter: Check for undefined `testItem` in testDone callback. (Timo Tijhof)
+
 2.14.0 / 2021-01-12
@@ -16,3 +28,3 @@ ==================
 
-* HTML Reporter: Set `main` and `navigation` ARIA roles. (Steve McClure) [#1084](https://github.com/qunitjs/qunit/issues/1084)
+* HTML Reporter: Set `main` and `navigation` ARIA roles. (Steve McClure) [#1427](https://github.com/qunitjs/qunit/issues/1427)
 * Core: Fix `QUnit.module.only` logic for unscoped modules. (Steve McClure) [#1272](https://github.com/qunitjs/qunit/issues/1272)
@@ -19,0 +31,0 @@ * Assert: Fix `assert.timeout()` bug causing a non-async test to fail. [#1539](https://github.com/qunitjs/qunit/issues/1539)

package.json

@@ -5,7 +5,7 @@ {
   "description": "The powerful, easy-to-use testing framework.",
-  "version": "2.14.0",
+  "version": "2.14.1",
   "homepage": "https://qunitjs.com",
   "author": {
     "name": "OpenJS Foundation and other contributors",
-    "url": "https://github.com/qunitjs/qunit/blob/2.14.0/AUTHORS.txt"
+    "url": "https://github.com/qunitjs/qunit/blob/2.14.1/AUTHORS.txt"
   },
@@ -45,3 +45,3 @@ "repository": {
   "dependencies": {
-    "commander": "6.2.0",
+    "commander": "7.1.0",
     "js-reporters": "1.2.3",
@@ -56,6 +56,6 @@ "node-watch": "0.7.1",
     "coveralls": "^3.1.0",
-    "eslint-config-jquery": "^1.0.1",
-    "eslint-plugin-html": "^6.0.3",
-    "eslint-plugin-node": "^8.0.1",
-    "eslint-plugin-qunit": "^3.2.0",
+    "eslint-config-jquery": "^3.0.0",
+    "eslint-plugin-html": "^6.1.1",
+    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-qunit": "^5.3.0",
     "execa": "^0.8.0",
@@ -97,3 +97,3 @@ "fixturify": "^0.3.4",
     "coverage:_cli": "nyc --use-spawn-wrap --silent bin/qunit.js test/cli/*.js",
-    "coverage:_main": "nyc instrument --in-place dist/ && grunt connect:nolivereload qunit",
+    "coverage:_main": "nyc instrument --in-place qunit/ && grunt connect:nolivereload qunit",
     "coveralls": "npm run coverage && cat coverage/lcov.info | coveralls"
@@ -104,3 +104,3 @@ },
       "bin/**",
-      "dist/**",
+      "qunit/**",
       "src/**"
@@ -107,0 +107,0 @@ ],

src/cli/require-qunit.js

@@ -6,3 +6,16 @@ // Depending on the exact usage, QUnit could be in one of several places, this
 
-		// First we attempt to find QUnit relative to the current working directory.
+		// For:
+		//
+		// - QUnit is installed as local dependency and invoked normally
+		//   within the current project, e.g. via `npm test`, `npm run …`,
+		//   or `node_modules/.bin/qunit`.
+		//   The below will lead to the same package directory that
+		//   the CLI command belonged to.
+		//
+		// - QUnit is installed both as local dependency in the current project,
+		//   and also globally installed via npm by the end-user.
+		//   If the user (accidentally) ran the CLI command from their global
+		//   install, then we prefer to stil use the qunit library file from the
+		//   current project's dependency.
+		// eslint-disable-next-line node/no-missing-require
 		const localQUnitPath = resolve( "qunit", {
@@ -17,20 +30,23 @@
 	} catch ( e ) {
-		try {
+		if ( e.code === "MODULE_NOT_FOUND" ) {
 
-			// Second, we use the globally installed QUnit
+			// For:
+			//
+			// - QUnit is installed globally via npm by the end-user, and the
+			//   the user ran this global CLI command in a project directory that
+			//   does not have a qunit dependency installed.
+			//   Use the library file relative to the global CLI command in that case.
+			//
+			// - We are running a local command from within the source directory
+			//   of the QUnit project itself (e.g. qunit Git repository).
+			//   Use the library file relative to this command, within the source directory.
+			//
+			// eslint-disable-next-line node/no-missing-require, node/no-unpublished-require
 			delete require.cache[ resolve( "../../qunit/qunit" ) ];
 			// eslint-disable-next-line node/no-missing-require, node/no-unpublished-require
 			return require( "../../qunit/qunit" );
-		} catch ( e ) {
-			if ( e.code === "MODULE_NOT_FOUND" ) {
+		}
 
-				// Finally, we use the local development version of QUnit
-				delete require.cache[ resolve( "../../dist/qunit" ) ];
-				// eslint-disable-next-line node/no-missing-require, node/no-unpublished-require
-				return require( "../../dist/qunit" );
-			}
-
-			throw e;
-		}
+		throw e;
 	}
 };

src/cli/run.js

@@ -82,3 +82,3 @@ "use strict";
 				if ( e.code === "ERR_REQUIRE_ESM" && ( !nodeVint || nodeVint >= 72 ) ) {
-					await import( filePath );
+					await import( filePath ); // eslint-disable-line node/no-unsupported-features/es-syntax
 				} else {
@@ -85,0 +85,0 @@ throw e;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

279755

increased by2.9%

Lines of code

6202

increased by0.73%

Dependency changes

• + Addedcommander@7.1.0(transitive)

• - Removedcommander@6.2.0(transitive)

• Updatedcommander@7.1.0