rc-tree - npm Package Compare versions

Comparing version 0.21.2 to 0.21.3

lib/Tree.js

@@ -50,2 +50,4 @@ 'use strict';
 
+function noop() {}
+
 var Tree = (function (_React$Component) {
@@ -126,8 +128,6 @@ _inherits(Tree, _React$Component);
       this.setState(st);
-      if (this.props.onTreeDragStart) {
-        this.props.onTreeDragStart({
-          event: e,
-          node: treeNode
-        });
-      }
+      this.props.onTreeDragStart({
+        event: e,
+        node: treeNode
+      });
     }
@@ -175,9 +175,7 @@ }, {
       this.setState(st);
-      if (this.props.onTreeDragEnter) {
-        this.props.onTreeDragEnter({
-          event: e,
-          node: treeNode,
-          expandedKeys: expandedKeys || this.state.expandedKeys
-        });
-      }
+      this.props.onTreeDragEnter({
+        event: e,
+        node: treeNode,
+        expandedKeys: expandedKeys || this.state.expandedKeys
+      });
     }
@@ -187,5 +185,3 @@ }, {
     value: function onDragOver(e, treeNode) {
-      if (this.props.onTreeDragOver) {
-        this.props.onTreeDragOver({ event: e, node: treeNode });
-      }
+      this.props.onTreeDragOver({ event: e, node: treeNode });
     }
@@ -195,5 +191,3 @@ }, {
     value: function onDragLeave(e, treeNode) {
-      if (this.props.onTreeDragLeave) {
-        this.props.onTreeDragLeave({ event: e, node: treeNode });
-      }
+      this.props.onTreeDragLeave({ event: e, node: treeNode });
     }
@@ -211,16 +205,15 @@ }, {
       });
-      if (this.props.onTreeDrop) {
-        var posArr = treeNode.props.pos.split('-');
-        var res = {
-          event: e,
-          node: treeNode,
-          dragNode: this.dragNode,
-          dragNodesKeys: this.dragNodesKeys,
-          dropPos: this.dropPos + Number(posArr[posArr.length - 1])
-        };
-        if (this.dropPos !== 0) {
-          res.dropToGap = true;
-        }
-        this.props.onTreeDrop(res);
+
+      var posArr = treeNode.props.pos.split('-');
+      var res = {
+        event: e,
+        node: treeNode,
+        dragNode: this.dragNode,
+        dragNodesKeys: this.dragNodesKeys,
+        dropPos: this.dropPos + Number(posArr[posArr.length - 1])
+      };
+      if (this.dropPos !== 0) {
+        res.dropToGap = true;
       }
+      this.props.onTreeDrop(res);
     }
@@ -309,5 +302,3 @@ }, {
       newSt.checkedKeys = checkedKeys;
-      if (this.props.onCheck) {
-        this.props.onCheck(newSt);
-      }
+      this.props.onCheck(newSt);
     }
@@ -345,5 +336,3 @@ }, {
       newSt.selectedKeys = selectedKeys;
-      if (props.onSelect) {
-        props.onSelect(newSt);
-      }
+      props.onSelect(newSt);
     }
@@ -636,26 +625,26 @@ }, {
 Tree.propTypes = {
-  prefixCls: _react2['default'].PropTypes.string,
-  checkable: _react2['default'].PropTypes.oneOfType([_react2['default'].PropTypes.bool, _react2['default'].PropTypes.node]),
-  multiple: _react2['default'].PropTypes.bool,
-  showLine: _react2['default'].PropTypes.bool,
-  showIcon: _react2['default'].PropTypes.bool,
-  defaultExpandAll: _react2['default'].PropTypes.bool,
-  defaultExpandedKeys: _react2['default'].PropTypes.arrayOf(_react2['default'].PropTypes.string),
-  checkedKeys: _react2['default'].PropTypes.arrayOf(_react2['default'].PropTypes.string),
-  defaultCheckedKeys: _react2['default'].PropTypes.arrayOf(_react2['default'].PropTypes.string),
-  selectedKeys: _react2['default'].PropTypes.arrayOf(_react2['default'].PropTypes.string),
-  defaultSelectedKeys: _react2['default'].PropTypes.arrayOf(_react2['default'].PropTypes.string),
-  onCheck: _react2['default'].PropTypes.func,
-  onSelect: _react2['default'].PropTypes.func,
-  onDataLoaded: _react2['default'].PropTypes.func,
-  onMouseEnter: _react2['default'].PropTypes.func,
-  onMouseLeave: _react2['default'].PropTypes.func,
-  onRightClick: _react2['default'].PropTypes.func,
-  onTreeDragStart: _react2['default'].PropTypes.func,
-  onTreeDragEnter: _react2['default'].PropTypes.func,
-  onTreeDragOver: _react2['default'].PropTypes.func,
-  onTreeDragLeave: _react2['default'].PropTypes.func,
-  onTreeDrop: _react2['default'].PropTypes.func,
-  openTransitionName: _react2['default'].PropTypes.string,
-  openAnimation: _react2['default'].PropTypes.oneOfType([_react2['default'].PropTypes.string, _react2['default'].PropTypes.object])
+  prefixCls: _react.PropTypes.string,
+  checkable: _react.PropTypes.oneOfType([_react.PropTypes.bool, _react.PropTypes.node]),
+  multiple: _react.PropTypes.bool,
+  showLine: _react.PropTypes.bool,
+  showIcon: _react.PropTypes.bool,
+  defaultExpandAll: _react.PropTypes.bool,
+  defaultExpandedKeys: _react.PropTypes.arrayOf(_react.PropTypes.string),
+  checkedKeys: _react.PropTypes.arrayOf(_react.PropTypes.string),
+  defaultCheckedKeys: _react.PropTypes.arrayOf(_react.PropTypes.string),
+  selectedKeys: _react.PropTypes.arrayOf(_react.PropTypes.string),
+  defaultSelectedKeys: _react.PropTypes.arrayOf(_react.PropTypes.string),
+  onCheck: _react.PropTypes.func,
+  onSelect: _react.PropTypes.func,
+  onDataLoaded: _react.PropTypes.func,
+  onMouseEnter: _react.PropTypes.func,
+  onMouseLeave: _react.PropTypes.func,
+  onRightClick: _react.PropTypes.func,
+  onTreeDragStart: _react.PropTypes.func,
+  onTreeDragEnter: _react.PropTypes.func,
+  onTreeDragOver: _react.PropTypes.func,
+  onTreeDragLeave: _react.PropTypes.func,
+  onTreeDrop: _react.PropTypes.func,
+  openTransitionName: _react.PropTypes.string,
+  openAnimation: _react.PropTypes.oneOfType([_react.PropTypes.string, _react.PropTypes.object])
 };
@@ -673,3 +662,10 @@
   defaultCheckedKeys: [],
-  defaultSelectedKeys: []
+  defaultSelectedKeys: [],
+  onCheck: noop,
+  onSelect: noop,
+  onTreeDragStart: noop,
+  onTreeDragEnter: noop,
+  onTreeDragOver: noop,
+  onTreeDragLeave: noop,
+  onTreeDrop: noop
 };
@@ -676,0 +672,0 @@

lib/TreeNode.js

@@ -389,7 +389,7 @@ 'use strict';
 TreeNode.propTypes = {
-  prefixCls: _react2['default'].PropTypes.string,
-  expanded: _react2['default'].PropTypes.bool,
-  isLeaf: _react2['default'].PropTypes.bool,
-  root: _react2['default'].PropTypes.object,
-  onSelect: _react2['default'].PropTypes.func
+  prefixCls: _react.PropTypes.string,
+  expanded: _react.PropTypes.bool,
+  isLeaf: _react.PropTypes.bool,
+  root: _react.PropTypes.object,
+  onSelect: _react.PropTypes.func
 };
@@ -396,0 +396,0 @@ TreeNode.defaultProps = {

package.json

 {
   "name": "rc-tree",
-  "version": "0.21.2",
+  "version": "0.21.3",
   "description": "tree ui component for react",
@@ -5,0 +5,0 @@ "keywords": [

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

56493

decreased by-1.12%

Lines of code

1437

decreased by-0.42%

No dependency changes